nicolasbonnici / cryptobot Goto Github PK

Hi again,

I noticed that the asset/currency pair is set as an exchange property. This means that strategies will only be able to trade on one pair and use information respective to that. Was this a conscious design choice?
If not, I would argue that it would be better to let it fall into a strategy's responsibility to decide on what pair to trade, e.g. by initialising a generic strategy with the pair i want it to trade or having a strategy that is optimised for a certain set of (multiple) coins.

Anyway, for now I implemented a quick pair class and pulled the pair dependency out of the exchange, for you to have a look.
Tell me what you think.

Cheers

Hi nicolas,

nice work so far. Could you perhaps add a short quick-start guide in the readme on how you setup the rest + postgres?

Best.

When I run the project with mode backtest, it throws connection error.
Do I need to run the REST api server and how do i do that?

In file backtest.py:

         dataset = Dataset().get({"exchange": exchange.name.lower(),
                                 "currency": exchange.currency.lower(),
                                 "asset": exchange.asset.lower(),
                                 "periodStart": period_start, "periodEnd": period_end, "candleSize": interval})

however, nowhere in the Dataset i can see .get method:

class Dataset(AbstractModel):
    resource_name = 'datasets'

    pair: str = ''
    exchange: str = ''
    period_start: str = ''
    period_end: str = ''
    currency: str = ''
    asset: str = ''

    relations = {'exchange': Exchange, 'currency': Currency, 'asset': Currency}

    def __init__(self, **kwargs):
        super().__init__(**kwargs)
        self.pair = self.get_pair()

    def get_pair(self):
        return utils.format_pair(self.currency, self.asset)

Any idea, what i am missing?

Hi,
I'm totally new to Github Project and hence i'm not able to install or run your project. I was able to download the whole zip of your files and pasted them into my anaconda directory, afterward i installed the requirements file and run into some errors which I fixed by installing the packages manually. But now I'm trying to run the main.py file with "python main" in my command shell and i keep running into the same error.
"UndefinedValueError('{} not found. Declare it as envvar or define a default value.'.format(option))
decouple.UndefinedValueError: API_ROOT not found. Declare it as envvar or define a default value."
I also placed my api keys for binance into the .env file. What am I doing wrong or how am I supposed to run it?

Sorry for the silly question just trying to figure out how to run any github project, thanks for the help in advance!

Hey,
I have wrote some strategy but i can't seem to figure out how to place a order can you please guide me. Thanks