nhsconnect / careconnectapi Goto Github PK

is there a better way to format the page so the URLs do not wrap around the table columns?

SK - Optional DSTU2 search params include some of the SHOULD implement params. I think perhaps we highlight the fact that DSTU2 ‘supports’ a wider range of search params..of which CC provider sys should as a minimum support the table of params
Recommended col – I am not sure I get this?
Patient:
To avoid confusion the Patient param sections should be renamed to reflect searching using ‘logical id’ and search using ‘business ID’ .
:systemUri is a uniform resource identifier – do we need to explicitly state what a URI is? I get the message, but again I think local creation of URIs should stay generic to the API spec
patient.identifier={systemUri}|[identifier] – this is a chained search

Copied from Ryver.

Mohsin KhalidMon 5:46pm
Hi All;

https://nhsconnect.github.io/CareConnectAPI/design_access.html
This site is not working properly some of the links are not opening ,for example the Care Connect Reference Implementation Guide link does not work

There is a date for when the site was last generated, but not a date for when the page was last modifed. From a readers perspective what I need to know is how current he page I am looking at is -- in this case the page says that teh interface has not yet been implemented - that may no longer be true if the content was written months or years ago.
https://nhsconnect.github.io/CareConnectAPI/engage_poc_bristolcc.html

SK

Code:
code={systemUri}|[code] – empty section??

To search for all resources with ‘Body composition measure’ codes using SNOMED CT – I tried this and couldn’t get the expected result. Can we discuss?
Date search type example uses prefixes – perhaps we could indicate in description

The documents page lists mime types for FHIR documents as application/xml+fhir and application/json+fhir but these changed from DSTU2 to STU3 and should really be application/fhir+xml and application/fhir+json in STU3.

Where is the careconnect-document of the 6. Next Steps in web page: https://nhsconnect.github.io/CareConnectAPI/build_patient_server.html

Update the readme.txt to have working images on the status section

Not sure why this is included. The organisations listed are no more relevant that a host of others. It adds nothing to the implementation guide so I suggest we remove it.

In the Contributing section of README.md there is a link to contributing guidelines (https://github.com/nhsconnect/CareConnectAPI/blob/develop) but it is dead.

https://nhsconnect.github.io/CareConnectAPI/engage_case_studies.html

Broken links found:

https://nhsconnect.github.io/engage_michaelsstory
https://nhsconnect.github.io/engage
https://nhsconnect.github.io/engage_poc_bristolcc

SK - SearchResponse:
The curl example is a GET query URL and NOT a response
Table with HTTP Header and value could do with expanding
XML – Should we explicitly state that CC API message format is ONLY XML representation at this stage

Click on a link from a resource page
e.g. https://nhsconnect.github.io/CareConnectAPI/api_medication_medicationstatement.html

The call fails with Warning!
Error: HTTP 415 Unsupported Media Type: Unsupported media type: mime json

This isn't a valid mime type, server only supports valid mime types (e.g. application/json)

The ECL in CareConnect-Condition-1.xml contains syntax error where it expresses a set of exclusions. In particular, the following constraint is syntactically incorrect as only a simple subExpression or a bracketed complex expression can follow the keyword MINUS:

< 243796009 |Situation with explicit context|: 246090004 |Associated finding| = ((< 404684003 |Clinical finding| MINUS << 420134006 |Propensity to adverse reactions| MINUS << 473010000 |Hypersensitivity condition| MINUS << 79899007 |Drug interaction| MINUS << 69449002 |Drug action| MINUS << 441742003 |Evaluation finding| MINUS << 307824009 |Administrative status| MINUS << 385356007 |Tumor stage finding|) OR < 272379006 |Event|)

The better way to write this would be:

< 243796009 |Situation with explicit context| : 246090004 |Associated finding| = ( ( < 404684003 |Clinical finding| MINUS ( << 420134006 |Propensity to adverse reactions| OR << 473010000 |Hypersensitivity condition| OR << 79899007 |Drug interaction| OR << 69449002 |Drug action| OR << 441742003 |Evaluation finding| OR << 307824009 |Administrative status| OR << 385356007 |Tumor stage finding|)) OR < 272379006 |Event|)

Results can be seen here

SK - I know ‘operation’ is technically correct but FHIR tends to refer to these as ‘interactions’ i.e. to avoid confusion with rpc calls

When navigating to the full list of API Response Codes from any location the page cannot be found.

Example pages where this is happening:

• Patient - https://nhsconnect.github.io/CareConnectAPI/api_entity_patient.html
• Encounter - https://nhsconnect.github.io/CareConnectAPI/api_workflow_encounter.html#

SK - search param. Returns a bundle of type searchset and not an instance of observation. This works, I’m not quite sure why it would be used.

Can we make sure that any payload examples have

1. been validated
2. includes the meta.profile element

on smaller screens bottom menu items are not visible.

Has been fixed on other NHS jekyll projects (see AH)

Why are we explicitly naming a supplier here. Does not seem appropriate @ahatherly what's your view?

need to move to live