Using this simple program: <div class="highlight highlight-source-go notranslate p

You can try this with the chromedp project: <div

Known issue <a class="issue-link js-issue-link" data-error-text="Failed to load title"

Filed a bug at <a href="https://bugs.chromium.org/p/chromium/issues/detail?id=954778"

See <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id

Read after write fails (Chrome DevTools Protocol server) about websocket HOT 10 CLOSED

nhooyr commented on May 18, 2024

Read after write fails (Chrome DevTools Protocol server)

from websocket.

Comments (10)

kenshaw commented on May 18, 2024

You can try this with the chromedp project:

$ cd $GOPATH/src && mkdir -p github.com/chromedp && cd github.com/chromedp
$ git clone -b test-websocket-impls https://github.com/kenshaw/chromedp.git
$ cd $GOPATH/src/github.com/chromedp/chromedp
$ go test -v -tags gorilla
$ go test -v -tags gobwas
$ go test -v -tags nhooyr

from websocket.

nhooyr commented on May 18, 2024

Thank you for the detailed report.

You seem to be using the package fine. Will fix the redundant and verbose errors in #47

I'm looking into this.

from websocket.

nhooyr commented on May 18, 2024

So I've gotten to the bottom of this. It looks like a bug in chrome's dp tooling to me.

It cannot handle continuation frames. With gorilla/websocket and gobwas/ws, you're sending a single text frame but with this library, first the text frame is sent, then a continuation frame that finishes the frame. This is just due to the streaming style API, it doesn't know when to finish the message until you call w.Close.

from websocket.

nhooyr commented on May 18, 2024

see

websocket/websocket_test.go

Lines 461 to 494 in d50ecee

 func TestChrome(t *testing.T) { 

 ctx, cancel := context.WithTimeout(context.Background(), time.Second*5) 

 defer cancel() 

 c, _, err := websocket.Dial(ctx, "ws://127.0.0.1:56213/devtools/browser/f6427288-77aa-49d6-983f-a4afe482d5b6") 

 if err != nil { 

 t.Fatal(err) 

 } 

 defer c.Close(websocket.StatusInternalError, "") 

 // write initial message 

 err = c.WriteFrame(ctx, websocket.MessageText, []byte(`{"id":1,"method":"Target.getTargets","params":{}}`)) 

 if err != nil { 

 t.Fatal(err) 

 } 

 log.Printf("wrote Target.getTargets message") 

 // read response 

 jc := websocket.JSONConn{ 

 Conn: c, 

 } 

 var v interface{} 

 err = jc.Read(ctx, &v) 

 if err != nil { 

 log.Fatalf("failed to read json: %v", err) 

 } 

 buf, err := json.Marshal(v) 

 if err != nil { 

 t.Fatal(err) 

 } 

 log.Printf("received %s", string(buf)) 

 c.Close(websocket.StatusNormalClosure, "") 

 }

I added a c.WriteFrame method to confirm this and now the code works. If you try and use the streaming API, it fails.

This is very surprising to me so I could be wrong, I'll check chrome's code.

from websocket.

nhooyr commented on May 18, 2024

Known issue ChromeDevTools/devtools-protocol#24

from websocket.

nhooyr commented on May 18, 2024

Filed a bug at https://bugs.chromium.org/p/chromium/issues/detail?id=954778

Thanks again for the report @kenshaw

from websocket.

nhooyr commented on May 18, 2024

Going to close this as it's not a bug in this library and I do not want to expose a function because of a bug in chrome. I'll keep that branch for now in case you want to use it.

from websocket.

kenshaw commented on May 18, 2024

While the Chrome Websocket implementation may not support this, it would be prudent for this package to do so, as the other websocket implementations available do. I agree it's not a bug in this package, but if you'd like greater adoption of this package, then it needs to support existing software in the wild. I imagine other websocket implementations also have this issue.

from websocket.

nhooyr commented on May 18, 2024

You make a solid point. Given I already have the code for this, I think its ok to expose a method that performs a write of a byte slice directly instead of returning a writecloser.

from websocket.

nhooyr commented on May 18, 2024

See #62

from websocket.

Read after write fails (Chrome DevTools Protocol server) about websocket HOT 10 CLOSED

Comments (10)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	func TestChrome(t *testing.T) {
	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
	defer cancel()

	c, _, err := websocket.Dial(ctx, "ws://127.0.0.1:56213/devtools/browser/f6427288-77aa-49d6-983f-a4afe482d5b6")
	if err != nil {
	t.Fatal(err)
	}
	defer c.Close(websocket.StatusInternalError, "")

	// write initial message
	err = c.WriteFrame(ctx, websocket.MessageText, []byte(`{"id":1,"method":"Target.getTargets","params":{}}`))
	if err != nil {
	t.Fatal(err)
	}
	log.Printf("wrote Target.getTargets message")

	// read response
	jc := websocket.JSONConn{
	Conn: c,
	}
	var v interface{}
	err = jc.Read(ctx, &v)
	if err != nil {
	log.Fatalf("failed to read json: %v", err)
	}
	buf, err := json.Marshal(v)
	if err != nil {
	t.Fatal(err)
	}
	log.Printf("received %s", string(buf))

	c.Close(websocket.StatusNormalClosure, "")
	}