Deadlocks due to CloseRead about websocket HOT 6 CLOSED

Copy. Will rework the close code ASAP. See also #427

from websocket.

Actually can you provide a trace?

CloseRead done's the wait group before it closes.

But I will concede the use of a wait group in this way is certainly potentially panicky as the wg.Add(1) call could occur concurrently with a close and thus panic.

from websocket.

@nhooyr the problem is that c.wg.Done() is deferred and called on exit from CloseRead. But CloseRead cannot exit because it calls Close which blocks on c.wg.Wait(). Same with context cancellation.

from websocket.

Oh I'm blind great point! Confirmed. 🤦🏼

from websocket.

Thanks for reporting. I've fixed this in #427. Please review and let me know if you see anything else.

from websocket.

Sorry for the delay. Fixed by #427.

from websocket.