Giter Club home page Giter Club logo

flightgnc.jl's People

Contributors

nhcho91 avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

jinraekim hnlee77

flightgnc.jl's Issues

[Suggestion] the role of this package; road map

Issue

I think that the current functionality of this package seems too similar to that of FlightSims.jl.

Suggestion

IMO, it's possible that this package exports only the core functionality of some FlightGNC stuffs (that you intended, perhaps guidance laws?) construct some off-the-shelf FlightSIms.jl-like Envs and Controllers using the core functionality of FlightGNC.jl in a new package, namely, FSImEnvs.jl.

For example, suppose that the following stuffs are ready-to-export in this package as

function dynamics_missile(p, v, u)
    # p_dot = ...
    p_dot, v_dot
end

function command_BPNG(p_M, v_M, something-like-them)
    # some appropriate outputs
end

and in FSimEnvs.jl, we may construct a FSim-like envs and controllers as the following.

struct MissileEnv <: AbstractEnv  # FSimBase-dependent
    # some-parameters-we-need
end
function Dynamics!(env::MissileEnv)
    @Loggable function dynamics!(dx, x, params, t; u)
        @unpack p, v = dx
        p_dot, v_dot = FlightGNC.dynamics_missile(p, v, u)
        dx.p = p_dot
        dx.v = v_dot
    end
end

abstract type MissileGuidance <: AbstractController  # FSimBase-dependent
struct  BPNG <: MissileGuidance
    # blahblah...
end
function Command(BPNG)  # FSimBase-dependent
    # blahblah...
end

Then, import FSimEnvs.jl in FlightSims.jl!

Notes

Why is it necessary?

  • This package can be a package independent of FlightSims.jl. It makes this package reusable regardless of users' simulator preference.
  • Also, there may be no big difference between FlightSims.jl and this package, which would be exhausting.

One more thing...

  • Of course, it's a suggestion. The code structure and road map of this package depend on you :)

TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.