nguillaumin / jflac Goto Github PK

Is it possible to make this available via a maven repository? e.g. bintray.com?

Hi, I am currently making use of this library as part of a project I am working on to simulate digital music playback from vintage cassette tapes (https://github.com/ns96/cassetteflowJava) and found out that skip is not supported in org.jflac.sound.spi.RingedAudioInputStream.skip(RingedAudioInputStream.java:374). Are there any plans to implement this? If not, what's a potential work around?

would it be possible to make this library compatible with javafx in a way that the Player extends MediaPlayer? I would really like to use flac files with javafx...

Hi, it would be great to have an up to date jflac on maven, thanks a lot!

For me and my flacs, the 2013 commit a0eb9b4 breaks flac file stream playing with jdk1.8.0_101, e.g., the example SndPlayer.java hangs because getFormat().getFrameSize() is 4 while getFrameLength() is -1. The example Player.java works, because it does not use RingedAudioInputStream. Would be nice if someone confirms.

Independent of this, many (not all) of my flac's stop playing prematurely/too early. Since years, I used to make the following change in jflac.sourceforge.net:

FlacAudioFileReader.java: last code line, replace audioFileFormat.getFrameLength() by audioFileFormat.getByteLength()

This doesn't agree to the java docs, so I suspect that this is an ugly hack for a bug somewhere else. I found now out that this is resolved in the other jflac fork https://github.com/drogatkin/JustFLAC which does work without this, they state that some bugs have been fixed (in 2013-2014).

Therefore I have merged the current codec+examples of JustFLAC into your nice maven environment, so one can do a mvn install, see
https://github.com/wolfgangasdf/jflac

A few of the codec-related commits of your repository are not in, but I also can't see directly why they are needed (and JustFlac contains also a seek function). I also had to disable a few unit tests because of changes made in JustFlac or in your jflac after the fork.

If you want to merge this, I could check with the JustFlac developers, cleanup a few things and make a pull request.

Best, wolfgang

when using Flac2PcmAudioInputStream, a reading thread goes into an infinite loop while attempting to read, in RingedAudioInputStream.read().
The cause was that when entering the read method, the code looked at frame.getFrameLength(), which in some cases might return a -1 value.
AudioInputStream's constructor tries to get the proper size, and if it finds an AudioSystem.NOT_SPECIFIED size, it sets the frame size to 1.

So i made a fix in RingedAudioInputStream.read(), where now getFrameLength() gets called rather then frame.getFrameLength().

Hello. Thanks for this great library. I noticed the codec module license is not clear.

• the published Maven artifact has no license information at all: http://search.maven.org/#artifactdetails|org.jflac|jflac-codec|1.5.1|jar
• the parent artifact states Apache license: http://search.maven.org/#artifactdetails|org.jflac|jflac-parent|1.5.1|pom
• the module directory states Apache (?) style license: https://github.com/nguillaumin/jflac/blob/master/jflac-codec/LICENSE.txt
• the source code states LGPL license: https://github.com/nguillaumin/jflac/blob/master/jflac-codec/src/main/java/org/jflac/FLACDecoder.java

When using jflac for decoding flac files code like AudioSystem.getAudioFileFormat(inputFile).getFormat() returns format with "unknown frame size, unknown frame rate". This prevents playback with this format and conversion of this format via javax.sound.sampled APIs.

Why is the frame size deemed unknown though? If instead of obtaining format I obtain AudioInputStream, this returns proper value via audioInputStream.getFrameLength(), albeit long.

But audioInputStream.getFormat().getFrameSize() returns -1. How come?