Giter Club home page Giter Club logo

Comments (6)

NetanelBasal avatar NetanelBasal commented on June 15, 2024 1

It's also weird because we register the focusout event that should bubble. I know it works with our custom input components. We should check how the component you added work.

from error-tailor.

NetanelBasal avatar NetanelBasal commented on June 15, 2024 1

You can make it more readable:

 return ['INPUT', 'SELECT', 'CUSTOM-DATE', 'P-CALENDAR'].some(selector => element.tagName === selector)

from error-tailor.

NetanelBasal avatar NetanelBasal commented on June 15, 2024

It will work on submit. We just need to provide a way to access the internal element to which we should register the blur event.

from error-tailor.

mlc-mlapis avatar mlc-mlapis commented on June 15, 2024

@NetanelBasal I forgot to apply the custom blurPredicate method, that has to include element.tagName === 'CUSTOM-DATE' || element.tagName === 'P-CALENDAR'. If I do it, then it starts to work.

Is it a correct way how to get the correct behavior? Or is there something more, that should be done?

PS: The Stackblitz https://stackblitz.com/edit/mlc-cva-error-tailor?file=src%2Fapp%2FappMain.component.ts was updated also by that part.

ErrorTailorModule.forRoot({
      errors: {
        useValue: {
          required: () => `Input is requied.`
        }
      },
      blurPredicate: (element: Element) => {
        return element.tagName === 'INPUT' || element.tagName === 'SELECT' || element.tagName === 'CUSTOM-DATE' || element.tagName === 'P-CALENDAR'
      }
    })

from error-tailor.

NetanelBasal avatar NetanelBasal commented on June 15, 2024

Yes, that's the right solution. I forgot about that :)

from error-tailor.

NetanelBasal avatar NetanelBasal commented on June 15, 2024

Thanks!

from error-tailor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.