With a built from git nghttp:

$ nghttp -u -f -n -a -v --color http://106.186.112.116/
lt-nghttp: nghttp.cc:582: int nghttp2::{anonymous}::HttpClient::on_upgrade_connect(): Assertion `sizeof(settings_payload) >= 8*niv' failed.
Aborted

But enabling flow control it works:

$ nghttp -u -n -a -v --color http://106.186.112.116/
[  0.276] HTTP Upgrade request
GET / HTTP/1.1
Host: 106.186.112.116
Connection: Upgrade, HTTP2-Settings
Upgrade: HTTP-draft-09/2.0
HTTP2-Settings: AAAABAAAAGQAAAAHAAD__w
Accept: */*
User-Agent: nghttp2/0.3.0-DEV


[  0.555] HTTP Upgrade response
HTTP/1.1 101 Switching Protocols
Connection: Upgrade
Upgrade: HTTP-draft-09/2.0


[  0.555] HTTP Upgrade success
...

I would like to be able to send more than 4096 bytes in a single frame. I have set the intial window side on both sides to the max value (I stole your frame logging code):

[1406906541.461] send SETTINGS frame <length=12, flags=0x00, stream_id=0>
(niv=2)
[SETTINGS_MAX_CONCURRENT_STREAMS(0x03):128]
[SETTINGS_INITIAL_WINDOW_SIZE(0x04):2147483647]
[New Thread 0x7ffff6dde700 (LWP 14749)]
[1406906541.465] recv SETTINGS frame <length=24, flags=0x00, stream_id=0>
(niv=4)
[SETTINGS_HEADER_TABLE_SIZE(0x01):4096]
[SETTINGS_ENABLE_PUSH(0x02):1]
[SETTINGS_MAX_CONCURRENT_STREAMS(0x03):2147483647]
[SETTINGS_INITIAL_WINDOW_SIZE(0x04):65535]

It seems like the nghttp2_session_next_data_read method used to acquire the number bytes to send will never return greater than NGHTTP2_DATA_PAYLOADLEN bytes due to the initialization code and then cascading this value through nghttp2_min calls. I am interpreting this correctly, and if not what am I missing?

hello,

I'm having this error when i tried to make the last release of http/2 :

In file included from shrpx_http2_upstream.cc:38:0:
shrpx_worker_config.h:44:1: erreur: ‘thread_local’ does not name a type
shrpx_http2_upstream.cc: In function ‘int shrpx::{anonymous}::on_request_headers(shrpx::Http2Upstream_, shrpx::Downstream_, nghttp2_session_, const nghttp2_frame_)’:
shrpx_http2_upstream.cc:289:13: erreur: ‘worker_config’ was not declared in this scope
shrpx_http2_upstream.cc: In member function ‘virtual int shrpx::Http2Upstream::on_downstream_header_complete(shrpx::Downstream_)’:
shrpx_http2_upstream.cc:1197:13: erreur: ‘worker_config’ was not declared in this scope
make[2]: *_* [shrpx_http2_upstream.o] Erreur 1

Anyone knows why?
Cheers

Is it possible to add a new callback API "nghttp2_on_begin_frame_callback" to "nghttp2_session_callbacks", which is called whenever a frame header is received?

This allows users to access the frame header as soon as it becomes available and be able to

1. learn the frame length and pre-allocate a data buffer in a single memory allocation to receive data chunks received in nghttp2_on_data_chunk_recv_callback.
2. learn the frame type and flags before receiving payload, which may be useful in HTTP/2 extension.

Basically, this API is an extension of "nghttp2_on_begin_headers_callback" to allow users to access frame headers for every frames instead of just header frames.

Thanks
Chen

nghttpx crash with the error below:

nghttpx: shrpx_http2_downstream_connection.cc:528: virtual int shrpx::Http2DownstreamConnection::resume_read(shrpx::IOCtrlReason, size_t): Assertion `downstream_->get_response_datalen() >= consumed' failed.

The documentation for nghttp2_pack_settings_payload currently says "The buf must have enough region to hold serialized data" without specifying how large that is. I think either the documentation should state what a "large enough" buffer means, or it should get an additional argument where we tell the function how large the buffer is - and then nghttp2 can return an error if too small. (I personally would prefer getting both.) Otherwise we are destined to get an overflow there sooner or later...

I have an nghttpd server running as follows:

nghttpd -v --push=/push.html=/style.css --color -d /data 443

push.html contains

<link rel="stylesheet" href="style.css" type="text/css">

If I use firefox to request /push.html, style.css is pushed and firefox correctly doesn't request it.

However if I use nghttp as a client with the following command line:

nghttp -v -a -n https://http2.myserver/push.html

it seems that the server push is ignored, and nghttp still sends a request for style.css (output on the client follows):

[  0.066] send HEADERS frame 
          ; END_STREAM | END_HEADERS
          ; Open new stream
          :authority: http2.myserver
          :method: GET
          :path: /push.html
          :scheme: https
          accept: */*
          accept-encoding: gzip, deflate
          user-agent: nghttp2/0.3.0-DEV
...
[  0.079] recv PUSH_PROMISE frame 
          ; END_PUSH_PROMISE
          (promised_stream_id=2)
          :method: GET
          :path: /style.css
          :scheme: https
          :authority: http2.myserver
[  0.079] recv HEADERS frame 
          ; END_HEADERS
          ; First response header
          :status: 200
          server: nghttpd nghttp2/0.3.0-DEV
          content-length: 53086
          cache-control: max-age=3600
          date: Sun, 26 Jan 2014 17:20:55 GMT
          last-modified: Thu, 05 Dec 2013 06:03:06 GMT
[  0.083] recv DATA frame 
...
[  0.085] send HEADERS frame 
          ; END_STREAM | END_HEADERS | PRIORITY
          (pri=1073741825)
          ; Open new stream
          :authority: http2.myserver
          :method: GET
          :path: /style.css
          :scheme: https
          accept: */*
          accept-encoding: gzip, deflate
          user-agent: nghttp2/0.3.0-DEV
[  0.088] recv DATA frame 
...

I'm not sure this is by design or not. I understand that nghttp is a simple client and probably is not expected to behave like a real browser, but I thought I'd report the issue anyway.

cd example && make

Gives a lot of errors. I was reading through the example to get a grip of the API when I found discrepancies, and then I tried building the example and... yeah, it fails completely.

The IETF has standardized on ALPN vs NPN for HTTP/2.0 advertisement. Consequently, this library should be updated per the spec to use ALPN instead of NPN; ALPN support is present within OpenSSL 1.1.x git master.

I offer this patch to add man pages for the nghttp, nxhttpx and nxhttpd utilities

https://gist.github.com/dajobe/9006201

This patch is derived from the command's help page outputs.

I am observing following compile errors while building nghttp2 v0.4.1 on RHEL6.5 host.

Tried setting configure with CXXFLAGS = -std=c++0x but didn't help.

CXX util.o
util.cc: In function ‘std::string nghttp2::util::http_date(time_t)’:
util.cc:147: error: ‘nullptr’ was not declared in this scope
util.cc: In function ‘void nghttp2::util::to_token68(std::string&)’:
util.cc:293: error: ‘begin’ is not a member of ‘std’
util.cc:293: error: unable to deduce ‘auto’ from ‘’
util.cc:293: error: ‘end’ is not a member of ‘std’
util.cc:302: error: ‘end’ is not a member of ‘std’
util.cc: In function ‘void nghttp2::util::to_base64(std::string&)’:
util.cc:311: error: ‘begin’ is not a member of ‘std’
util.cc:311: error: unable to deduce ‘auto’ from ‘’
util.cc:311: error: ‘end’ is not a member of ‘std’
util.cc: In function ‘void nghttp2::util::inp_strlower(std::string&)’:
util.cc:329: error: ‘begin’ is not a member of ‘std’
util.cc:329: error: unable to deduce ‘auto’ from ‘’
util.cc:329: error: ‘end’ is not a member of ‘std’
util.cc: In function ‘int nghttp2::util::::levenshtein(const char_, const char_, int, int, int, int)’:
util.cc:366: error: ‘begin’ is not a member of ‘std’
util.cc:366: error: ‘begin’ is not a member of ‘std’
util.cc:366: error: ‘end’ is not a member of ‘std’
util.cc: In function ‘void nghttp2::util::show_candidates(const char_, option_)’:
util.cc:381: error: ‘nullptr’ was not declared in this scope
util.cc:408: error: ‘begin’ is not a member of ‘std’
util.cc:408: error: ‘end’ is not a member of ‘std’
util.cc:415: error: expected initializer before ‘:’ token
util.cc:590: error: expected primary-expression at end of input
util.cc:590: error: expected ‘;’ at end of input
util.cc:590: error: expected primary-expression at end of input
util.cc:590: error: expected ‘)’ at end of input
util.cc:590: error: expected statement at end of input
util.cc:590: error: expected ‘}’ at end of input
util.cc: At global scope:
util.cc:590: error: expected ‘}’ at end of input
util.cc:590: error: expected ‘}’ at end of input

I would like to get your thoughts on the removal of per data frame compression support in draft 13. My use case ("internal" mutually authenticated TLS session) would greatly benefit from per frame compression. Do you have any recommendations on how to achieve the per frame compression with after its removal from the specification?

The compression + encryption vulnerabilities I have seen (CRIME, BREACH) seem to rely upon the attacker being able to supply data and get the data back, and in my use case the users are all "internal" and "trusted" via mutual TLS authentication. Am I missing something in terms of compression introducing a larger attack surface in this case?

As the subject says. Are there some examples or instructions?

Thanks!

Current git version has a bug

[INFO] [UPSTREAM:0x80c5820] HTTP request started
(shrpx_https_upstream.cc:75)
[INFO] [UPSTREAM:0x80c5820] Too large header block size=539782771
(shrpx_https_upstream.cc:106)
[INFO] [UPSTREAM:0x80c5820] HTTP parse failure: (HPE_CB_header_field) the on_header_field callback failed
(shrpx_https_upstream.cc:346)

I just test migrate from shrpx, and compiled latest nghttp2.
I use mode --http2-proxy as HTTPS proxy (Not SPDY request), but it doesn't work.
but shrpx --spdy-proxy mode work in the same test environment.
thanks.

Hi Tatsuhiro, I'm slowing starting to research your work here and figure out the API etc and I was wondering if there's a mailing list or something that's suitable if I have questions or feedback or whatever on the design etc ?

Hello,

I'm trying to build this architecture :
client <----> proxy <----> server.

I'm using google Chroome as a client , proxy ( nghttpx proxy) and server (nghttpd)
When i run the test, the proxy is showing this error :
[ERROR] Certificate verification failed: self signed certificate
(shrpx_ssl.cc:503)

I thought it was a chromium issue, so i imported the certificate to chromium certificate autorities but it didn't solve the issue.

then, I saw that to avoid this error i can become a Certification Authority and add cacert option to nghttp.conf.sample file, but it didn't work.

To become a CA i followed those instructions :
https://help.ubuntu.com/12.04/serverguide/certificates-and-security.html

Anyone can help ?
cheers

I'm testing the h2-12 code for hyper against the nghttp2 test server, and I'm hitting a GOAWAY frame that I'm not expecting.

When I open the connection, I begin with the preamble and a SETTINGS frame. If this SETTINGS frame has Enable Push present and set to 1, nghttp2 sends a GOAWAY frame with the error code PROTCOL_ERROR. If it has Enable Push present and set to 0, nghttp2 is fine with it.

The SETTINGS frames look like this:

With Enable Push:    000A0400 00000000 02000000 01050000 0001
Without Enable Push: 000A0400 00000000 02000000 00050000 0001

Which is exactly the same apart from the enabling of Server Push. Is this an expected nghttp2 behaviour, or do you think the problem is with my code?

In the meantime, I'm working around it by simply not sending the setting when I want to set it to 1.

Running nghttpd with the following command line:

nghttpd  -v --no-tls --color -d /webroot/ 8080

Trying to do an upgrade with the client:

# nghttp -u -n -v --color http://10.0.0.1:8080
[  0.000] HTTP Upgrade request
GET / HTTP/1.1
Host: 10.0.0.1:8080
Connection: Upgrade, HTTP2-Settings
Upgrade: HTTP-draft-09/2.0
HTTP2-Settings: AAAABAAAAGQAAAAHAAD__w
Accept: */*
User-Agent: nghttp2/0.3.0-DEV


Failed to parse HTTP Upgrade response header: (HPE_INVALID_CONSTANT) invalid constant string
Some requests were not processed. total=1, processed=0

Is this expected? Do I have to run the proxy in between to be able to upgrade?

I tried your library, and it works good when issuing requests in sequence. But when I tested it running 20 parallel downloads 200Kb file it was about 3-5 times slower than regular http1.1 proxy. Used default config, there was a chain - Firefox - nghttp2 client proxy - nghttp2 server proxy - nginx. Did you try such performance tests?

Appears to have been introduced with f8a446f. Reverting to a8e4da8 appears to resolve issue.

If you download the release tarball for 0.3.0 there is no doc/_themes/sphinx_rtd_theme directory. That means that building the html (make html) always fails.

Fix: add _theme dir and _themes/sphinx_rtd_theme to doc/Makefile.am SUBDIRS and add doc/_themes/Makefile.am with the contents of that dir, update configure.ac to add the new dirs. I can probably work on a patch.

Everything is in the title, Is it an option that should be allowed when configuring the server ?
here is a capture of the logs ( from the server side)

[id=1] [ 50.531] recv SETTINGS frame <length=15, flags=0x00, stream_id=0>
(niv=3)
[SETTINGS_MAX_CONCURRENT_STREAMS(3):100]
[SETTINGS_INITIAL_WINDOW_SIZE(4):65535]
[SETTINGS_COMPRESS_DATA(5):1]
[id=1] [ 50.531](stream_id=1, noind=0) :authority: localhost:8080
[id=1] [ 50.532](stream_id=1, noind=0) :method: GET
[id=1] [ 50.532](stream_id=1, noind=0) :path: /config.h
[id=1] [ 50.532](stream_id=1, noind=0) :scheme: http
[id=1] [ 50.532](stream_id=1, noind=0) accept: /
[id=1] [ 50.532](stream_id=1, noind=0) accept-encoding: gzip, deflate
[id=1] [ 50.532](stream_id=1, noind=0) user-agent: nghttp2/0.5.0-DEV
[id=1] [ 50.532] recv HEADERS frame <length=56, flags=0x05, stream_id=1>
; END_STREAM | END_HEADERS
(padlen=0)
; Open new stream
[id=1] [ 50.532] recv SETTINGS frame <length=0, flags=0x01, stream_id=0>
; ACK
(niv=0)
[id=1] [ 50.532] send SETTINGS frame <length=0, flags=0x01, stream_id=0>
; ACK
(niv=0)
[id=1] [ 50.532] send HEADERS frame <length=83, flags=0x04, stream_id=1>
; END_HEADERS
(padlen=0)
; First response header
:status: 200
cache-control: max-age=3600
content-length: 5894
date: Fri, 23 May 2014 16:07:43 GMT
last-modified: Fri, 23 May 2014 15:05:46 GMT
server: nghttpd nghttp2/0.5.0-DEV

The client advertises that it supports GZIP or deflate as a content encoding protocol, but the server doesn't accept none of them.

I'm using the nghttpd server and nghttp client

Sincerely

Hello,

I'm trying to run some tests using the nghttp server. The problem is that when i try to use chromium as a client i'm having this problem :

SSL/TLS handshake completed
The negotiated protocol: http/1.1
Client did not advertise HTTP/2.0 protocol. (nghttp2 expects h2-10)

Chromium implement only draft 06 of http2. But i need to use it as a client because it's the only browser supporting secure proxys.

The architecture that i'm seeking is :
( client(ideally chromium) <------> secure proxy <------> server )

Do you have any idea about how can i do this.
Sincerely,

From h2-14, HTTP/2 allows extensions to define arbitrary error code. To make it available to the application, all occurrence of nghttp2_error_code in struct or functions should be replaced with int (or int32_t).

My code has a fixed-size buffer to store received data (or headers) in, so when I call nghttp2_session_recv() I need to be able to fill up that buffer as much as possible but never more than so.

The documentation says nghttp2_session_recv will continue to call the recv_callback until it returns EWOULDBLOCK but it feels wrong to have to do that as it would be a lie.

Any suggestions?

API wise, I could perhaps imagine having the nghttp2_on_data_chunk_recv_callback() return information about how much data it could handle and nghttp2 would use that as a signal to stop the receiving for now.

nghttp2_submit_data() returns NGHTTP2_ERR_DATA_EXIST when the previously submitted data has not been fully processed yet. I am wondering what is the right way to call nghttp2_submit_data() again if an application has new data to submit after the previously submitted data has been processed. I have thought the following approaches:

1. call "nghttp2_submit_data()" in "nghttp2_data_source_read_callback()" when EOF is reached. It is too early since "nghttp2_stream_detach_data()" has not been called yet.
2. call "nghttp2_submit_data()" in "on_frame_send_callback()" if it is the last frame of the previous submission. Still too early for the same reason above.
3. call "nghttp2_submit_data()" after "nghttp2_session_mem_send()", then application needs to maintain a stream list to remember which stream is eligible to submit data again.

Please suggest the best practice to use "nghttp2_submit_data()".

Thanks
Chen

Hi,
not sure if it's curl or nghttp2 problem.
The HTTP/2.0 request sent by curl looks like:
HttpRequestPacket (
method=GET
url=/download/1
query=null
protocol=HTTP/1.1
content-length=-1
headers=[
user-agent=curl/7.38.0-DEV
host=localhost:7070
accept=/
connection=Upgrade, HTTP2-Settings
upgrade=h2c-13
http2-settings=AAMAAABkAAQAAP//]
)

as we see the HTTP2-Settings value is "AAMAAABkAAQAAP//", where according to the HTTP/2.0 draft 13:
"The content of the "HTTP2-Settings" header field is the payload of a
SETTINGS frame (Section 6.5), encoded as a base64url string (that is,
the URL- and filename-safe Base64 encoding described in Section 5 of
[RFC4648]"

in section 5 of [RFC4648] there is no slash symbol in the Base64Url table, this symbol only exists in Base64 table, but as I mentioned HTTP/2.0 has to use Base64Url.

Thank you!

Hi,

When I build libcurl I use pedantic and -Werror, and then gcc found this warning in nghttp2.h that caused my build to fail...

The fix is simply like this: https://github.com/bagder/nghttp2/commit/aacb38e4678591c91de1994fef0ed03ee2410065

Trying to build from master, getting:

In file included from app_helper.cc:46:0:
app_helper.h:92:1: error: ‘steady_clock’ in namespace ‘std::chrono’ does not name a type
app_helper.cc:441:1: error: ‘steady_clock’ in namespace ‘std::chrono’ does not name a type
app_helper.cc: In function ‘void nghttp2::reset_timer()’:
app_helper.cc:446:3: error: ‘base_tv’ was not declared in this scope
app_helper.cc:446:26: error: ‘std::chrono::steady_clock’ has not been declared
app_helper.cc: In function ‘std::chrono::milliseconds nghttp2::get_timer()’:
app_helper.cc:451:34: error: ‘std::chrono::steady_clock’ has not been declared
app_helper.cc:451:55: error: ‘base_tv’ was not declared in this scope
app_helper.cc: At global scope:
app_helper.cc:454:1: error: ‘steady_clock’ in namespace ‘std::chrono’ does not name a type
app_helper.cc: In function ‘std::chrono::milliseconds nghttp2::get_timer()’:
app_helper.cc:452:1: warning: control reaches end of non-void function [-Wreturn-type]
make[2]: *** [app_helper.o] Error 1

Hi

I think I would like some way to get some verbose debug logging or something from nghttp2 that can help me more than just a return code.

In my case I now provide a full struct of callbacks: https://github.com/bagder/curl/blob/master/lib/http2.c#L265

When I subsequently call nghttp2_session_recv() it does a lot of things and I get callbacks used and it looks pretty good but then in the end it returns -902. That's the value called NGHTTP2_ERR_CALLBACK_FAILURE, but I really have a hard time to figure out what callback that did wrong, and what wrong that could've been!

I figure I can step into nghttp2 with my debugger to figure it out now, but it would also be useful if there was some way to get perhaps a text saying more specifically what the problem is.

Suggestions?

Currently we expose nghttp2_session_callbacks struct to public.
But this is not good because each time we add new callbacks, we need so name bump, breaking binary compatibility.
So I decided to hide the details of the struct and provide functions to set each callback separately.
Work has been mostly done in my local branch so no PR is necessary for this item.

Could you pls forward the incoming ToS field unchanged in nghttpx?
Currently to ToS field is reset to 0x00

Draft 14 is out. The code baseline should be updated to this version of the specification. For additional reference, here is the github link.

HPACK-09 is also out on github.

Looks like after the upgrade to h2-14 the documentation link does not work. I had observed this issue during last upgrade (from h2-12 to h2-13 as well).

Site admin please restore it so documentation can be accessed.

Thanks
RP

--client-proxy

I see that nghttpx disables server push in the SETTINGS it sends to the backend.

[id=1] [ 29.629] recv SETTINGS frame 
          (niv=3)
          [SETTINGS_ENABLE_PUSH(2):0]
          [SETTINGS_MAX_CONCURRENT_STREAMS(4):100]
          [SETTINGS_INITIAL_WINDOW_SIZE(7):65535]

Is this by design?

I'm migrating from shrpx,

This is the command I'm translating from:

/shrpx --spdy-proxy --frontend=0.0.0.0,55554 --backend=0.0.0.0,55555 --spdy-max-concurrent-streams=1000000 -n 2 -L INFO --accesslog --no-via /workspace/certs/server.key /workspace/certs/server.crt

However, I can't seem to find the params for

• --spdy-max-concurrent-streams
• -n
• -L INFO
• --accesslog
• --no-via

for nghttp2, are these still there and undocumented, or?

It looks like the proxy -- nghttpx -- only binds to either the IPv4 address or the IPv6 address but not both -- like the server does.

This shows the 1st request over v4. Ignore the 502 bad gateway, the connection to the proxy is at least made:

 curl -v -k -4 https://cdntest.org:8443/
* Adding handle: conn: 0x7fc21100c400
* Adding handle: send: 0
* Adding handle: recv: 0
* Curl_addHandleToPipeline: length: 1
* - Conn 0 (0x7fc21100c400) send_pipe: 1, recv_pipe: 0
* About to connect() to cdntest.org port 8443 (#0)
*    Trying 93.93.131.187...
* Connected to cdntest.org (93.93.131.187) port 8443 (#0)
* TLS 1.2 connection using TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384
* Server certificate: Internet Widgits Pty Ltd
> GET / HTTP/1.1
> User-Agent: curl/7.30.0
> Host: cdntest.org:8443
> Accept: */*
>
< HTTP/1.1 502 Bad Gateway
* Server nghttpx nghttp2/0.5.0-DEV is not blacklisted
< Server: nghttpx nghttp2/0.5.0-DEV
< Content-Length: 154
< Content-Type: text/html; charset=UTF-8
<
* Connection #0 to host cdntest.org left intact

and then the same request but made over IPv6 confirms the port isn't open:

curl -v -k -6 https://cdntest.org:8443/
* Adding handle: conn: 0x7f9f4c80c400
* Adding handle: send: 0
* Adding handle: recv: 0
* Curl_addHandleToPipeline: length: 1
* - Conn 0 (0x7f9f4c80c400) send_pipe: 1, recv_pipe: 0
* About to connect() to cdntest.org port 8443 (#0)
*   Trying 2a00:1098::86:1000:30:0:1...
* Failed connect to cdntest.org:8443; Connection refused
* Closing connection 0
curl: (7) Failed connect to cdntest.org:8443; Connection refused

netstat -tuplanet confirms: https://gist.github.com/xxdesmus/cdc2b06f05c8437a4c90 the proxy isn't bound to v6, only v4.

In my conf file for the proxy I have:

frontend=0.0.0.0,8443
backend=0.0.0.0,8080

You'll notice that the server -- nghttpd -- is properly binding to both IPv4 and IPv6 addresses on the box, but it seems the proxy isn't.

ifconfig shows:

   eth0      Link encap:Ethernet  HWaddr 52:54:00:0c:61:f0
      inet addr:93.93.131.187  Bcast:93.93.131.255  Mask:255.255.255.0
      inet6 addr: 2a00:1098:0:86:1000:30:0:1/64 Scope:Global
      inet6 addr: fe80::5054:ff:fe0c:61f0/64 Scope:Link
      UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
      RX packets:7360093 errors:0 dropped:5 overruns:0 frame:0
      TX packets:126380 errors:0 dropped:0 overruns:0 carrier:0
      collisions:0 txqueuelen:1000
      RX bytes:617483311 (617.4 MB)  TX bytes:27966076 (27.9 MB)

Any ideas?

I'm adding support for hyper to optionally use nghttp2 to do HPACK compression using the Python bindings, but I've hit a compile error on Travis CI. The output is here, but I've reproduced the relevant bits below.

Any insight?

    Version:        0.5.0 shared 4:0:0
    Host type:      x86_64-unknown-linux-gnu
    Install prefix: /usr/local
    C compiler:     gcc-4.8
    CFLAGS:         -g -O2
    LDFLAGS:        
    LIBS:           
    CPPFLAGS:       
    C preprocessor: gcc-4.8 -E
    C++ compiler:   g++-4.8
    CXXFLAGS:       -g -O2 -std=c++11
    CXXCPP:         g++-4.8 -E
    Library types:  Shared=yes, Static=yes
    Python:         /home/travis/virtualenv/python2.7.6/bin/python
    PYTHON_VERSION: 2.7
    pyexecdir:      ${exec_prefix}/lib/python2.7/site-packages
    Python-dev:     yes
    PYTHON_CPPFLAGS:-I/opt/python/2.7.6/include/python2.7
    PYTHON_LDFLAGS: -L/opt/python/2.7.6/lib -lpython2.7
    Cython:         cython
    CUnit:          yes
    OpenSSL:        yes
    Libxml2:        yes
    Libevent(SSL):  yes
    Spdylay:        no
    Jansson:        no
    Jemalloc:       yes
    Applications:   yes
    HPACK tools:    no
    Examples:       yes
    Python bindings:yes
    Failmalloc:     no


  CXXLD  nghttpx
shrpx.o: In function `shrpx::(anonymous namespace)::reopen_log_signal_cb(int, short, void*)':
/home/travis/build/Lukasa/hyper/nghttp2-0.5.0/src/shrpx.cc:1451: undefined reference to `_ZTHN5shrpx13worker_configE'
libnghttpx.a(shrpx_http2_upstream.o): In function `shrpx::Http2Upstream::on_downstream_header_complete(shrpx::Downstream*)':
/home/travis/build/Lukasa/hyper/nghttp2-0.5.0/src/shrpx_http2_upstream.cc:1329: undefined reference to `_ZTHN5shrpx13worker_configE'
/home/travis/build/Lukasa/hyper/nghttp2-0.5.0/src/shrpx_http2_upstream.cc:1329: undefined reference to `_ZTHN5shrpx13worker_configE'
libnghttpx.a(shrpx_http2_upstream.o): In function `on_request_headers':
/home/travis/build/Lukasa/hyper/nghttp2-0.5.0/src/shrpx_http2_upstream.cc:1329: undefined reference to `_ZTHN5shrpx13worker_configE'
/home/travis/build/Lukasa/hyper/nghttp2-0.5.0/src/shrpx_http2_upstream.cc:1329: undefined reference to `_ZTHN5shrpx13worker_configE'
libnghttpx.a(shrpx_https_upstream.o):/home/travis/build/Lukasa/hyper/nghttp2-0.5.0/src/shrpx_https_upstream.cc:914: more undefined references to `_ZTHN5shrpx13worker_configE' follow
collect2: error: ld returned 1 exit status
make[2]: *** [nghttpx] Error 1
make[2]: Leaving directory `/home/travis/build/Lukasa/hyper/nghttp2-0.5.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/travis/build/Lukasa/hyper/nghttp2-0.5.0'
make: *** [all] Error 2

@tatsuhiro-t - No issue, I just wanted to say thanks for all your efforts! The API is well thought out and your examples are very helpful to demonstrate the use cases!

I am building an HTTP/2 server based upon your v0.4.1 and interacting with a netty (which has draft 12 support) based client. I am happy to report they are communicating and compatible for my use case. kudos!

Hi, I'd like to see the documentation for the callbacks mention where the |user_data| pointer is set. Like this perhaps:

https://github.com/bagder/nghttp2/commit/f430dadf5a2f4636cc832e86420fffe1e7d8d8c4

Hi, I'm trying to add server push support to nghttpx (via X-Associated-Content header), and need to access downstream headers to copy some of them to the push request. This is done obiviously after the original request has been sent (on receiving response headers), and Downstream::request_headers_ field is already empty. I wonder, what's the reason for doing that? I haven't found any implications about it in the code. Downstreams are not pooled, they are 1-to-1 to request.

Hello,

My question might sound ridiculous but how can I execute a php script on nghttpd server ? Is it even possible?

Sincerely

Could you please cut a new release now that support for h2-13 is in? I'd like to release an updated package for my Gentoo Linux overlay, which needs a new version number.

BTW, I love your work! Thanks

Hello,

Any chance you can host the latest docs somewhere online so that it gets easier to browse it from multiple locations?

Since the example isn't adapted yet, I think it would be a good idea to get some basic tutorial like documentation that explains the big picture of how this lib is supposed to be used.

I get this error message when building from git:

shrpx_ssl.cc: In function ‘SSL_CTX* shrpx::ssl::create_ssl_context(const char*, const char*)’:
shrpx_ssl.cc:162:60: error: ‘EC_KEY_new_by_curve_name’ was not declared in this scope
   auto ecdh = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
                                                            ^
shrpx_ssl.cc:169:19: error: ‘EC_KEY_free’ was not declared in this scope
   EC_KEY_free(ecdh);
                   ^

Hi,

When i try to build with MSVC (for Windows build for Wireshark project), i have the following message error
nghttp2/nghttp2_hd_huffman.c(196) : warning C4244: '=' : conversion from 'const int16_t' to 'uint8_t', possible loss of data

and state variable is int16 in struct nghttp2_huff_decode and uint8 in nghttp2_hd_huff_decode_context

What the better fix ? change type of variable ? or add a cast ?

Hi,

I find it really awkward to develop through pull-requests, so here's a link to a commit in my forked repo instead.

I would like to see a nghttp2_version() introduced that returns information about the run-time library in place, ie not assume that the build-time define is what is going to be used down the line when the lib is updated later on but the application is not.

Please consider it a first suggestion, I'm certainly willing to adjust if you have other ideas or opinions about what it should do or not do and how.

https://github.com/bagder/nghttp2/commit/3f5d82c88d1ff6dad30b941445e307ad33dd7585

Thanks!