nexdatas / sardana-nxs-filerecorder Goto Github PK

It would be good to add tests for ubuntu 22.04 and badges in README

It would be good to add sychronisation with the Spock snapshots

From time to time one gets

p02/door/haspp022ch.01 [7]: ascan exp_dmy01 0 1 2 0.1
NXS_FileRecorer: a profile for 'mg_tk' does not exist, creating a default profile.
Consider to run 'spock> nxselector' to select additional components.
NXS_FileRecorer: descriptive components will be reset
Operation will be saved in /gpfs/current/raw/scans/scan_[ScanId].fio (fio)
Operation will be saved in /gpfs/current/raw/scans/scan_05339.nxs (nxs)
Scan #5339 started at Wed Sep 22 09:38:44 2021. It will take at least 0:00:00.300089
 #Pt No   exp_dmy01  eh2b_t01  eh2b_vfc01  sis3302_1  sis3302_1_roi     dt  
An error occurred while running Macro 'ascan(exp_dmy01, 0.0, 1.0, 2, 0.1) -> 1d209f06-1b78-11ec-bd51-00224d9e7a39':
'NoneType' object is not iterable

p02/door/haspp022ch.01 [8]: www
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/sardana/macroserver/msmacromanager.py", line 1554, in runMacro
    for step in macro_obj.exec_():
  File "/usr/lib/python2.7/dist-packages/sardana/macroserver/macro.py", line 2328, in exec_
    for i in it:
  File "/usr/lib/python2.7/dist-packages/sardana/macroserver/macros/scan.py", line 292, in run
    for step in self._gScan.step_scan():
  File "/usr/lib/python2.7/dist-packages/sardana/macroserver/scan/gscan.py", line 947, in step_scan
    self.start()
  File "/usr/lib/python2.7/dist-packages/sardana/macroserver/scan/gscan.py", line 902, in start
    self.data.start()
  File "/usr/lib/python2.7/dist-packages/sardana/macroserver/scan/scandata.py", line 357, in start
    self.datahandler.startRecordList(self)
  File "/usr/lib/python2.7/dist-packages/sardana/macroserver/scan/recorder/datarecorder.py", line 56, in startRecordList
    recorder.startRecordList(recordlist)
  File "/usr/lib/python2.7/dist-packages/sardana/macroserver/scan/recorder/datarecorder.py", line 115, in startRecordList
    self._startRecordList(recordlist)
  File "/usr/lib/python2.7/dist-packages/sardananxsrecorder/nxsrecorder.py", line 871, in _startRecordList
    cnfxml = self.__createConfiguration(envrecord["data"])
  File "/usr/lib/python2.7/dist-packages/sardananxsrecorder/nxsrecorder.py", line 809, in __createConfiguration
    self.__aliases = [ch for ch in och if ch in allcp]
TypeError: 'NoneType' object is not iterable

In the v3.6.6 release

• suport for numpy.integer and numpy.float in numpyEncoder added (#15)

It looks l the new version of sardana scan_id is increased before starting recorder. Therefore, we need to update the code to make it working.

In the v3.10.0 release
add nexus_step_datasources and nexus_init_datasources variables added (#47)

It would be good to provide an environment variable e.g. SciCatDatasetListFileLocal to add hostname to the SciCat dataset list filename

We get report about error:

>      jddict = json.dumps(lddict, cls=NXS_FileRecorder.numpyEncoder)
>    File "/usr/lib/python3.7/json/__init__.py", line 238, in dumps
>      **kw).encode(obj)
>    File "/usr/lib/python3.7/json/encoder.py", line 199, in encode
>      chunks = self.iterencode(o, _one_shot=True)
>    File "/usr/lib/python3.7/json/encoder.py", line 257, in iterencode
>      return _iterencode(o, 0)
>    File "/usr/lib/python3/dist-packages/sardananxsrecorder/nxsrecorder.py", line 61, in default
>      return json.JSONEncoder.default(self, obj)
>    File "/usr/lib/python3.7/json/encoder.py", line 179, in default
>      raise TypeError(f'Object of type {o.__class__.__name__} '
> TypeError: Object of type int64 is not JSON serializable

It looks like something has changed in sardana.

It would be good to check if component sources parent obj is not datasource or dim or link

In the v3.10.1 release

• order of nexus_step_components according to moveables set (#50)

It would be good to rename the repository to sardana-nxs-filerecorder

In the v3.14.0 release

• checks if parent obj of datasource is a field added (#74)

It would be good to add first tests

In the v3.13.3 release

• serialno for sardana >= 3.4.0 fixed (#68)

It would be good to change PyTango to tango

It looks like there are to dashes in the scicat-dataset list filename when hostname is present

It would be good to add bookworm tests

We have received a request to support .nxs.tmp files which are not automatically remove from our gpfs

In the release v3.17.1

• typo in printing warnings fixed (#87)

In the v3.17.0 release

• support for user data units and other fields added (#85)

It would be useful to add nexus_step_datasources and nexus_init_datasources variables

I would be good to add debian11 tests.

In the v3.9.3 release

• fix setting nexus_components variable (#44)

In the v3.8.0 release

• SciCat dataset to the list file if NXSAppendSciCatDataset is set appended (#36)

In the v3.15.0 release

• the timers variable set with availableTimers (#77)

It would be good to add np.bool_ type to numpyEncoder

It would be good to set order of nexus_step_components according to moveables which could be used to set nexus data axes

In the v3.11.0 release

• the hostname via NXSAppendSciCatDataset to changes scicat-datasets list filename set (#54)

In the v3.7.2 release

• JSON numpyEncoder improved (#26)

In the 3.7.1 release

• fix related to non-defined ordered channels added (#21)

avoid caching tango.Except and tango.DevError

In the v3.12.0 release

• SciCatDatasetListFileLocal` flag which sets the hostname in scicat-datasets list filename added (#61)

It would be good to add possibility to set the sardana hostname via NXSAppendSciCatDataset which would change the default scicat-datasets list filename

It would be useful to add nexus_components and measurement_group variables

It would be good to add support for user data units and other attributes

tango.DevError and tango.Except are not exceptions so we cannot catch them on python3

It would good to improve user data via respecting its properties, e,g, dtype and shape

After nexdatas/nxsrecselector#58
scan locks if MG not applied by nxselector

It would be good to set timers variable with availableTimers

It would be good to add support for MetadataScript or FioAdditions i.e. which provide a python script generating user metadata.

In the v3.7.0 release

• mgchannels variable set

It would be convenient to migrate documentation from doxygen to sphinx.

To notify the scicat ingestor it would be good to add possibility to append SciCat scan name to the list file if NXSAppendSciCatDataset is set

It would be good to remove debug information with the data because all output streams are stored at /tmp/tango-/*

In the v3.7.3 release

• comment longer debug steams (#31)

In the v3.16.1 release

• support for MetadataScript improved (#82)

The nexus_components variable is set in wrong place

In the v3.13.2 release

• a bug for serialno for sardana >= 3.4.0 fixed (#68)

In the v3.9.1 release

• nexus_components and measurement_group variables added

It would be good to set mgchannels variable