newroco / moodle-gradingform_multigraders Goto Github PK

Typically repositories will use the standard convention to make it easy for devs/admins to indenify a plugin based on the repository name - this repository is called "moodle-multigraders" - but it should really be "moodle-gradingform_multigraders"

As requested by Gregor McNish and others on different channels.

Notice: Undefined property: stdClass::$secondary_graders_id_list in /moodle/grade/grading/form/multigraders/lib.php on line 151

possibly due to the test course I am using not having any teachers....

in lib.php you have a couple of uses of $USER->firstname . ' ' .$USER->lastname - typically it's better to use fullname($USER) as sites/languages display names differently.

Moodle uses a privacy API for GDPR compliance to allow plugins to specify how they deal with user data.

Sites that use continuous integration processes will not be able to use your plugin because Moodle runs unit tests which check to see if all extra plugins include the privacy class.

More information on the privacy class is here:
https://docs.moodle.org/dev/Privacy_API

please note this is not a blocker for approval in the plugins db at this stage.

Thank you for your work on this plugin. I have started testing this morning to see if it will allow us to have two teachers grade a submission and so far I have not been able to get a final grade with the following config:
Assignment 2 - Grading Method Ready for use
Multiple Markers for Assignment 2
Secondary graders defined: Teachy McTeacher, Niall Sheehan.
The student can also see all secondary feedback when the grade is final.
Method of auto calculating the next grade and outcomes: average over previous grades

Two teachers have submitted grades and comments however the assignment is still showing Not Graded. See link for screenshot.

Based on the instructions "When the defined number of graders is met, another grader may award the final one by looking at the grades and feedback from the previous graders."

I have had two graders grade the assignment and the 3rd looked at the results (screenshot is the 3rd viewer), yet the grade is still not final.

Please advise.

the db/messages.php file seems to be missing the standard template text at the top and spacing in the file doesn't meet our normal guidelines (travis-ci checks would also pick this up.)

Some of the tests run by the Moodle.org plugins db can be run via travis-ci on each commit in your github repo. Enabling Travis integration helps you to make sure future changes to your plugin will continue to follow the guidelines.

More information on this is here:
https://moodle.org/mod/forum/discuss.php?d=323384

but the short version:
grab this file:
https://github.com/moodlerooms/moodle-plugin-ci/blob/master/.travis.dist.yml
rename it as .travis.yml and put in the root of your github directory.
Go to:
https://travis-ci.org/profile/YOUR_GITHUB_USERNAME
Flick the switch for this repo.

then on every commit you make to github it will fire off a request to travis to run the tests in .travis.yml and will give you traffic lights beside each commit and generate a report.

something else you might want to change:
in .travis.yml the default file has this line:

env:
global:

MOODLE_BRANCH=MOODLE_35_STABLE
you might want to add other branches to that list - so you might want to change it something like:

env:
global:
MOODLE_BRANCH=MOODLE_35_STABLE
MOODLE_BRANCH=MOODLE_36_STABLE
MOODLE_BRANCH=MOODLE_37_STABLE

PARAM_CHAR, used in lib.php's get_external_definition_details(), is not a thing. I haven't checked the details, but perhaps PARAM_TEXT?

Adding this plugin seems to have broken the ability to add functions to web services.

This is because, in lib.php, the get_external_definition_details() function returns the wrong type (should be an array). I haven't yet worked out exactly what form the guts of the returned value should take, but in the meantime caveat emptor!

It appears you have been hand-editing your install.xml file and some of the spacing looks incorrect.

Please correct this by using the built in Moodle xmldb editing tool by loading the file, making a change to a comment inside one of your tables and then use the xmldb editor to save the file. (you may have to adjust permissions on the file to allow xmldb editor to save it.) - then when making future changes to the file, please continue to use the xmldb editor.

Some of the Moodle forks have extra unit tests that check that the install.xml matches what Moodle expects so this invalid file can cause failing unit tests.

when I first installed the plugin and created an assignment and selected to use the new grading method, it didn't take me to the grading setup page, so when I enter the assignment and choose to grade, I get an empty grey bar on the right - it might be nice for it to display a message like "multigrader grading has not been configured yet." rather than just an empty space.