newbare / abc4j Goto Github PK

What steps will reproduce the problem?
1. Use the following ABC input (from
http://www.thesession.org/tunes/display/8145)

X: 1
T: Key To The Cellar, The
M: 3/2
L: 1/8
R: three-two
K: Edor
G2E2 E2D2 E4 | G2E2 E2G2 FGA2 |
G2E2 E2D2 E4 | F2D2 D2 B2 A2GF :|
E2e2 e2d2 e4 | E2e2 e2f2 g2e2 |
E2e2 e2dc d3B | A2F2 D2B2 A2GF :|

2.
Use the following code (adapted from tutorial): 
    private static void test1() throws IOException {
        StringReader reader = new StringReader(TEST);
        TuneBook book = new TuneBook(reader);
        int tunesNb = book.size();
        System.out.println("Nb of tunes in input : " + tunesNb);
        // now retrieve the tune with reference number "10"
        Tune aTune = book.getTune(1);
        // display its title
        System.out.print("Title n°1 is " + aTune.getTitles()[0]);
        // and the name of its composer.
        System.out.println(" and has been composed by " + aTune.getComposer());

    }

What is the expected output? What do you see instead?

Expect to see the title displayed.  Instead, a NullPointerException is
thrown.  Removing the spaces after the colons in the header resolves this
problem, but requires manual intervention on each input (or a
pre-processing routing to automatically remove spaces)

What version of the product are you using? On what operating system?
Using abc4j_v0.5.jar on Windows XP SP2.  Running JRE 1.5_06

Please provide any additional information below.

Using abc4j v0.5's abc.midi.TunePlayer, the following two lines sound 
differently:
D4DDD2-|D2E2F4|
D4DDD2|-D2E2F4|

These lines are identical except for the location of the tie symbol "-".  
However, when playing them the tie symbol is ignored in the bottom line.  The 
tie should be recognized regardless of whether the tie symbol occurs before or 
after the bar line.
I'm not sure if this is an issue with the score display as well, as I only use 
the MIDI functions of the library.

X:1
T:abc notes
M:4/4
K:Cb
C,

java.lang.ArrayIndexOutOfBoundsException: -1
    at abc.notation.KeySignature.<init>(KeySignature.java:122)
    at abc.parser.AbcParserAbstract.parseKeySpec(AbcParserAbstract.java:747)
    at abc.parser.AbcParserAbstract.parseKey(AbcParserAbstract.java:729)
    at abc.parser.AbcParserAbstract.parseFieldKey(AbcParserAbstract.java:711)
    at abc.parser.AbcParserAbstract.parseAbcHeader(AbcParserAbstract.java:863)
    at abc.parser.AbcParserAbstract.parseAbcTune(AbcParserAbstract.java:252)
    at abc.parser.AbcParserAbstract.parseAbcFile(AbcParserAbstract.java:222)
    at abc.parser.AbcFileParser.parseFile(AbcFileParser.java:96)
    at abc.parser.TuneBook.buildTunesTreeMap(TuneBook.java:344)
    at abc.parser.TuneBook.<init>(TuneBook.java:46)
    at Main.main(Main.java:113)

Hello and congratulations for this great library.

I am writing a bagpipe-oriented program using abc4j to display scores.
I tried to use gracenotes and it didn't work: gracenotes are ignored.

There is the text of the example file that generated the screenshot attached:

X:1
T:The Rowan Tree first line simplified
C:Trad.
M:4/4
K:Hp
| {g}A3/2B1/2 | {g}c2-c1{G}c1 {g}c2 B2 |

X:1
T:
L:1/4
M:2/4
K:Bb
[a2B]

version working to 0.4

Firs of all, congrats for your work guys!

That is my problem width the "swing eighth note":

For that input:

X:0
M:4/4
K:C
(3CzC

I expected the output shown in the pictures "spected1.jpg" or "spected2.jpg"  

 _3_
| y |
o   o

but I've got the output "abc4jout.jpg" instead (no triplet)

|\   |\
o  y o

Is this an issue or I'm using it wrong?

Thanks a lot

Second, while trying to convert ABC contents to MIDI, I discovered that a
MIDI synthesizer must be open, like this:

Synthesizer synth = MidiSystem.getSynthesizer();
synth.open();

... conversion ...

synth.close();

I left out the exception handling. It would be nice to know this little
fact, because without doing so one will surely wonder why he is getting all
those NullPointerException-s trying to convert ABC to MIDI.

from the abc4j google groups :
http://groups.google.com/group/abc4j/browse_thread/thread/b167ed7b9d25496e

> 2) Ties for notes below "A", should be underneath (like it is now),
> but all notes above "A", eg "B" and onwards should have their ties
> above

a time signature is compound if the top number can be divided by 3.
not implemented like that in 0.2

Sorry for bad english..
I try to play/stop tune from textarea by pressing button and all seems to be 
good, but TunePlayer it don't release memory after stop-method.
I'm new in JAVA, so don't know: Is it my mistake or not?

    class PlayTune implements ActionListener {
        public void actionPerformed(ActionEvent e) {
            if (player.isPlaying()) {
                player.stop();
            }
            else {
                if (!tuneEditArea.getText().isEmpty()) {
                    tuneAsString = tuneEditArea.getText();
                } else {
                    tuneAsString = "";
                }
                Tune tune = new TuneParser().parse(tuneAsString);
                player.start();
                player.play(tune);
            }
        }
    }

What version of the product are you using? On what operating system?
Windows 8 Pro x64, NetBeans IDE 7.2.1, JDK 1.7u15 x64

X:2 
T:Eileen O'Riordan's
S:IrTrad; Chris and Caitlin, 6/97
R:Slide
M:12/8
L:1/8
K:EDor
E2 A ABA E2 A ABA|E2 A ABA G2 A F2 A|
E2 A ABA E2 A ABd|1 efe dcB A3 AGF:|2 efe dcB A3 ABd||
e3 efe d3 dcd|e2 A ABA G2 A F2 A|
E2 A ABA E2 A ABd|1 efe dcB A3 ABd :|2 efe dcB A3 AGF||

What steps will reproduce the problem?

1. I create a Tune:

X:1
T:Escala Corcheas en Do Mayor
M:4/4
L:1/8
C:Tever
K:Cmaj
CDEFGABc | cBAGFEDC |]


2. I try to play the tune

File abcFile = new File (part);
//creates a tunebook from the previous file
TuneBook book = new TuneBook(abcFile);
//retrieves the first tune notation of the ceili.abc file
Tune myTune = book.getTune(1);
//creates a midi player to play tunes
TunePlayer player = new TunePlayer();
//starts the player and play the tune
player.start();
player.play(myTune);

3. The program show me this error:

java.lang.ArrayIndexOutOfBoundsException: 0
    at 
abc.midi.MidiConverterAbstract.toMidiSequence(MidiConverterAbstract.java:54
)
    at abc.midi.TunePlayer.play(TunePlayer.java:144)
    at Principal.pruebaReproducirPartitura(Principal.java:35)
    at Principal.main(Principal.java:43)
java.lang.IllegalStateException: sequence not set
    at com.sun.media.sound.RealTimeSequencer.start(Unknown Source)
    at abc.midi.TunePlayer.play(TunePlayer.java:147)
    at Principal.pruebaReproducirPartitura(Principal.java:35)
    at Principal.main(Principal.java:43)



What version of the product are you using? On what operating system?

I use Eclipse with abc4j_v0.5.jar
I'm now using Windows 7


Thank you very much to listen my issue ;)

Tever

this tune makes the parser crash

X:2
T:Bovaglie's Plaid
C:J Scott Skinner
M:C
L:1/8
Q:100
K:A
A|"D"(FE/C/) "A"E>F A>B c>A|"D"dc/B/ "A"{B}(ec) "Bm"{c}BA (F/A)
z/|"A"(FE/C/) (E>F) A>B"D"c>d|
"A"ec/A/ "E7"G/d/z/G/  "A"{G}A2 A::e|"A"ag/a/  (3 ecA "D"(3 fdA "A"(3
ecA|(3(CEA) (3(cea) "E"{cd}c>B(B>e)|
"A"ag/a/ (3ecA "D"(3(FAd) "A"(3 (EAc)|"Bm"(3(DFB) "E7"(E/d/)z/G/ "A"{G}(A2
A) e|"A"{g}ab/a/g/f/ (3ecA "D"(3fdA "A"(3ecA|
"A"ae/d/ cB/A/ "E"B>BB A/G/|"D"(FG/A/) "A"(EG/A/) "Bm"(DG/A/) "A"{CD}(3
CB,A,|(3(ECA,) "E7"G,/D/z/G,/ "A"(A,2 A,)|]

java.lang.NullPointerException
    at abc.notation.Tuplet.<init>(Tuplet.java:26)
    at
abc.parser.AbcParserAbstract.parseTupletElement(AbcParserAbstract.java:1109)
    at abc.parser.AbcParserAbstract.parseElement(AbcParserAbstract.java:1045)
    at abc.parser.AbcParserAbstract.parseAbcLine(AbcParserAbstract.java:947)
    at abc.parser.AbcParserAbstract.parseAbcMusic(AbcParserAbstract.java:932)
    at abc.parser.AbcParserAbstract.parseAbcTune(AbcParserAbstract.java:254)
    at abc.parser.TuneParser.parse(TuneParser.java:48)
    at abc.parser.TuneParser.parse(TuneParser.java:25)

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?
Being able to tie and slur exisiting chords 

What version of the product are you using? On what operating system?
Windows Vista, abc4j

Please provide any additional information below.

Ive attempted to add slurs and ties to chords which i have already created 
or chords which i have created but not added to the staff.
So far my code is as of follows for a tie but producing no results, as for 
a slur ive tried the methods it has but to no avail! 

        Vector v = new Vector();
        v.addElement(new Note(Note.f));
        v.addElement(new Note(Note.D));
        v.addElement(new Note(Note.C, AccidentalType.SHARP, ONE));

        MultiNote ms = new MultiNote(v);
        MultiNote mn = new MultiNote(v);

        TieDefinition tie = new TieDefinition();
        tie.setStart(ms.getLowestNote());
        tie.setEnd(mn.getLowestNote());
        ms.getLowestNote().setTieDefinition(tie);
        mn.getLowestNote().setTieDefinition(tie);

        music.addElement(ms);
        music.addElement(mn);

Cheers

What steps will reproduce the problem?
Run the following code:

public static void main (String[] arg) {
        Tune tune = new Tune();
        Tune.Music music = tune.getMusic();
        Note note = new Note(Note.C);
        note.setStaccato(true);
        music.addElement(note);
        JScoreComponent scoreUI =new JScoreComponent();
        scoreUI.setTune(tune);
        JFrame j = new JFrame();
        j.add(scoreUI);
        j.pack();
        j.setVisible(true);
}

What is the expected output? What do you see instead?
Expected output: a note with staccato
Actual output: see attachment.

What version of the product are you using? On what operating system?
I'm using the latest version of the abc4j jar; 0.5.
OpenSUSE linux 11.4, java environment:

java version "1.6.0_20"
OpenJDK Runtime Environment (IcedTea6 1.9.7) (suse-1.2.1-x86_64)
OpenJDK 64-Bit Server VM (build 19.0-b09, mixed mode)

the following exception occurs : 
java.lang.ClassCastException: abc.notation.Note cannot be cast to
abc.parser.PositionableNote
    at
abc.midi.MidiConverterAbstract.toMidiSequence(MidiConverterAbstract.java:80)
    at abc.midi.TunePlayer.play(TunePlayer.java:129)
    at abc2xmlTest.test3(abc2xmlTest.java:82)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav
a:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at junit.framework.TestCase.runTest(TestCase.java:164)
    at junit.framework.TestCase.runBare(TestCase.java:130)
    at junit.framework.TestResult$1.protect(TestResult.java:106)
    at junit.framework.TestResult.runProtected(TestResult.java:124)
    at junit.framework.TestResult.run(TestResult.java:109)
    at junit.framework.TestCase.run(TestCase.java:120)
    at junit.framework.TestSuite.runTest(TestSuite.java:230)
    at junit.framework.TestSuite.run(TestSuite.java:225)
    at
org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestR
eference.java:130)
    at
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner
.java:460)
    at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner
.java:673)
    at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java
:386)
    at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.jav
a:196)

in this abc

<snip>
% Generated more or less automatically by swtoabc by Erich Rickheit KSC
X:1
T:Little Sir Hugh
M:6/8
L:1/8
K:G
B/2-c/2|d-e dB-A B| GGD D2B/2-c/2|d-e dB-A G| A3- A2 A|d-e dB-A B|\
 G2 D D2 D|G-A Bc-B A| G3- G2||
</snip>

there are a few simple slurs between adjacent notes (notes 1&2, 3&4, etc)
parser gets very confused and puts slurs all over the place

attached is what the output should be (expected.tiff) and what it is 
(actual.tiff)

version 0.5

thanks.

this is not supported yet but seems to be already recognized by the parser 
itlsef.

I am currently doing a project to develop a piano pedagogy/assessment software, 
in which I need to use a dynamic mechanism to view piano score. There Re some 
classes in abc4j for adding parts (e.g. Createpart, addpart), I would like to 
know is this feature available in abc4j? Thanks

Lee

When this tune is played : 
X:45
T:midi playback error
L:1/8
M:6/8
R:jig
K:C
|: GBg dBG     | Fcf cAF    | Gdg dBA    | cec B_BA
| GBg dBG      | Fcf cAF    | gfe fed    |1 e/e/dc B_BA :|2 e/e/dc Bc_d

After the |1n the B flat (_B) is still applied when coming back to the
begining of the tune...

[deleted issue]

What steps will reproduce the problem?
Run the first example at 
http://code.google.com/p/abc4j/wiki/JScore_Using_music_model

What is the expected output? What do you see instead?
Expected output is as rendered at that page. Actual input can be seen in the 
attachment.

What version of the product are you using? On what operating system?
I'm using the latest version of the abc4j jar; 0.5.
OpenSUSE linux 11.4, java environment:

java version "1.6.0_20"
OpenJDK Runtime Environment (IcedTea6 1.9.7) (suse-1.2.1-x86_64)
OpenJDK 64-Bit Server VM (build 19.0-b09, mixed mode)

I am using lyrics with the following characters {'á', 'â', 'ã', 'é', 
'ê', 'í', 'ó', 'ô', 'õ', 'ú'}; and after one of the appears in a file, I
get nothing else after in the score.
I really need to use those characters, because they mean that there is a
stressed syllable.

when invoking 

Tune[] tunes = book.getTunesHeaders();

I get a

java.lang.ClassCastException: abc.parser.TuneBook$TranscribedTune
   at abc.parser.TuneBook.getTunesHeaders(TuneBook.java:206)
   at Main.main(Main.java:27)

I can't access the Google Group for ABC4J (has a takedown notice).

I was trying to find out how to walk the notes like it would when being played 
(I don't want to figure out bar ending/repeats, etc.). Is the right way to play 
the piece with a listener? If so, how to avoid actually playing the Tune?

The duration computation for tuplets is wrong and results in the same values 
for triplets and septuplets for example.

duration = (short)(duration * tuplet.getDefaultNoteLength() /  
tuplet.getTotalRelativeLength()); 

should actually be the correct implementation.

X:20
T:Ainhoarrak
M:C|
O:Basque
Z:Richard Robinson
<URL:http://www.leeds.ac.uk/music/Info/RRTuneBk/contact.html>
%%TUNEURL: http://www.leeds.ac.uk/music/Info/RRTuneBk/gettune/00000b9a.html
%%ID:00000b9a
K:G
d>efg fedc| BcdB G2G>G| G2z2 GBAB| cBAG FGAB| \
A2A>A A2dc| B2BA GABc| d2ec d2z2 | dcde f2d2| \
cBAB c3A| F2z2 GABc| d2G2 FGAB|1 G3A G2z2 :|2 G3A G2de|:\
g2g2 g2g2| c3d c2d>e| =f2f2 fgfe| d3c B2z2| =f2f>d e2e>c| d2d>c B2z2 |\
d2c>B A2F2| G2AB c2c2| BcdB A3B| A2z2 c2de| fedc d2G2| FGAB G3A\
M:2/4
|1 G4 e3f :|2 G4D4 |:\
M:C|
G2A2 BAGF| GFGA G2z2| dcde f2d2| cBAB c2F2| G2A2 B2AG| FGAB G3A\
M:2/4
|1 G4D4 :|2 G4 B3c|: \
M:C|
d2d2 dfed| cBcd c2A>B| c2c2 cdcB| A2F2 GABc| d2G2 F2G2| d3e d2dc| B2BA GABc|\
d2e>c d2B>c| d2d2 d>fed| cBcd c2A>B| c2c2 cdcB| A2F2 GABc|\
d2G2 FGAB|1 G3A G2B>c :|2 G3A G2z2  |:\
d2e>f g2d2| BcAB G2A2| | B2G2 c2B2| ABGA B2G2| \
d2e>f g2d2| BcAB G2A2| B2G2 BdcB| AGAB G2z2 |: \
B2B>d c2c>A| B2B2 A2z2| GABc d2g2|1 BcAB G2G>A :|2 fgaf g2z2|:\
g2g>d e2e>c| d2d>B c2c>A| BdBG AcAF|1 G2G>G G2z2 :|2 G2G>G G2G>A||\
B2B>d c2c>A| B2B2 BAGF| G2G>A B2B>d| c2c>A B2B2| BAGF G2z2|\
BdBG AcAF| G2G>G G2G>A| B2B>d c2c>A| B2B2 BAGF| \
G2G>A B2B>d| c2c>A B2B2| BAGF G2g2| defd efga| fgaf g2z2|:\
G2d>d d2e2| =f2e>d c2z2| dcBA G2AB|1 cdcB A2z2 :|2 c2A2 A2z2|:\
B2B>B c2d2| A2z2 G2G>G| ABcA| B2G2| B2B>B c2d2| A2z2 G2A2| BdcB AGAB|\
M:2/4
G2z2 ::\
M:C|
GBAB G2d2| edcB B2A2| GBAB G2d2| edcB A2z2 ::\
GABc d2d2| d=fed c2z2| GABc d2d2| cdcB A2z2| GABA G2d2| edcB B2A2\
|1 GABc d2A2| FGAB A2z2 :|2 GABc f2g2| f2a2g2z2|]
% the lower notes in the last 1st-time bar are pretty much a guess -
% very indistinct photocopy. Sorry.

java.lang.NullPointerException
    at abc.parser.AbcParserAbstract.parseNote(AbcParserAbstract.java:1340)
    at abc.parser.AbcParserAbstract.parseNoteStem(AbcParserAbstract.java:1261)
    at abc.parser.AbcParserAbstract.parseNoteElement(AbcParserAbstract.java:1158)
    at abc.parser.AbcParserAbstract.parseElement(AbcParserAbstract.java:1037)
    at abc.parser.AbcParserAbstract.parseAbcLine(AbcParserAbstract.java:947)
    at abc.parser.AbcParserAbstract.parseAbcMusic(AbcParserAbstract.java:932)
    at abc.parser.AbcParserAbstract.parseAbcTune(AbcParserAbstract.java:254)
    at abc.parser.TuneParser.parse(TuneParser.java:48)
    at abc.parser.TuneParser.parse(TuneParser.java:25)