neuhausneuhaus / flamewarchest Goto Github PK

Nice work.

You've got a binding.pry still in your routes at '/test'

There's some inconsistencies in your coding style between parens around routes and no parents. Also be careful with spaces around your operators.

If you're directing in your route then it means you're not rendering any ERB files, therefore you don't need to create instance variables. Only use instance variables if you want to render them to a view.

Nice job putting together an ORM. When you have boolean attributes, rather than creating direct readers on them, a more Ruby-esque approach is to make predicate methods like admin?

In your HTML make sure you're using consistent double quotes and no spaces around operators in data attributes.

Does your JavaScript work?

This code doesn't look like it would run

 var outputString = (</script>

CSS looks nice. However make sure you're being more consistent with spaces before curly braces and new lines after a closing brace.

👍