netsensei / europeana Goto Github PK

This project hasn't been touched in a long, long time. The goal here is to start with some minor housekeeping tasks in order to bring this project into the future and go from there:

• Update dependencies in composer.json
• Make sure the code works with the latest maintained versions of PHP 7.x
• Make sure everything is PSR compliant
• Make sure everything still works with the current version of the Europeana API's

During composer install phpunit throws a warning:

Package phpunit/phpunit-mock-objects is abandoned, you should avoid using it. No replacement was suggested.

The objects mocking the API model in the tests will likely need to be ported to modern mocking practices.

One thing I noticed in the documentation is it says

$payload = new SearchPayload();
$payload->addQuery($query);

But it should be $payload->setQuery($query);.

As phpleague/skeleton has evolved over the past years, the structure of the package will need to be reviewed and updated if necessary to match with modern/current practices.

Would you be able to update the composer requirements to be less rigid?

"guzzlehttp/guzzle": "6.1.0",
"doctrine/collections": "1.3"

As I am using Laravel, Guzzle and Doctrine are already included and will not install lower versions fixed. Could they be changed to something like:

"guzzlehttp/guzzle": "^6.1.0",
"doctrine/collections": "^1.3"

Thanks

In the past few years, PHP has moved on as a language:

• PHP 5.x support has been stopped.
• PHP 7.3 is the current stable version
• PHP 7.4 has been released recently.

The code needs to be reviewed and updated in order to support modern PHP.