Use composer-patches-plugin for Magento (1) about composer-patches-plugin HOT 6 CLOSED

Hi Otto,

thanks for your appreciation. It seems like your patches are missing prefixes on the paths: (Like a/ and b/ in this patch for what I mean).

Currently the plugin is missing a strip option on the patch configuration (next to title and url) to tell the plugin how much levels to strip from the paths in the patch. You could implement this option if you like - otherwise you currently have to create the patches with prefixes.

Best regards,
Christian

from composer-patches-plugin.

Hi Christian,

Thank you for the quick reply. It was not clear for me that I needed to add to prefixes. I noticed it, but didn't understand that I needed to add the prefixes.

I have updated both patch files, but I'm getting a different error now. When it tries to run the first patch. All other patches are skipped (same file and second file)

[Netresearch\Composer\Patches\PatchCommandException]                         
  Patch SUPEE-1533_EE_1.12_v1.patch would fail!                                
  Error executing command "patch -f -p1 --no-backup-if-mismatch -r - --dry-ru  
  n":                                                                          
  patching file app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php         
  Hunk #1 FAILED at 444.                                                       
  1 out of 1 hunk FAILED -- saving rejects to file -                           
  patching file app/code/core/Mage/Adminhtml/controllers/DashboardController.  
  php                                                                          
  Hunk #1 FAILED at 92.                                                        
  1 out of 1 hunk FAILED -- saving rejects to file - 

I extracted the patch files form the Magento .sh files. When I run the .sh files everything is patched automatically.

Original patch .sh file: http://shopbase.nl/patches/PATCH_SUPEE-1533_EE_1.12.x_v1-2015-02-10-08-19-16.sh
Extracted .patch file: http://shopbase.nl/patches/SUPEE-1533_EE_1.12_v1.patch

Best regards,
Otto Smittenaar

from composer-patches-plugin.

Hi Christian,

Am I doing something wrong (stupid ;-))?

Hope you can point me again in the right direction.

Best regards,
Otto Smittenaar

from composer-patches-plugin.

Hi Otto,

there is something wrong with the patch - may it be, that it was already applied?

The plugin is actually really executing the stated command in the directory of your package. For debugging, you could take this command and exute it manually there (eg. patch -f -p1 --no-backup-if-mismatch -r - --dry-run SUPEE-1533_EE_1.12_v1.patch).

from composer-patches-plugin.

Hi Christian,

Thanks, i will try that.

Best regards,
Otto

from composer-patches-plugin.

Hi Christian,

You where right. On of the patches is already applied to the Composer repository of Magento 1.9.1.0.

It works perfectly now. Thanks a lot.

Best regards,
Otto Smittenaar

from composer-patches-plugin.