Does not support Windows about composer-patches-plugin HOT 3 CLOSED

Thank you @c33s , #44 is merged.

from composer-patches-plugin.

Please check yourself for a possible solution from our network, and create MR if one of those fixes your problem:

• zVPS@559e55e
• MartijnHarte@fe3e404
• dimdimych@22daabc
• zeyus@332e5a9
• zeyus@11fbacb

from composer-patches-plugin.

@CybotTM

my proposed fix/MR for the problem is #44. my MR adds the which/where bridge and also tries to simply run patch without running where before.

to collect the information to have everything on one place:

MR #17 introduced this bug as it requires to have the which binary which results in a path which is checkable with is_executable. on windows which returns a "linux" path like /usr/bin/patch if which was installed with git for windows. is_executable returns false for this path.
so enhancing the error message introduced a break on all systems which have no which command. as far as i see most of the solutions @CybotTM mentioned will fix the problem. from my point of view the which / where bridge solutions are the better than the others.

• so the easiest fix is the simply remove the change introduced with #17
• to keep the change but also allow to run it on windows the which/where bridge is a simple solution.
• to allow to config the path to patch in composer.json could also be a way. as there is no "sub-namespace" in patches, the fastest way would be to add the config to the info for each patch. which is quite uncool from DX but it would work.
• good addition would be to simply try to run patch and only if that fails try to locate it with which/where.

from composer-patches-plugin.