Giter Club home page Giter Club logo

netgenremotemediabundle's People

Contributors

amalija-ramljak avatar bhelland avatar emodric avatar iherak avatar jfauske avatar joezg avatar liln00b avatar marioblazek avatar markozabcic avatar pspanja avatar randycupic avatar vesnacustic avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

netgenremotemediabundle's Issues

Image scalling in backend uses HTTP instead of HTTPS

In 1.1 release (and probably in master as well), on Scale functionality, HTTP is being used to load images instead of HTTPS. The problem probably lays in the fact that url attribute is being used from Cloudinary resource, instead of secure_url.

Feedback when uploading

When uploading a file in the administration, there is no feedback to the editor that anything is happening.
There should probably be some loader at least.

Notify user if file is bigger than upload_max_filesize

If a user try to upload an image bigger than upload_max_filesize we get an error from Cloudinary, the xhr request returns a 500 and the UI become unresponsive to the user:
[2019-10-09 10:31:57] request.CRITICAL: Uncaught PHP Exception Cloudinary\Error: "Nothing to load" at vendor/cloudinary/cloudinary_php/src/Uploader.php line 514 {"exception":"[object] (Cloudinary\\Error(code: 400): Nothing to load at vendor/cloudinary/cloudinary_php/src/Uploader.php:514)"} []

Let the user know that the file they are trying to upoad is too big and can not be processed.

Version 1.0.13-aplha

"Alternate text" field does not show persisted value

If the 'Alternative text' field of a ngremotemedia attribute is inserted by an editor, such value correctly gets persisted to db, but when the content object gets re-edited, such value is always empty.

Steps to reproduce:
1)Create a content object which contains a ngremotemedia attribute
2)Insert an image and populate the 'Alternative text' field
3)Publish the content object
4)Verify that the content object's ngremotemedia attribute contains the inserted 'Alternative text' field value
5)Re-edit the content object
6)Observe that the 'Alternative text' field is empty

Missing check for non-existing resourceId

When fetching a remote resource by it's resourceId, a situation with non-existing resourceId is not being handled. In CloudinaryApiGateway service, method get() always returns first element of the response array. When non-existing resourceId is provided, response array will be empty which will cause a undefined offset exception. If the response is empty, it should throw an exception or something.

Content issue with eZ Platform 2.5.

On curent master we get
[ Oct 28 2019 12:32:33 ] Unexpected error, the message was : Argument 1 passed to Netgen\Bundle\RemoteMediaBundle\Templating\Twig\Extension\NetgenRemoteMediaExtension::getRemoteImageVariation() must be an instance of eZ\Publish\Core\Repository\Values\Content\Content, instance of eZ\Publish\Core\Repository\Values\Content\ContentProxy given, called in /var/www/ezpublish/cache/site/dev/twig/50/50a6355a88ca3f1d5597fb0096961a07c39f3542182d5cc1a4ee428306d2f61a.php on line 176 in /var/www/vendor/netgen/remote-media-bundle/bundle/Templating/Twig/Extension/NetgenRemoteMediaExtension.php on line 108

Confirm button when cropping

When cropping image in the administration, it is unclear at which moment the crop selection is saved.
UX needs to be improved.

Not able to add video to body

When I try to add a video (from cloudinary) via the 'Cloud'-icon in a body-field i get the following js-error in console:

d5ca133a88122bf372f785b9ae64a32f_1538045999.js:18156 Uncaught TypeError: Cannot read property 'split' of null
at child.thumb (d5ca133a88122bf372f785b9ae64a32f_1538045999.js:18156)
at child.render (d5ca133a88122bf372f785b9ae64a32f_1538045999.js:18484)
at child.render_scaler_view_in_modal (d5ca133a88122bf372f785b9ae64a32f_1538045999.js:18911)
at child. (d5ca133a88122bf372f785b9ae64a32f_1538045999.js:18905)
at c (d5ca133a88122bf372f785b9ae64a32f_1538045999.js:2)
at Object.fireWith [as resolveWith] (d5ca133a88122bf372f785b9ae64a32f_1538045999.js:2)
at k (d5ca133a88122bf372f785b9ae64a32f_1538045999.js:4)
at XMLHttpRequest.r (d5ca133a88122bf372f785b9ae64a32f_1538045999.js:4)

v1.1.13 and v1.1.17

Support for Ibexa 3+

Due to end of life of php7.4 I attempted to upgrade eZ Platform 2.5 project to Ibexa 3.3, so we can operate on php8.

What I found:

  1. remote-media-bundle:3.0.x-dev installs ok and follows Symfony5 BC changes but lacks any support for eZ FieldTypes resulting in
"Could not find 'eZ\Publish\SPI\Persistence\Content\FieldValue\Converter\*' with identifier 'ngremotemedia'"
  1. I can install remote-media-bundle:2.0.x-dev but DependencyInjection/Configuration breaks due to changes in TreeBuilder and /Core/FieldType/RemoteMedia/* need adaptation to meet updates FieldType interfaces.
    I managed to overcome those issues by exluding vendor classes from autoload and replacing with my overrides but then I got
Argument 3 passed to Netgen\Layouts\RemoteMedia\ContentBrowser\Backend\RemoteMediaBackend::__construct() must be an instance of Symfony\Component\Translation\TranslatorInterface, instance of Symfony\Component\Translation\DataCollectorTranslator given

which might require ticket in layouts remote media repository.

I assume completing FieldType bundle for v3 where lot of rework is happening might be a big project, but maybe you can consider introduction of some indirect version between 2.0 and 3.0 that will address minor BC changes to help running Ibexa 3 installations while waiting for major work on 3.0 to get finished.

Keep extensions on non-image files.

I've noticed that when uploading non-image files, like zip or pdf, NetgenRemoteMedia is stripping the extension from the name. Those kind of files doesnt go through transformations, and are served by "raw" url from cloudinary, which are downloaded directly to the user computer. If no extension, they are downloaded as generic file, wihtout specific type.

Upload form on cloudinary (https://cloudinary.com/console/media_library) strips the extensions for images, but keeps them for files. NetgenRemoteMedia should do the same when $publicID is generated

protected function prepareUploadOptions($fileName, $options = array())

Cache tag contains reserved characters {}()/\@

There seems to be an issue with remote media in folders.

STEPS:
1)Create a new Object of Content Class using Netgen's Remote Media Data Type

2)Click on button 'Manage Media'

3)Select an image which is positioned in a folder.
For example Cloudinary by default provides the 'sample folder'. Select image:
'samples/landscapes/landscape-panorama'

4)Notice that the following API is called:
Method: POST
URL: http://localhost:42080/ngadminui/ngremotemedia/change/60/226/3
PARAMS: resource_id: 'samples/landscapes/landscape-panorama'

5)Notice that the above API returns status code 500 with error message:

Symfony\Component\Cache\Exception\ InvalidArgumentException
'Cache tag "samples/landscapes/landscape-panorama" contains reserved characters {}()/\@'

How can I resolve this issue?

PS if I select image under Home, image selection is working correctly.

Search by tags not working in folders

When you search an image by tag from root folder, the image will be found (if exists). But when you choose the folder, where this image is located, and then search again by tag, there will be no results.

Select which root folder to use

When using cloudinary provider, it would make sense to have an option when uploading image and/or browsing to be able to select which folder should be used.

RemoteMediaSettings is not defined in ezxmltext wysiwyg

I'm using the Legacy Bridge with Netgen Admin Ui. I have an 'ezxmltext' attribute, but when I click on the blue cloud icon to attempt to open the NgRemoteMedia modal,I get the following javascript error:

ReferenceError: RemoteMediaSettings is not defined

Is this a bug or have I forgotten to configure something?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.