netflix / bpftop Goto Github PK

bpftop provides a dynamic real-time view of running eBPF programs. It displays the average runtime, events per second, and estimated total CPU % for each program.

License: Apache License 2.0

Rust 7.81% Dockerfile 0.01% Makefile 0.01% C 92.14% Shell 0.04%

bpftop's People

Contributors

Stargazers

Watchers

Forkers

rustbunker sjanulonoks leismile 0x00evil wnz27 shabbirhasan1 jpmondet jamestiotio videl jithinraj simonsan arnarpall mtb0x1 xorilog gmh5225 matthieu-m jieshiyeskey wojtekdmyszewicz doytsujin pshiko c-p-i-o vibrantman53 lambdafunc pourmoeziashkan d0s0med3v haze birdyn-jackfasc hargunsingh12 tardigrade34 miss-mickeymouse pink-black-bear facubingpodhani jonatadev kkpan11 hhy5277 donkiejay zhanglei dmefs vanishpool will7455 dockercore pretech78 3exellium authentingbesiemis starlec83 adanceteen burrofilldrkuro tonyonst-t coolig8 sleeventi-d daddyunikii 78dekkolo 79maintema oiparkel ccwutw jvorel arpan3323 hefeweizen morimeina rajasahil itsdarshankumar zf1575192187 zhangying098 sthagen tyrone-wu zhaopufeng vgopinathan simhaonline suixingbugai aiwhj gomesrocha coredumped7893 arasakainc adubovikov superskyyy carlosgarciapro redcod liyan-ah shangzuoyan ankitjagtap01 pinkforest orhun drusong dnwe loshz lll-lll-lll-lll

bpftop's Issues

Can we add an arm build in release page?

Panic when arrow up/down with no eBPF programs loaded

Grabbed the latest release per Installation instructions. Launched it when I didn't have any of my eBPF programs loaded and hit down arrow and it panicked:

thread 'main' panicked at src/app.rs:155:34:
                                            index out of bounds: the len is 0 but the index is 0
                                                                                                note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Search filter for BPF programs in tabular view

The app should incorporate functionality that enables users to filter BPF programs in the tabular view based on a search string. This filter should apply to the 'name' and 'type' of the BPF programs.

Some components in graph view do not use foreground color

The "Program Information" panel in the graph view does not use the terminal's foreground color. Also, the left axis of the graphs. Besides that, they appear to be fine with bright background.

The image below should indicate the problematic components.

Publish Debian package

Publish bpftop as a Debian package. This is an open item for anyone in the community with experience packaging Rust applications as Debian packges.

Publish RPM package to Fedora

I've added RPM packaging for bpftop and I'm currently going through the process to get it published in Fedora: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2281565

The crates that bpftop depends on must also be published as Fedora packages, and I'm currently working on the missing 2. The current blocker is finding a Fedora package sponsor.

Add Arm64 as target build platform

It would be really nice if bpftop were to build native Arm64 binaries in addition to x86. All of the eBPF tooling being measured and instrumented is available on Arm64, and as a Rust program, there should be no porting issues.

Aggregate statistics for all programs

It may be helpful to see the aggregate view of all performance statistics. It would let you answer questions like "How much CPU overhead are all eBPF programs adding to this host?".

Publish on crates.io

Please publish this program on crates.io
It would make installing and keeping the program up-to-date much easier for single-machine-deployments.

libc version incompatibility

Hi, seems like a very useful tool, excited to try it out. Unfortunately I am getting the same libc error both when directly running latest executable or compiling from the source with cross.

With latest executable
curl -fLJ https://github.com/Netflix/bpftop/releases/latest/download/bpftop -o bpftop && chmod +x bpftop

sudo ./bpftop
./bpftop: /lib64/libc.so.6: version `GLIBC_2.29' not found (required by ./bpftop)
./bpftop: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by ./bpftop)
./bpftop: /lib64/libc.so.6: version `GLIBC_2.33' not found (required by ./bpftop)
./bpftop: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by ./bpftop)
./bpftop: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./bpftop)

With source build, I've downloaded cross tool with
wget https://github.com/cross-rs/cross/releases/download/v0.2.5/cross-x86_64-unknown-linux-gnu.tar.gz

$ ./cross build --release
./cross: /lib64/libc.so.6: version `GLIBC_2.29' not found (required by ./cross)
./cross: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by ./cross)
./cross: /lib64/libc.so.6: version `GLIBC_2.27' not found (required by ./cross)
./cross: /lib64/libc.so.6: version `GLIBC_2.33' not found (required by ./cross)
./cross: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by ./cross)
./cross: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./cross)

My kernel version is above 5.8

$ uname -r
5.10.192-183.736.amzn2.x86_64

Os release

cat /etc/os-release
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"

Not familiar with the rust ecosystem, I'd appreciate any help. Thanks.

How to understand the cpu_time_percent(or 'Total CPU %') for multi-core CPUs?

Sortable columns

bpftop should let you sort the entries by column, in ascending or descending order. This would require us to track the selected program by its ID rather than its index in the items vec.

Occasional freeze under load

Occasionally, bpftop freezes up when the system is under load. It can only be terminated by killing it.
Tested was an xdp program loaded to two 10G interfaces, with traffic of about 5 Gbit/s. Final load displayed by bpftop was 42%.

core.bpftop-freeze.gz

From the core file pkill -QUIT bpftop :

#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x0000559a818929b4 in std::sys::unix::futex::futex_wait ()
    at library/std/src/sys/unix/futex.rs:62
#2  std::sys::unix::locks::futex_mutex::Mutex::lock_contended ()
    at library/std/src/sys/unix/locks/futex_mutex.rs:56
#3  0x0000559a818a5cf2 in bpftop::app::App::selected_program ()
#4  0x0000559a81899036 in bpftop::render_graphs ()
#5  0x0000559a81896321 in bpftop::ui ()
#6  0x0000559a8189ec35 in ratatui::terminal::terminal::Terminal<B>::draw ()
#7  0x0000559a81895f76 in bpftop::main ()
#8  0x0000559a818a4133 in std::sys_common::backtrace::__rust_begin_short_backtrace ()
#9  0x0000559a818a186d in _ZN3std2rt10lang_start28_$u7b$$u7b$closure$u7d$$u7d$17h1d1f4f019d401e61E.llvm.4513734777494074926 ()
#10 0x0000559a818f3cf1 in core::ops::function::impls::{impl#2}::call_once<(), (dyn core::ops::function::Fn<(), Output=i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe)> () at library/core/src/ops/function.rs:284
#11 std::panicking::try::do_call<&(dyn core::ops::function::Fn<(), Output=i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe), i32> ()
    at library/std/src/panicking.rs:552
#12 std::panicking::try<i32, &(dyn core::ops::function::Fn<(), Output=i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe)> ()
    at library/std/src/panicking.rs:516
#13 std::panic::catch_unwind<&(dyn core::ops::function::Fn<(), Output=i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe), i32> ()
    at library/std/src/panic.rs:142
#14 std::rt::lang_start_internal::{closure#2} () at library/std/src/rt.rs:148
#15 std::panicking::try::do_call<std::rt::lang_start_internal::{closure_env#2}, isize> () at library/std/src/panicking.rs:552
#16 std::panicking::try<isize, std::rt::lang_start_internal::{closure_env#2}>
    () at library/std/src/panicking.rs:516
#17 std::panic::catch_unwind<std::rt::lang_start_internal::{closure_env#2}, isize> () at library/std/src/panic.rs:142
#18 std::rt::lang_start_internal () at library/std/src/rt.rs:148
#19 0x0000559a8189b315 in main ()

XDP programs are accounted to xdp-dispatcher

Thanks for bpftop! I gave it a try and saw that XDP programs - which are managed by something called xdp-dispatcher - are not accounted indiviually, but rather to the xdp-dispatcher.
Is there a way to distinguish BPF statistics between individual XDP programs, or is this something that would have to be fixed in XDP?

Should leave alt screen in panic hook

bpftop/src/main.rs

Line 155 in e34c088

if let Err(err) = disable_raw_mode() {

Above this somewhere you should execute LeaveAlternateScreen to restore the buffer. Alternatively, define a struct that implements Drop to do that for you so you can bind it to a variable right after EnterAlternateScreen (or have it do both).

It’s a poor UX when TUIs don’t restore the user’s screen buffer, restore colors, etc.