netflix / batch_request_api Goto Github PK

Hi,

I would like to know is this Middleware production ready ? Since there is not much happening here in terms of development.

I would like to use it on Rails 6.

Thanks.

Known issue. Fix coming up soon.

Hi,

How can I get the batch values when I am in the controller ?

I am using batch_sequential, I can see the payload is correct using request.body.read.

After inspecting the source code of the gem, I have no clue how to obtain the correct payload.

I am using the ember addon

initializer:
Rails.application.config do |config|
config.batch_sequential_paths = ['batch_sequential'] # ['/api/v1/batch_sequential']
config.batch_parallel_paths = nil # ['/api/v1/batch_parallel']
end

controller:
class BatchSequentialController < ApplicationController
def create
puts JSON.parse(request.body.read.to_json)
byebug
end

Something like:

"requests": [
    {
      "method": "POST",
      "url": "/api/v1/movies",
      "body": { },
      "headers": { }
    }
  ]
}

Hi all,
I was wondering if you could use concurrent-ruby to improve concurrency of the batch import.
It is also possible to expose a config variable to control maximum concurrency for the batch importing.

Previously we used arsduo's batch_api gem to implement similar functionality but it wasn't maintained for a long while and never supports parallel requests.

One main different between that and batch_request_api is a slightly different payload format:

Request

{
  ops: [
    {method: "get",    url: "/patrons"},
    {method: "post",   url: "/orders/new",  params: {dish_id: 123}},
    {method: "get",    url: "/oh/no/error", headers: {break: "fast"}},
    {method: "delete", url: "/patrons/456"}
  ],
  sequential: true
}

v.s.

{
  "requests": [
    {
      "method": "POST",
      "url": "/api/v1/movies",
      "body": { }, { }
    }
  ]
}

Response

{
  results: [
    {status: 200, body: [{id: 1, name: "Jim-Bob"}, ...], headers: {}},
    {status: 201, body: {id: 4, dish_name: "Spicy Crab Legs"}, headers: {}},
    {status: 500, body: {error: {oh: "noes!"}}, headers: {Problem: "woops"}},
    {status: 200, body: null, headers: {}}}
  ]
}

v.s.

[
  {"status"=>200, "headers"=>{}, "response"=>{}},
  {"status"=>200, "headers"=>{}, "response"=>{}}
]

I believe there're some other users of batch_api would want to migrate to batch_request_api as well.

I propose two ways, and please let me know how you think:

1. Add options to configure main keys for requests & responses (e.g. requests / results)
2. Add an optional rack middleware to do the keys rewrite