Giter Club home page Giter Club logo

Comments (7)

cskiwi avatar cskiwi commented on April 27, 2024 1

Got the same issue, had to downgrade from 12.0.10 to 12.0.9. I can test if any beta versions become available

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on April 27, 2024

Please provide a minimum reproduction repository (Git repository/StackBlitz/CodeSandbox project).

from graphql.

jkossis avatar jkossis commented on April 27, 2024

After poking around, it looks like this recent change broke the validation. The following will help, utilizing the new PartialTypeOptions interface, but I need to dive into this more to understand why that change caused the previously working validation to fail.

Before:

@InputType()
export class UpdateDeviceSettingsInput extends PartialType(DeviceSettings, InputType) {}

After:

@InputType()
export class UpdateDeviceSettingsInput extends PartialType(DeviceSettings, { decorator: InputType, omitDefaultValues: true }) {}

from graphql.

jkossis avatar jkossis commented on April 27, 2024

@kamilmysliwiec @cskiwi tagging you all just for reference.

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on April 27, 2024

@jkossis would you like to create a PR to fix this issue? My hunch is that the current behavior of isPartialTypeOptions might be broken but I'd have to double-check to confirm

from graphql.

Maetes avatar Maetes commented on April 27, 2024

Thank you @jkossis. Was traveling abroad. Sorry for the late response. So a minimum reporduction is not necessary anymore?

from graphql.

cskiwi avatar cskiwi commented on April 27, 2024

Version 12.0.11 resolves this issue for me. thanks for the fix!

from graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.