definitions with option skipResolverArgs: true makes resolvers optional in d.ts about graphql HOT 5 OPEN

Are resolves required when skipResolverArgs is set to false?

from graphql.

skipResolverArgs: false

export interface IMutation {
    signIn(login: string, password: string): User | Promise<User>;
    signUp(): User | Promise<User>;
}

So yes they are required

from graphql.

Would you like to create a PR for this issue?

from graphql.

Would you like to create a PR for this issue?

"I will have the opportunity to delve into this only next weekend; unfortunately, I haven't had the chance to be a contributor to NestJS before."

from graphql.

@kamilmysliwiec I found the issue, can some just create PR according to the rules?

File: packegs/graphql/graphql-ast.explorer.ts
Method: toPropertyDeclarationStructure
Line: 317

Current code

return {
      name: propertyName,
      type: this.addSymbolIfRoot(type),
      hasQuestionToken:
        !required || (item as FieldDefinitionNode).arguments?.length > 0,
    };

I think that the correct way is not to look on arguments array at all

return {
      name: propertyName,
      type: this.addSymbolIfRoot(type),
      hasQuestionToken: !required,
};

from graphql.