neskol / mailib Goto Github PK

View Code? Open in Web Editor NEW

60.0 60.0 7.0 1.89 MB

A library for intepreting maimai charts

License: GNU General Public License v2.0

C# 100.00%

mailib's People

Contributors

Stargazers

Watchers

Forkers

jun024545 holmes301 kuaile10080 jouie01

mailib's Issues

Note timing rework

Note timing/chart definition need improvements to make format transferring easier.

Utage notation simai

Utage notation seemingly not recognised - this includes:

$ turns tap into star (example: 1$,2$,3$)
? creates slide without tap star (Example: 1?-5[2:1],)

Better error reporting

Current error catching system does not report exact detail of where it could be. A better error report system should be introduced.

Chart format interchange version error

When changing chart format, chart version is not properly set.

Issue with connecting V slides from simai to Ma2 1.04

I am getting this error when trying to parse this slide from simai to Ma2_104 using CompileSimai: 1V75V71[4:2]*V35V31[4:2]

Start Key:6
Expected inflection point: SLL for 4 and SLR for 0
Actual: 6
Program cannot proceed because of following error returned:
MaiLib.ParsingException
Simai Parser encountered an error while parsing after bar 21 tick 0 when parsing token V75V71[4:2] in each group "{4}, 1_, V75V71[4:2], V35V31[4:2]":
THE INFLECTION POINT GIVEN IS NOT MATCHING!
Original Stack:
   at MaiLib.SimaiParser.SlideOfToken(String token, Int32 bar, Int32 tick, Note slideStart, Double bpm) in C:\Users\Neskol\source\repos\Neskol\MaichartConverter\MaiLib\Parser\Simaiparser.cs:line 437
   at MaiLib.SimaiParser.SlideGroupOfToken(List`1 extractedTokens, Int32 bar, Int32 tick, Note startNote, Double bpm) in C:\Users\Neskol\source\repos\Neskol\MaichartConverter\MaiLib\Parser\Simaiparser.cs:line 278
   at MaiLib.SimaiParser.NoteOfToken(String token, Int32 bar, Int32 tick, Double bpm) in C:\Users\Neskol\source\repos\Neskol\MaichartConverter\MaiLib\Parser\Simaiparser.cs:line 126
   at MaiLib.SimaiParser.ChartOfToken(String[] tokens) in C:\Users\Neskol\source\repos\Neskol\MaichartConverter\MaiLib\Parser\Simaiparser.cs:line 52

   at MaiLib.SimaiParser.ChartOfToken(String[] tokens) in C:\Users\Neskol\source\repos\Neskol\MaichartConverter\MaiLib\Parser\Simaiparser.cs:line 95
   at MaichartConverter.CompileSimai.Run(String[] remainingArguments) in C:\Users\Neskol\source\repos\Neskol\MaichartConverter\Commands\CompileSimai.cs:line 76

Remove excessive fields

Remove excessive private fields to make this less Java-like

Has NO midi parsing!

Note Flags fix

Current MaiLib is partially rely on Enums to manage FESTiVAL features while the legacy features uses string as flags. Need to unify these standards

Issue with zero length hold notes converting simai to ma2 1.04

In simai, placing a hold note without specifying the hold length (i.e. 1h,2h,3h,) will create a zero length hold note

However this is not currently recognised and incorrectly converts to a regular tap note.

Issue with break slides converting simai to ma2 1.04

Chart file: https://drive.google.com/drive/folders/1milyC1Xpf1QEPGvl1W8j7UI-63wL6_Mh?usp=sharing

Error:

Executing CompileSimai (Compile assigned simai chart to assigned format):
    Destination : out
    Difficulty : 5
    FileLocation : C:/Users/mbmas/Desktop/customs/Catch The Glory - D-D-Dice vs. siromaru\maidata.txt
    Rotate : null
    ShiftTick : null
    TargetFormat : Ma2_104

Program cannot proceed because of following error returned:
MaiLib.ParsingException
Simai Parser encountered an error while parsing after bar 84 tick 0 when parsing token <4-7-1-4[4:10]b in each group "5_, <4-7-1-4[4:10]b, 4_, -1-7-4>5[4:10]":
The input string '10b' was not in a correct format.
Original Stack:
   at System.Number.ThrowFormatException[TChar](ReadOnlySpan`1 value)
   at System.Int32.Parse(String s)
   at MaiLib.SimaiParser.ExtractConnectingSlides(String token) in C:\Users\mbmas\Desktop\maichartconverter\MaiLib\Parser\Simaiparser.cs:line 834
   at MaiLib.SimaiParser.NoteOfToken(String token, Int32 bar, Int32 tick, Double bpm) in C:\Users\mbmas\Desktop\maichartconverter\MaiLib\Parser\Simaiparser.cs:line 124
   at MaiLib.SimaiParser.ChartOfToken(String[] tokens) in C:\Users\mbmas\Desktop\maichartconverter\MaiLib\Parser\Simaiparser.cs:line 52

   at MaiLib.SimaiParser.ChartOfToken(String[] tokens) in C:\Users\mbmas\Desktop\maichartconverter\MaiLib\Parser\Simaiparser.cs:line 95
   at MaichartConverter.CompileSimai.Run(String[] remainingArguments) in C:\Users\mbmas\Desktop\maichartconverter\Commands\CompileSimai.cs:line 84

New Ma2 Compatibility

Need to support Ma2 version 1.04 for reading/composing

Score calculation fix

The current version of MaiLib is not capable of calculating scores correct. Need to fix in future

Have issue to read command "^" and "C", and if the note have space it will error.

for "^" issue:

def of "^" command:

">", "<", "^" ... Arc shape
Connects the start to the end along the circled judgment line.
If the direction of travel is to the right, use ">". If left, use "<".
If the distance is shorter than half the circle, "^" can be used and thinking of the direction is thus not needed.

for "C" issue:

it will crash when I write C note in shimai file.
e.g.:
8x/C

for space issue:

if my chart have space in command.
e.g.:
{8}, , 8^6v4b[8:3], ,,, ,,

These issue is from Simaiparser.cs
My coding is not very good. I only can give u some code suggestion, can not fork and pull. Sorry about that.

Revision of Simai Parser

Due to the difficulty of fixing Simai parser issue, it might be much easier if the whole parser was sent for refactoring.