nereid42 / s.a.v.e Goto Github PK

Not a big one, but AVC constantly reports an error at startup.

I found that the clone function is not working in certain circumstances. One which I was able to isolate:

Start game after fresh install, create game, do single save, then clone. clone directory is created, but nothing done. I saw that the file GameData/S.A.V.E.dat was not created at this time

I'd like to be able to submit a PR of some changes, but can't because this code is not up-to-date with what is in the latest release which is 1.10.2.3192, while what's on Github is 1.9.1-3172

I suggest adding an option to backup all saves when the player quits the game.

Hi Nereid,

Hope this finds you well.

I've been working on a bunch of enhancements to the mod as well as converting it from using threads to using coroutines (you can see my bug report on the forum and on github (I think)), the conversion due to the mod crashing my game(s) repeatedly back in May.

@Lisias feels that threads are still the way to go, I disagree with him, but it's a friendly disagreement. He is going to (according to his last post) make some changes to fix the bug and submit a PR.

These are a full list of the changes I did:

• Replaced all threading code with CoRoutines
• Removed asynchronous setting
• Added SaveOnLaunch, with template string
• Rewrite config saves to standard ConfigNode format
• Added SaveConfirmationSound option
• Added QuickSave ability, with template string
• Added expiration limits to quicksaves
• Added tabs to configuration page to select between Backup Options, Quicksave Options and Sound Options
• Adjusted height of the Status and Clone pages to no more than 1/2 of the window height
• I had assumed that you were not around since you haven't been on the forums for about 6 months.

If you are indeed leaving, I'd be happy to adopt the mod, otherwise if you are going to make a release with @Lisias's changes, I'll step back. I'm a bit torn between forking the mod with all my changes or not.

I'll wait to hear from you as to your intentions. I try to be a cooperative modder, so if you continue, then I'll just pull my stuff out into a stand-alone mod.

Let me know, thanks

Linuxgurugamer