nekmo / ansible-keepass Goto Github PK

First, thank you very much for this nice plugin.

I was about to replace your implementation of the password cache with lru_cache of functools for readability.

However, I recognized that get_password gets called for every task in a Play.

Some good old printf debugging (print(self.identity, host_name) to get_password) gave me:

TASK [Gathering Facts] *************************************************

<ansible.plugins.vars.ansible_keepass.KeepassXC object at 0x7f8d3f0ff150> myhost

ok: [myhost]

TASK [foo] *************************************************************

<ansible.plugins.vars.ansible_keepass.KeepassXC object at 0x7f8d3f0ff150> myhost

ok: [myhost]

TASK [bar] *************************************************************

<ansible.plugins.vars.ansible_keepass.KeepassXC object at 0x7f8d3f0ff150> myhost

ok: [myhost]

TASK [baz] *************************************************************

<ansible.plugins.vars.ansible_keepass.KeepassXC object at 0x7f8d3f0ff150> myhost

ok: [myhost]

So I was asking myself – what is the password cache actually good for? When can it actually be reused?

Cheers :)

When I tried to make the plugin work I never found an entry, so I debugged the code and saw that under KeepassXC you are not looking for ssh://[host] but for ssh:[host]. This might be a typo but changing the following worked for me

def get_password(self, host_name):
        try:
            logins = self.connection.get_logins(
                self.identity,
                url='ssh://{}'.format(host_name)

On a side note, entering the URL values with just ssh:[host] is marked red in KeepassXC, indicating that the URL is not correct

Is there anything (apart from checking become) why monkey patching TaskExecutor is a superior solution to just writing a VarsModule?

IMHO the present approach torpedoes the idea of "vars plugins" (and the Law of Demeter).

In order to gain readability and comprehensibility (which is surely is subjective) for investigating #4, a refactored version of your wonderful plugin resulted. In this refactored version, you can find an example implementation as a "vars plugin".

The refactored version also contains the changes I pull-requested (plus: it moves all functions out the scope of the module, fixes to be more compliant with PEP 8, etc.).