neeckeloo / monolog-module Goto Github PK

Is a PHP8 compatible version likely soon?

Deprecated: ServiceLocatorAwareInterface is deprecated and will be removed in version 3.0, along with the ServiceLocatorAwareInitializer. Please update your MonologModule\Formatter\FormatterPluginManager plugin manager factory to inject the parent service locator via the constructor.

Working on a fix.

Hi,

I am working in a project and I am trying to use this library. I want to use mongoDB handler and for this I should create a MongoDB client.

By default I can't use it with your library, is it possible to modify it? Where should I do this, in the LoggerFactory (namespace: MonologModule\Factory\LoggerFactory)? Should I create a pull request after?

Thanks,
Julio

On line 121 of LoggerFactory: return call_user_func_array(array($reflection, 'newInstance'), array_values($options));

Results in an error Uncaught Error: Unknown named parameter $path in /var/www/html/vendor/neeckeloo/monolog-module/src/Factory/LoggerFactory.php on line 121.

This is because in PHP8 call_user_func_array passes the $options array as named parameters if it has named keys.
Using array_values() to return a numerically keyed array would fix the issue as the options would then be passed positionaly just as they are in PHP7 and this would maintain both PHP7 and PHP8 compatibility.

return call_user_func_array(array($reflection, 'newInstance'), array_values($options));