nedap / components.pedestal Goto Github PK

Add test helpers for

• generating an url
• retrieving service-fn

as seen in forester. see this discussion: https://github.com/nedap/pep-forester/pull/92/files/97c4ad089c43b6e5940b7e099f6a0773f8e232c4#diff-8513bcbbd30ba289dcf81038f2ff27e7

Brief

introduced different behaviour for new

Expected behavior

(satisfies? com.stuartsierra.component/Lifecycle 
            (nedap.components.pedestal.server.component/new))
=> true

Actual behavior

(satisfies? com.stuartsierra.component/Lifecycle 
            (nedap.components.pedestal.server.component/new))
Execution error (NullPointerException) at nedap.components.pedestal.server.component/new (component.clj:50).
null

Reproduction steps

1. open repl
2. paste snippet

(require '[nedap.components.pedestal.server.component])
(nedap.components.pedestal.server.component/new)

Suspected cause

554208b
[& {:as opts}] binds nil to opts if no params are provided.

Notice that :or only binds a value to the variable name (hence the need for :keys). it does not assoc the key/value in the map itself.

Environment info

happened while upgrading components.pedestal in nedap/pep-forester.

Problem statement

As made evident by #5 (should-start-or-stop? is cumbersome / hard to spec), c.p's notion of an :env tends to be complex.

Apps almost never will map 1:1 with c.p's 3 envs (:dev, :test, :production). there's also :staging, :integration-tests, etc

Proposal

Research if Pedestal's concept of an :env can be ditched; a better approach could be to fully embrace the concept of :defaults-kind (already introduced).

Alternatives and comparison

TBA as the proposal is researched.

Moved from: https://github.com/nedap/modular-playground/issues/10

In Mask, we want to be able to set a webserver port, depending on the environment.

For now, since I'm only having to deal with one environment, I can set it statically, like this:

::service/component (-> (service.component/new {::service/pedestal-options {:env environment                              
                                                                            :io.pedestal.http/port 4000}

But eventually we'll need to be able to support multiple, e.g. staging 4000, production 4100, etc. From what we do at Link, I prefer them myself to be (just) part of the config, in the same sense as hostname is configured (https://github.com/nedap/modular-playground/blob/master/resources/config.edn#L2), but right now there is no support in c-p to deal with this case.

Problem statement

The option ::pedestal.http/join? tells the web server to block (true) or not (false) after starting.

If the webserver blocks, any system using the server component do not finish the start up, which may mess with any shutdown handler that would use the started system.

Even if we can change this option to false in production for all the applications we have, it is quite difficult to detect the shutdown problem if everything seems to work properly after starting the web server.

Proposal

Set default to false the option ::pedestal.http/join? in the service component.

I just added .circleci + ncrw: 3f6bf9f

Now we'd need to create the project in Circle + release a new artifact for delivering #8 .

Feel free to do the releases yourself, aided by ncrw.