neauoire / enfer Goto Github PK

Hi! I’ve forked Pilot to add a basic drum machine channel, and I found the drum sounds in Enfer to be perfect (since they all have the same names/roles it’s easy to jump between kits and still get roughly the same type of sounds).

But since Enfer doesn’t have a license, I’m unsure if I can use the sounds (or at least push my changes to Github). Do you plan to add a license to Enfer?

I think the following file may contain a typo:

Enfer/scripts/kit.js

At line 73:

const notes = ['C', 'C#', 'D', 'D#', 'D', 'D#', 'E', 'F', 'F#', 'G', 'G#', 'A', 'A#', 'B']

Should the second D & D# be deleted from this array?

I believe it is creating an issue with how enfer is receiving midi notes.

I apologize if this is not the correct way to address this issue. I am only a hobbyist programmer and not proficient in pull requests. I only came across this issue because I was using the website "https://metasyn.github.io/learn-orca/" and noticed the inputs seemed odd. I thought I would investigate and see if I could find out why this was occurring.