Comments (2)
Ah, the check for increased metric is disabled on nightly
beacause "we're so efficient with part forwarding":
// With very high probability we should've encountered some cases where forwarded parts
// could not be applied because the chunk header is not available. Assert this did indeed
// happen.
// Note: For nightly, which includes SingleShardTracking, this check is disabled because
// we're so efficient with part forwarding now that we don't seem to be forwarding more
// than it is necessary.
if !cfg!(feature = "nightly") {
assert!(PARTIAL_ENCODED_CHUNK_FORWARD_CACHED_WITHOUT_HEADER.get() > 0.0);
}
That sounds weird. But I guess we can also disable the check for feature = "statelessnet_protocol"
as a quick fix 0_o
/cc @Longarithm
from nearcore.
The check was disabled for "nightly" in #10582 by @robin-near, 4 days ago.
Can I assume that the same reasoning can be applied to statelessnet_protocol
, which also uses SingleShardTracking
?
It sounds reasonable to me, I'll open a PR.
from nearcore.
Related Issues (20)
- contract runtime: fix LimitedMemoryPoll infrastructure to not abort the node when out of memories
- [1.37.0] Node crashes with index out of bounds
- [Memtrie] Memtrie trie recording needs to capture read nodes during the update code path
- Nodes stop synchronising
- Investigating the bottleneck in `compile_and_load()` HOT 3
- Reducing state witness size - compression HOT 8
- num_hops field on network messages is never incremented
- `peer_manager::tests::fuzzers::random_handshake_connect_fuzzer` fails locally HOT 2
- Measure chunk validation network roundtrip
- neard version mismatch in docker image
- Avoid eager loading of wasm binaries when executing a function call HOT 2
- mmap for filesystem compiled contract cache
- Re-enable tests ignored after removal of KeyValueRuntime
- Some actors stay around after SIGINT
- Issue with Near archive data (Blocks : 114744298 and 114744299) HOT 1
- Investigate the effects of decreasing function call gas/compute cost HOT 6
- `near_vm_runner` has to deal with two distinct UniversalEngines when artifact is already loaded in memory
- `Instantiatable::instantiate` requires `Arc<dyn Artifact>` which forces an incorrect `Sync` impl on the Artifacts
- [P2][stateless_validation] In-memory trie with resharding HOT 4
- [stateless_validation] Shard assignment shuffling for StatelessNet HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nearcore.