Giter Club home page Giter Club logo

Comments (8)

pugachAG avatar pugachAG commented on July 18, 2024 1

@walnut-the-cat yes, #10566 is pretty much the same as "Caching large state values" but with a slightly different approach

from nearcore.

walnut-the-cat avatar walnut-the-cat commented on July 18, 2024 1

In that case, I will merge #10566 into this one. Feel free to re-open if you think otherwise

from nearcore.

walnut-the-cat avatar walnut-the-cat commented on July 18, 2024

Thanks for the write up-! couple questions

  1. Could you share how I can read dashboard better?
  2. What does 'cache_state_values' in witness size graphs mean? Does it mean size of state witness when 'we don't do any compression but enable state value caching on validator side'?
  3. How long does 'decompression' take? Do we expect similar amount time to compression time? (thus 2x compression time latency)

from nearcore.

pugachAG avatar pugachAG commented on July 18, 2024

@walnut-the-cat

  1. I've added more detailed description for that dashboard
  2. Yes, it means caching state values with no compression
  3. decompression time is already included, added that to the description

from nearcore.

walnut-the-cat avatar walnut-the-cat commented on July 18, 2024

Should we consider this task (#10566) as overlap of what you are working on?

from nearcore.

shreyan-gupta avatar shreyan-gupta commented on July 18, 2024

Top N values as part of the Protocol

It was mentioned that we would globally cache to top N contracts based on usage. A good metric to use here can be size_of_contract * num_times_called_in_prev_epoch? This would provide the maximum size benefits assuming the load of the current epoch would be similar to the previous epoch.

from nearcore.

pugachAG avatar pugachAG commented on July 18, 2024

@shreyan-gupta size_of_contract * num_times_called_in_prev_epoch makes sense if we have a lot of cache churn. In my experiments with N=1000 per each shard it didn't fill even half-way in 6 days: dashboard. So it seems like straight-forward LRU would work perfectly fine.

from nearcore.

pugachAG avatar pugachAG commented on July 18, 2024

Compression was implemented in #10715
Closing this for now, a new issue will be created for the long-term (Top N values as part of the Protocol) solution

from nearcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.