Giter Club home page Giter Club logo

Comments (5)

ndimatteo avatar ndimatteo commented on August 15, 2024

Hey there @j4ysen!

I'm guessing the storeURL is not set properly in Sanity, and therefore it's failing at this line: https://github.com/ndimatteo/HULL/blob/main/components/cart.js#L52-L53

That's the only place where we use that variable, so if you can run some checks there, might provide some insight!

from hull.

j4ysen avatar j4ysen commented on August 15, 2024

Thanks for the quick reply Nick! I've done some checks and there's no reason why that would be undefined (since everything is properly defined in sanity). It works fine on new browsers, but on safari 12 for example it doesn't work. I'll do some more research and post here if I find out anything new.

from hull.

j4ysen avatar j4ysen commented on August 15, 2024

Did some research on a virtual machine of safari 12, and it seems that the 'data' put into cart comes up as empty

image
image

Is there any reason this might be the case on certain browsers?
Also seeing a lot of 404s, especially on the build manifest...

from hull.

ndimatteo avatar ndimatteo commented on August 15, 2024

I'm wondering if this is a bug with Safari 12, perhaps with how we destructure the data object for the Cart component here: https://github.com/ndimatteo/HULL/blob/main/components/cart.js#L19-L20

Can you try adding:

if (!data) return null

...above the destructuring to see if that helps?

from hull.

ndimatteo avatar ndimatteo commented on August 15, 2024

Closing due to inactivity, feel free to re-open if you have more details about the issue 🤘

from hull.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.