Giter Club home page Giter Club logo

Comments (7)

ndimatteo avatar ndimatteo commented on August 17, 2024

Hey there @MrUltimate– we use focus-trap-react in a number of places to help with accessibility with pop-ups, menus, and other overlays.

This error should not pop-up unless you have configured something that doesn't have a focusable element within it.

I'd suggest looking at the cookie banner, header navigation, etc. and making sure that you are rendering something where these are used, otherwise you'll see this client-side error.

from hull.

MrUltimate avatar MrUltimate commented on August 17, 2024

from hull.

ndimatteo avatar ndimatteo commented on August 17, 2024

@MrUltimate what page are you experiencing this on the live Demo site? I'm unable to replicate this on any page I've tested on.

from hull.

MrUltimate avatar MrUltimate commented on August 17, 2024

It happens when you hit checkout. Looks like it was my AdBlockers (uBlock Origin) that was messing with something. Here's a screenshot of the scripts it's blocking. I wonder if there's a way to prevent the error from happening in this case because it completely blocks the site without any fallback.

image

from hull.

ndimatteo avatar ndimatteo commented on August 17, 2024

Thanks for clarifying @MrUltimate,

I installed uBlock Origin and was still unable to replicate what you're seeing. Do you have specific settings enabled with your adblocker?

Either way, I'm not sure of a solution for this. If a browser extension is blocking core assets from loading it's inevitable that a site will crash or fail to function properly.

Regardless– I have plans to overhaul this starter with an entirely new approach (using hydrogen-react and radix, that will remove the need for focus-trap-react and other dependencies, so for now I'm going to close this issue.

from hull.

MrUltimate avatar MrUltimate commented on August 17, 2024

Thank you, I do have some additional filters active that might be causing it.

The rework sounds great, switching to radix definitely sounds like a good idea. I'm curious, what does hydrogen-react bring to the table other than some standard components like cart and checkout?

from hull.

nimser avatar nimser commented on August 17, 2024

It's also happening with me directly when hitting the homepage, using Brave browser with default settings (no browser extensions). Deactivating the Brave Shield entirely makes the page load, and looking in detail, it's the blocking of the GoogleTagManager tracker that was causing problem for me. Allowing that tracker to load results in a functioning website.

This should be easy to reproduce with a stock latest install of Brave Browser.

from hull.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.