Comments (7)
Hey there @MrUltimate– we use focus-trap-react
in a number of places to help with accessibility with pop-ups, menus, and other overlays.
This error should not pop-up unless you have configured something that doesn't have a focusable element within it.
I'd suggest looking at the cookie banner, header navigation, etc. and making sure that you are rendering something where these are used, otherwise you'll see this client-side error.
from hull.
from hull.
@MrUltimate what page are you experiencing this on the live Demo site? I'm unable to replicate this on any page I've tested on.
from hull.
It happens when you hit checkout. Looks like it was my AdBlockers (uBlock Origin) that was messing with something. Here's a screenshot of the scripts it's blocking. I wonder if there's a way to prevent the error from happening in this case because it completely blocks the site without any fallback.
![image](https://private-user-images.githubusercontent.com/7812204/279466712-bb3c71d1-7fc4-4bc4-86b5-c0a807a3ef3f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTUzNTgxNzcsIm5iZiI6MTcxNTM1Nzg3NywicGF0aCI6Ii83ODEyMjA0LzI3OTQ2NjcxMi1iYjNjNzFkMS03ZmM0LTRiYzQtODZiNS1jMGE4MDdhM2VmM2YucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MTBUMTYxNzU3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmMxMWQxODJjMWVjZThkNTM2MTcyNGUwNWVmMTMwYzZhOTgzYzMyODRlYjc1MzVjMzdlMWI3Njk2NzEwYjFjOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.BMct_kQv5KIlb02w-L1vaB6GOyJD7GrKRHIOpsBAszo)
from hull.
Thanks for clarifying @MrUltimate,
I installed uBlock Origin and was still unable to replicate what you're seeing. Do you have specific settings enabled with your adblocker?
Either way, I'm not sure of a solution for this. If a browser extension is blocking core assets from loading it's inevitable that a site will crash or fail to function properly.
Regardless– I have plans to overhaul this starter with an entirely new approach (using hydrogen-react
and radix
, that will remove the need for focus-trap-react
and other dependencies, so for now I'm going to close this issue.
from hull.
Thank you, I do have some additional filters active that might be causing it.
The rework sounds great, switching to radix
definitely sounds like a good idea. I'm curious, what does hydrogen-react
bring to the table other than some standard components like cart and checkout?
from hull.
It's also happening with me directly when hitting the homepage, using Brave browser with default settings (no browser extensions). Deactivating the Brave Shield entirely makes the page load, and looking in detail, it's the blocking of the GoogleTagManager tracker that was causing problem for me. Allowing that tracker to load results in a functioning website.
This should be easy to reproduce with a stock latest install of Brave Browser.
from hull.
Related Issues (20)
- Is it true that you have to redeploy every time a product is added? HOT 4
- Sanity CLI v3 causes project to not work correctly HOT 1
- GBP Cart Subtotals
- Sanity not connecting to Storefront HOT 2
- Products not appearing in Sanity—how to bring them over? HOT 1
- Bundles created with the Shopify App (Summer 2023) can't be added to cart HOT 11
- Mobile Crashes When Interacting On Page HOT 6
- marketing starter upgrade packages HOT 1
- unknown field found
- Sync seems inconsistent HOT 1
- Can't locate Sanity Starter HOT 1
- Not able to Import Shopify Products into sanity Studio
- Application error: a client-side exception has occurred (see the browser console for more information). HOT 2
- Issue cloning project from Vercel HOT 1
- TypeError: Cannot read properties of undefined (reading 'replace') HOT 2
- I got the same error after following the directions. I cloned the repository with git clonee and followed the instructions in the ReadMe.md file in the root. Localhost:3333 and localhost:3000 are running, I don't see any errors. HOT 2
- Tried deploying Hull from Vercel Interface. HOT 1
- Sanity Create Project is not working HOT 1
- @reach/rect error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hull.