ndac-todoroki / asdf-v Goto Github PK

asdf install v 0.1.7 works while 0.1.6 0.1.5 does not. (0.1.7 is the latest now)
This may be happening because asdf-v uses the newest v.c in git, but V is currently drastically changing and could be introducing breaking changes to the compiler.

Although, vlang/vc doesn't keep v.cs in releases, so it is a bit hard to get the latest v.c of the given version. (It could be done from the commits https://github.com/vlang/vc/commits/master, but you need to parse all the commit messages.)
There are limits to the github api too.

I tried to open the url showed in the output in browser and I got an 404, (url:https://github.com/vlang/v/archive/v0.1.17.tar.gz), only asdf install v ref:0.1.17 works properly.

you should not use make, cause wget vlang.io/v.c is security hole. Server can be compromised any time. Instead you should use v.c repo https://github.com/vlang/vc.git and build it without make

    cc -std=gnu11 -w -o vc v.c 
    ./vc -o v . 

    # recompile itself
    ./v -o v . 

look into my ArchLinux PKGBUILD https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vlang-git

https://github.com/vlang/vc seems to be depracated now :( see: vlang/vc@2029a40

Now how should we get v.c when compiling by targeting ref:some-commit?
I can't assure if the 0.1.0's v.c (at the release pages) could be used in git master in the futures too.
Also, getting v.c from the latest github release leads to instability, because we can't be sure if the latest release will always include v.c.
And parsing JSON in shellscripts couldn't be written clean.

The problem for now is: Any installations targeting ref:foo would not build.

Currently asdf-v is using the sorting algorithm used in asdf-ruby, but since v changed the naming sequences of the releases (vX.Y.Z to X.Y.Z), the sort isn't correct. This causes the CI test to fail.

Steps to reproduce

• asdf install v 0.1.24
  • 0.1.23 does not work either

What works

• git clone vlang/v && cd v && make

Steps to reproduce

asdf install v 0.1.21
==> Checking whether specified V release/reference exists...
==> Downloading 0.1.21 to /tmp/v_build_S9kr9w/v-version-0.1.21-src.tar.gz from https://github.com/vlang/v/archive/0.1.21.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   115    0   115    0     0    129      0 --:--:-- --:--:-- --:--:--   129
100 1444k    0 1444k    0     0  45631      0 --:--:--  0:00:32 --:--:-- 69319
==> Copying release into place
==> Checking whether specified release/reference containing v.c exists...
==> Downloading 0.1.21 to /tmp/v_build_S9kr9w/v-version-0.1.21-v.c from https://github.com/vlang/vc/archive/0.1.21.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   116    0   116    0     0     12      0 --:--:--  0:00:09 --:--:--    29
100    15  100    15    0     0      1      0  0:00:15  0:00:11  0:00:04    22

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Expected behavior

vlang should have been installed
Actual behavior

vlang should have been installed from tar.gz file but it expects zip format for extraction and installation
Environment

OS: ubuntu

Linux 5.0.0-32-generic #34-Ubuntu

asdf version:

➜ asdf version
version: v0.7.4

I have implemented a new version of this plugin as this repo seemed to be unmaintained.

See https://github.com/jthegedus/asdf-v/

v installer now created ~/.vlang/VROOT when there aren't any VROOT files found there.
This points to the installation path.
If this have something to do with executing v, we need to modify it.