nd-framework / nd_core Goto Github PK

[[Describe the bug

[ script:ox_inventory] [info] Saving 5 inventories to the database
[ script:ox_inventory] SCRIPT ERROR: @ox_inventory/modules/inventory/server.lua:613: ox_inventory was unable to execute a query!
[ script:ox_inventory] Unknown column 'id' in 'where clause'
[ script:ox_inventory] SELECT plate, glovebox FROM `vehicles` WHERE `id` = ?
[ script:ox_inventory] > callbackResponse (@ox_lib/callback/server.lua:60)
[ script:ox_inventory] > handler (@ox_lib/callback/server.lua:76)
[ script:ox_inventory] > <unknown> (@oxmysql/dist/build.js:22495)
[ script:ox_inventory] > processTicksAndRejections (node:internal/process/task_queues:96)
[ script:ox_inventory] 

To Reproduce
Steps to reproduce the behavior:
Started noticing these logs from players on the server recently as of the latest versions of oxlib, oxmysql, ox_target and ox_inventory

Additional context
Add any other context about the problem here.
overextended/ox_inventory#1191

Describe the bug
The vehicle system shows vehicles as nil and I can't use the vehicle system at all because of it

To Reproduce
Unknown

Expected behavior
When I buy a car and try to unlock it or try and push it to a garage and put it up I get a error code in my f8

Screenshots

Additional context
Love your frame work keep up the good work

Describe the solution you'd like
NoCharacters update to potentially work with ND 2.0 if its even possible

Describe alternatives you've considered
The only alternative that the community at large suggested was some form of optional character selection/creation screen with some form of vMenu exports/integration to make them synced. So people could run both on their server at the same time if they wanted to. Then the players would just choose if they want to use the character creation screen by ND or stick with vMenu - But that sounds like a hell of lot more work. And likely not even possible.

Additional context
I know its rare and a unique request maybe, but our community absolutely seems to be against classic character jobs/creation as our entire server is built on standalone with ox resources and vMenu and all permissions are done with ACE not esx/qb style jobs.

Describe the bug
The clothes shops don't save the outfits players make and save inside said clothing shop when the player leaves the server and rejoins the outfit is not saved.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'clothing shop and create a outfit and save it'
2. leave and rejoin.

Expected behavior
Outfit will not be saved.

Screenshots
None.

Additional context
None.

Bug Description:
In the Vehicle System of ND_Core, there is an issue where vMenu cars are affected by the system's lock on public cars, preventing them from being unlocked and drivable whent the player exits then return entered the vehicle.

To Reproduce:

1. Utilize vMenu to spawn a vehicle in the FiveM environment(vMenu).
2. Exit the Spawned vehicle.
3. Observe that the system locks those spawned through vMenu.

Expected Behavior:
The Vehicle System should differentiate between public cars and those spawned via vMenu, allowing vMenu cars to remain unlockable and drivable even when the system enforces locks on public cars.

Additional Context:
This bug disrupts the intended functionality of the Vehicle System, particularly when interacting with vehicles spawned through vMenu.

[ script:ND_Core] SCRIPT ERROR: @ND_Core/server/main.lua:19: attempt to index a nil value (global 'config')
[ script:ND_Core] > fn (@ND_Core/server/main.lua:19)

I have made sure it was updated and still throws the error code, is it on my end or am I doing something wrong?

If someone could help me it would be much appreciated, i am new to this kind of stuff and i am trying to learn!

Bug Description:
When creating a new character in ND_Characters, the assigned role IDs do not get associated with the character as expected.

To Reproduce:

1. Navigate to the 'ND_Characters' module.
2. Click on the 'Create New Character' button.
3. Fill in the required information for the new character.
4. Select the desired roles for the character.
5. Complete the character creation process.

Expected Behavior:
Upon creating a new character, the selected role IDs should be assigned and associated with the character, reflecting the character's roles accurately.

Screenshots:
https://cdn.discordapp.com/attachments/1174595405871321198/1182429296833331322/SPOILER_image.png?ex=65971f18&is=6584aa18&hm=4d5525d41008d0ded0286aec6924705ea35828b26fe4e9fd0e7867dfe58cc6bf&
https://cdn.discordapp.com/attachments/1174595405871321198/1174814975152373800/image.png?ex=65971b35&is=6584a635&hm=fb8fdbf30d9885de4da04ed1e33176adb007332782878f48f955e159d2557788&
https://cdn.discordapp.com/attachments/1174595405871321198/1174811581536800829/image.png?ex=6597180b&is=6584a30b&hm=2ba6ced527af0709e150cf675d4a4c5131a4bc705b490814c277ebdf37f978e1&

Additional Context:
This issue impacts the proper functioning of the ND_Characters module, as the absence of assigned role IDs can lead to incorrect permissions, access, or functionality for the newly created character. It is crucial to address this bug to ensure the accurate representation of roles within the application.
When you login and create a character it will not load that you have the RoleID.

Which then wont display in Departments.
Yet if you restart ND_Core then ensure ND_Characters it'll grab the role if your in game.

https://discord.com/channels/857672921912836116/1174595405871321198
https://streamable.com/tmeifg

This is the chat commands from the ND_Core that are made into a separate resource.

ox_lib is not marked as a dependency and it can lead to some issues if ox_lib is started AFTER this resource !

Issue reference on the cfx discord : https://discord.com/channels/192358910387159041/1164139686378356816/1243865784456052758

On the "Create New Character 0/15" the department dropdown will not show when clicked.

To Reproduce
Steps to reproduce the behavior:
launch game with no characters created > select "Create New Character 0/15" > select the "Department" dropdown

Expected behavior
Expect to see a dropdown of the departments

Screenshots

Video Example https://cdn.discordapp.com/attachments/857672921912836119/977658924910133278/2022-05-21_14-46-51.mp4

NDCore.getPlayerServerInfo(source) appears to always return nil, which would probably be the cause behind not being able to see departments in ND_Characters when they have a discord role ID, even if you have a matching role ID

heres how im checking this (in case ive done something wrong)
code:

output:

Describe the bug
Users can not open their inventory. When viewing F8 it states it can not open the inventory cause the player is fatality injured. Only solution is to /revive [id].

To Reproduce
Steps to reproduce the behavior:

1. Die while using inventory with or without ND_Ambulance.
2. Relog, and attempt to open inventory.
3. This happens sometimes even without dying, on first join.

Expected behavior
A state for characterLoaded to see if player is truly fatally injured? So that when a player joins and is not dead they can use inventory.

Screenshots
https://media.discordapp.net/attachments/1201345288737128458/1201351555174125648/image.png?ex=65c980d2&is=65b70bd2&hm=afa7bc58f8875e742bfee458dd51306842ab42b07bce6bee9549287f9b2be8ab&

Additional context
N/A

when doing /showid it doesnt give one nor does it give the notification for giving it to the person

OX told me this is a ND_Core issue, for some reason the Inventory thinks the Ped is dead and won't let you open the Inventory it will just say "Can't open Inventory right now" and gives a error.

Here is the link to the pic of the error:
https://media.discordapp.net/attachments/884511127608897557/1196181512438169651/image.png?ex=65b6b1d8&is=65a43cd8&hm=e9a8c42de734295c06730ab9bafb71c2cca9aece406fcc160876c692d94c6bbd&=&format=webp&quality=lossless

Describe the bug
The departments duplicate within the character selection

To Reproduce
Steps to reproduce the behavior:
Not too Sure but load up and it is duplicated.

Expected behavior
Not to duplicate

Screenshots

Additional context
Goes away after a restart of ND_CharacterSelection.

ND_Core has been updated to 2.0.0 but is not available to the public yet, there's new exports better performance, bug fixes and cleaner code.

Add support for MP Peds to have hair, beards, tattoos for further customization of Peds for scripts.

there seems to be no /pay or /give for money to other players

Use new exports from ND_Core and add a discord webhook feature in config for logging, and rewrite code to make it better.

Describe the bug
/remove resets shield

To Reproduce
Steps to reproduce the behavior:

1. run command /revive me

Expected behavior
Not remove shield, instead heal player health.

Is your feature request related to a problem? Please describe.
Not necessarily, but as of right now when you have a vehicle outside of the garage then stop the resource/stop the server, the vehicle is lost forever.

Describe the solution you'd like
On resource stop, return all owned vehicles to the garage/impound

Describe alternatives you've considered
N/A

Additional context
N/A

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'chat'
2. type in /darkweb ...
3. See nothing and no error

Expected behavior
a dark web message in chat.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
if on as leo it gives the error saying "error: ... cannot access this command"

Am I allowed to make a new repo using your code for Fuel script and convert it for qb-core? With full credits and same script name obviously.

Describe the bug
Without having the correct amount of money in cash, if you /pay somebody, they wrill recieve your money... lol

Also, invoices are bugged and will not allow you to pay them.

To Reproduce
Steps to reproduce the behavior:

1. Have a test subject, have 2500 in cash.
2. /pay 8000
3. Check money amount.
4. See problem.

Expected behavior
/pay is refused due to insufficent funds.

Describe the bug
when finding a randomly unlocked vehicle, you can enter, start, and drive it around, but once you exit the vehicle and re-enter, the engine will no longer start

To Reproduce

1. set randomUnlockedVehicleChance to a number in the config
2. find an unlocked vehicle and get in it
3. drive, get out, get back in it
4. you can no longer drive

Expected behavior
im unsure about how this was intended to work, but my best guess would be either

1. you should be able to start the car back up
2. you shouldn't be able to start the car at all

video: https://medal.tv/games/gta-v/clips/1OlndZ-WBVJTHb/d1337mC4hrP5?invite=cr-MSx3ZW4sMzczNjk4LA

I'm trying to run the query SQL file in HeidiSQL. When I try to run it I get this Error.

SQL Error (1101): BLOB, TEXT, GEOMETRY or JSON column 'data' can't have a default value

I think this has something to do with MySQL and not HeidiSQL because I get the same error if I try phpMyAdmin

I was reading Stackoverflow. It wanted me to change stuff. But I wanted to go here first before I go changing anything.

By the way the file was called query.sql

Instead of having it /pay (amount) to the nearest character, allow us to do /pay [id] (amount) to prevent any mishaps :)

Describe the bug
Almost like you are in a map builder/no-clip situation. Also The AOP isn't displayed in the character creation.

To Reproduce
Steps to reproduce the behavior:

1. Set characterSelectionAopDisplay = true,
2. Load into Game and See error in in-game console.
3. Select your character.
4. See error in in-game console
5. Almost like you are in a map builder/no-clip situation.
6. No-Clip to get out of it.

Expected behavior
Select Character and play.

Screenshots

Additional context
Reference to code:
https://github.com/Andyyy7666/ND_Framework/blob/5720049448f707e2b11b745a3eafba2b1c1b1c3e/ND_CharacterSelection/config.lua#L6