Giter Club home page Giter Club logo

ajaxify_rails's Issues

Is there a way to do full page reloads from a ajaxified request?

For example:

Login required before filter redirects to login page but when a ajaxified link is clicked and the filter halts the execution, the redirect_to is also ajaxified but I want it to load the full page instead of ajaxified div.

Is there any way to do so?

Thanks

License missing from gemspec

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can imagine, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post about this project for more information.

Auto-refresh when assets are precompiled (v. 0.7.*)

We have installed ajaxify_rails 0.7.5.
It is working perfectly on development environment, wherein assets are not precompiled.

Then when we deployed our app on staging and production environment. Something weird is happening. It appears that ajaxify_rails is processing the request twice. When you click a link, ajaxify will happen, then after the response is rendered the page will refresh. I'm not sure if ajaxify_rails is processing the request twice, or there is something on ajaxify_rails code that initiate a refresh action after rendering.

I downgraded to v 0.5.* then the issue was gone. The issue is also not present on v. 0.2.*.

There is something on v 0.7.* and the precompiled assets that is triggering this auto-refresh thing. I still don't have an idea what is happening on the code. Maybe these will give you some clues where to look at. Thanks and Goodluck!

confirm and $.rails.confirm

Hi

line 118 and 119, it will be better to use the buil-in rails confirm function in place of the standard confirm function, like this

if options.confirm
  return false unless $.rails.confirm(options.confirm, element)

it should permit to customize the dialog of the confirmation.

But how to pass the element (link) parameter

Vincent

Link detecting inside main

I want to make work ajaxify with links that appears in "changing content - class main". Can I refresh ajaxify in some way ? I was trying initialize Ajaxify again in content_inserted event but it was just unlucky shot.

Cannot deactivate ajaxify / fail gracefully to fulll page load

I have a sitaution where I need to deactivate ajaxify.
I tried Ajaxify.activate(false) as stated in the readme, but it doesn't seem to do anything.
Ajaxify works just fine even after calling Ajaxify.activate(false).

So I tried just not initializing Ajaxify at all for specific situations.
I expected it to do fail gracefully and do a full page load, but it returned an error at line 184.
TypeError: current_url is null
options.url = current_url.replace(/(&|&|?)ajaxify_redirect=true/, '');

And then I went do the demo site to see if it does full page load when the check box is not checked. Everything was still ajaxified when 'ajaxify' checkbox was not checked.

It would be great if deactivating works properly and it fails gracefully to do full page load when Ajaxify is not initialized.

Thank you.

is it some hack for it

In requirments there is :
Your app doesn't use named anchors (#). Named anchors can't be correctly represented in the fallback hash based url scheme.

Is it some hack for it ?

Problem with ajaxify's response

Hello !

I am having a problem with ajaxify's response, when i try to access to a link and so to update only #main, the response contains the html code of the whole page (with js sources / metadata / footer ... ) and put it in the #main div. I really dont understand why, even after analyzing your demo source code.
If anyone had this problem before or knows how to solve it, it would be very nice !
Thank you :-)

Clicking on a link always scrolls to the top

When I click on a link, the screen always scrolls to the top.
It can be reproduced on the demo site. Decrease the height of the browser window and you will see that screen scrolls to the top when a link is clicked.
I want my screen to stay where it is, but there are situations where it needs to scroll to the top. It would be great if its scrolling behavior can be configurable.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.