Comments (9)
What happens if you add -D_XOPEN_SOURCE=500 to your CFLAGS/CXXFLAGS?
from ncmpcpp.
With -D_XOPEN_SOURCE=500
I have same errors but..
I added -D_XOPEN_SOURCE_EXTENDED
to CXXFLAGS and it works. I can make pull request with changes but I don't sure that is cross platform solution. Could you check it?
And second thing:
Does ncmpcpp really depends on ICU? Because I configured the project with ICU_CFLAGS=trash ICU_LIBS=trash
and it works (to avoid errors because I don't have icu libraries in pkg-config).
May be we should remove the dependency?
from ncmpcpp.
With -D_XOPEN_SOURCE=500 I have same errors but..
I added -D_XOPEN_SOURCE_EXTENDED to CXXFLAGS and it works. I can make pull request with changes but I don't sure that is cross platform solution. Could you check it?
That it weird, from man feature_test_macros:
_XOPEN_SOURCE_EXTENDED
If this macro is defined, and _XOPEN_SOURCE is defined, then expose
definitions corresponding to the XPG4v2 (SUSv1) UNIX extensions (UNIX
95). This macro is also implicitly defined if _XOPEN_SOURCE is
defined with a value of 500 or more.
So something fishy is going on there. Also, because of the above, defining _XOPEN_SOURCE_EXTENDED explicitly is definitely not a good general way to solve it.
ncmpcpp should depend on ICU only if boost was compiled with ICU. Does configure fail if ICU is not installed?
from ncmpcpp.
/*
* With XPG4, you must define _XOPEN_SOURCE_EXTENDED, it is redundant (or
* conflicting) when _XOPEN_SOURCE is 500 or greater.
*/
#undef NCURSES_WIDECHAR
#if defined(_XOPEN_SOURCE_EXTENDED) || defined(_XPG5)
#define NCURSES_WIDECHAR
#endif
It is from my /usr/local/Cellar/ncurses/5.9/include/ncursesw/curses.h
. And I see "you must define _XOPEN_SOURCE_EXTENDED"
from ncmpcpp.
and after the comma it says exactly what I pasted above.
from ncmpcpp.
Yes.
defining _XOPEN_SOURCE_EXTENDED explicitly is definitely not a good general way to solve it.
So what is the good way? I'm not familiar with this feature_test_macros_magic.
from ncmpcpp.
I have no idea. I'm also not familiar with it, what I wrote is just what I found after checking out yesterday the fragment of curses.h you pasted.
You can locally define XOPEN_SOURCE_EXTENDED if for some reason it's not defined by XOPEN_SOURCE.
from ncmpcpp.
I managed that it happens because there is no features.h on macosx. This feature_test_macros_magic is in the header. So I'll pass XOPEN_SOURCE_EXTENDED to homebrew formula (macosx package manager). You can close the issue. Thanks.
from ncmpcpp.
I still need to add -D_XOPEN_SOURCE_EXTENDED
in order to build ncmpcpp 0.7.1 on macosx El Capitan. Is this the correct way?
from ncmpcpp.
Related Issues (20)
- [BUG] Genius endpoint doesn't return lyrics HOT 1
- [FEATURE] Support recursive directory structure in playlist view
- [BUG] ~/.lyrics directory is being created on startup HOT 1
- Constant crashes after updating MPD to 0.23.12 HOT 5
- Is there a new release planned or is this project abandoned? HOT 16
- Multiple servers, only connects to local HOT 2
- [FEATURE] Separate, fully independent main playlist instance for each saved Playlists
- [FEATURE] "--cmd" feature like vim/neovim HOT 1
- Been using without any issues on boot today n/a volume and cannot restore it!!
- [BUG] ncmpcpp regex searching not working for bigger libraries HOT 2
- The progress bar disappears in ogg files
- [BUG] Right click adds an entire album twice to the playlist screen HOT 2
- [BUG] 'azlyrics.com' endpoint doesn't return lyrics HOT 3
- [BUG] ncmpcpp pausing on song change if not focused HOT 1
- [FEATURE] cmus-like global library display & search
- [Question] 6th mode / empty mode in alternative user interface HOT 1
- [BUG] Can't play audio after inserting tags HOT 1
- [BUG] Build failing re: taglib HOT 3
- How can I view the filename? HOT 1
- [FEATURE] Ability to disable certain menus (like the tag editor) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ncmpcpp.