Make "data : " Prefix toggleable or remove entirely about webhookd HOT 6 CLOSED

Thinking about your problem, I think we can solve this with a cooler way than a feature flipping flag.
Maye we should use the Accept HTTP header. Only activate SSE if the Accept request header is text/event-stream.
I have to test, curl, and several Browsers to verify that this header is properly set when expecting a SSE response.

from webhookd.

As a result, using the Accept header is a perfect choice for streaming protocol.
Thank you very much for this issue.

from webhookd.

Hi, thank you for the interest shown in this project!

I understand your need. Your concern is not really about the prefix but about the Server Sent Event (SSE) usage.
The prefix is part of the Event Stream format.
What the project needs is the possibility to activate/deactivate the SSE support.

Regards

from webhookd.

Thanks for the feedback. I learned something new. Until now, I didn't know about the Event Stream format. I will close my PR and work on a toggle to deactivate SSE if needed.

from webhookd.

Thanks for the neat solution! I already tested it using the edge container image. Do you plan on creating a new release for this addition?

from webhookd.

Yes but maybe with another addition...

from webhookd.