(Global) logger prematurely disposed when ILogger is resolved directly from a child lifetime scope about autofac-serilog-integration HOT 4 CLOSED

I think this still happens if you use RegisterLogger(builder, logger, dispose: true). I think that the issue is that LoggerProvider is registered per-dependency instead of singleton:

builder.Register(c =>
                {
                    LoggerProvider provider = new LoggerProvider(_logger);
                    return provider;
                })
                    .AsSelf()
                    .AutoActivate()
                    .OnRelease(c => c.Release());

(https://github.com/nblumhardt/autofac-serilog-integration/blob/dev/src/AutofacSerilogIntegration/ContextualLoggingModule.cs#L44)

from autofac-serilog-integration.

Thanks @srogovtsev - I think you're right 👍

from autofac-serilog-integration.

I think I can take this, but there's one thing I'd like to understand: is there any reason you don't want LoggerProvider to be single-instance?

(actually, this mirrors the Microsoft.Extensions.Logging integration, where it is single-instance)

from autofac-serilog-integration.

I think single-instance would be correct, here (though it's been a while since I've worked in this codebase...). Thanks for the offer of help! 👍

from autofac-serilog-integration.