Custom ILogger registration? about autofac-serilog-integration HOT 5 CLOSED

Created a PR: #8

from autofac-serilog-integration.

Thank you for the PR! Not a scenario I'd given any thought to.

I'm a bit rusty on how the MEF integration works - would you be able to give a code sample showing how the updated API is used?

Regards,
Nick

from autofac-serilog-integration.

Using the updated api, I can register the logger like so:

builder.RegisterLogger(configureRegistration: x => x.Export());

That way, the logger is being declared as an export and I can inject it into a resolved MEF component using Autofac.

However I think it would be good idea to have this API generally, because if I'm going to register a component within my IoC, I want at least to be able to define how the component is being registered. Maybe I need a special lifetime? Maybe I want to provide additional metadata?

from autofac-serilog-integration.

Thanks for the follow-up! Makes sense.

It's a nice tidy PR, but given how small this project is I think it might be better in this case to grab the code and modify it in your own project. I'd like to keep the API of this one trivially simple, and I'm not sure exposing some of the implementation (i.e. generic arguments on IRegistrationBuilder<,,> will hold up over time. Would this work for you?

from autofac-serilog-integration.

Yup, works for me. I cannot say anything about the consequences of exposing the generic IRegistrationBuilder<,,>, so this is probably for the best.

Thank you for your time. :)

from autofac-serilog-integration.