Giter Club home page Giter Club logo

Comments (7)

darind avatar darind commented on May 24, 2024 1

@NathanWalker, we have released a fix for this. Please try the latest tns-ios@beta-v8 package and let us know if you are still experiencing any issues.

from ios.

darind avatar darind commented on May 24, 2024 1

@NathanWalker, we have released a fix for this crash. When you get the chance you can try it and let us know if you are still encountering any problems.

from ios.

NathanWalker avatar NathanWalker commented on May 24, 2024

@darind wow. just wow. Worked perfect and the speed difference is quite noticeably even better (and it was good before). I'm quite thrilled - thank you! How safe would it be to go to production using this v8 runtime? The app works 100% so far from what I've seen which is quite impressive 👏 🎉

from ios.

NathanWalker avatar NathanWalker commented on May 24, 2024

I did run into one interesting thing. When navigating back out of a view that was playing a video I got this:

====== Assertion failed ======
====== Assertion failed ======
Native stack trace:
Native stack trace:
1          0x11200d2eb tns::Assert(bool, v8::Isolate*) + 119
1          0x11200d2eb tns::Assert(bool, v8::Isolate*) + 119
2          0x111f7a4db tns::ArgConverter::MethodCallback(ffi_cif*, void*, void**, void*) + 301
2          0x111f7a4db tns::ArgConverter::MethodCallback(ffi_cif*, void*, void**, void*) + 301
3          0x1120ac166 ffi_closure_unix64_inner + 662
3          0x1120ac166 ffi_closure_unix64_inner + 662
4          0x1120ad3ea ffi_closure_unix64 + 72
4          0x1120ad3ea ffi_closure_unix64 + 72
5       0x7fff22f2d86b _CFNetworkHTTPConnectionCacheSetLimit + 205915
5       0x7fff22f2d76f _CFNetworkHTTPConnectionCacheSetLimit + 205663
6       0x7fff25732d61 __NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ + 7
6       0x7fff25732d61 __NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ + 7
7       0x7fff25732c59 -[NSBlockOperation main] + 98
7       0x7fff25732c59 -[NSBlockOperation main] + 98
8       0x7fff25735be6 __NSOPERATION_IS_INVOKING_MAIN__ + 17
8       0x7fff25735be6 __NSOPERATION_IS_INVOKING_MAIN__ + 17
9       0x7fff25731e59 -[NSOperation start] + 731
9       0x7fff25731e59 -[NSOperation start] + 731
10      0x7fff25736540 __NSOPERATIONQUEUE_IS_STARTING_AN_OPERATION__ + 17
10      0x7fff25736540 __NSOPERATIONQUEUE_IS_STARTING_AN_OPERATION__ + 17
11      0x7fff2573604a __NSOQSchedule_f + 182
11      0x7fff2573604a __NSOQSchedule_f + 182
12      0x7fff519eb265 _dispatch_block_async_invoke2 + 83
12      0x7fff519eb265 _dispatch_block_async_invoke2 + 83
13      0x7fff519de7b9 _dispatch_client_callout + 8
13      0x7fff519de7b9 _dispatch_client_callout + 8
14      0x7fff519e0b75 _dispatch_continuation_pop + 440
14      0x7fff519e0b75 _dispatch_continuation_pop + 440
15      0x7fff519e0241 _dispatch_async_redirect_invoke + 817
15      0x7fff519e0241 _dispatch_async_redirect_invoke + 817
16      0x7fff519edbf9 _dispatch_root_queue_drain + 350
16      0x7fff519edbf9 _dispatch_root_queue_drain + 350
17      0x7fff519ee39b _dispatch_worker_thread2 + 99
17      0x7fff519ee39b _dispatch_worker_thread2 + 99
18      0x7fff51c016b6 _pthread_wqthread + 220
18      0x7fff51c016b6 _pthread_wqthread + 220
19      0x7fff51c00827 start_wqthread + 15
19      0x7fff51c00827 start_wqthread + 15

Lemme know if you'd prefer me open a new issue for that one or if might have idea what that stack could be result of.

from ios.

darind avatar darind commented on May 24, 2024

@NathanWalker, thanks for confirming. You can leave it here. Is this crash consistent and if yes, what are the steps to reproduce it? I will have a look.

from ios.

NathanWalker avatar NathanWalker commented on May 24, 2024

Thanks @darind - in that same project I shared with you via Slack (added login details in slack for you to use) - tap on the 2nd tab icon at top (looks like a diamond), then choose 'Play' on the first item in the list there. Let the video play for a moment and then tap the top left navigation back icon to get the stack above 👍

from ios.

NathanWalker avatar NathanWalker commented on May 24, 2024

I'm closing this - @darind is incredible. Fixed both issues raised. v8 works great in a very large project of ours now and we are even considering trying in production.

from ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.