naokistark / hyperlight Goto Github PK

What steps will reproduce the problem?
1. create a CSS selector such as div#main_content or h2.sub_heading

What is the expected output? What do you see instead?
highlighting for class or id only matches up to the underscore, leaves the 
underscore as plain text node, and matches the rest of the class or id as a 
keyword


What version of the product are you using? On what operating system?
Using r52 straight from SVN, Windows 7, PHP 5.2.9


Please provide any additional information below.

There are very few keywords you can target for CSS, so I went ahead and 
implemented finer control. Patch is attached. I haven't looked through any 
other highlighters so if the keyword subgroups need renamed to match other 
languages I won't be offended.

There are also some keywords added in PHP 5.4/5.5 that were missing; they are 
also in the attached diff.

Folding is implemented in the function `hyperlight_calculate_fold_marks`
which is basically one big hack and only works and VB and C# `region` folds.

It's just a proof of concept at the moment. The code needs to be
refactored, cleaned up and proper handling for (several types of?)
language-independent folds needs to be added. Likewise, proper client-side
handling is needed (e.g. in the form of a `hyperlight_write_header` function).

I found a problem with the comment highlighting with VB.

If you have a single quote comment which has nothing after it the comment 
carries onto the next line.

Example:

    '
    ' Test this fails by including Imports System in the last comment
    '
    Imports System

    '
    ' Test, this is fine
    Imports System

I don't quite understand the original regex "/(?:'{1,2}[^']|rem\s).*/i" but I 
managed to fix the problem for me by changing it to "/'{1,2}.*?\n/i".

Added some more keywords

I'd like to use this with an SVN viewer I wrote (which uses PHPTAL to generate 
XHTML), but without the ability to return a highlighted buffer instead of 
outputting it, I'd be resorting to some bad ob_* hacks that I would rather not 
do.

The keywords get, set, partial and value are missing from the CSharp 
highlighter.

This code needs to be shipped with plugins for software such as WordPress.
Since there's no configuration necessary this shouldn't be too hard.