nandajavarma / automated-rendering-testing Goto Github PK

by including it in smc/fonts repo and adding to font builds

images has following constant attributes " width="200" height="150" . Try to render images in actual dimensions

Use consistent formatting. Do not mixup spaces and tabs.

Home.html - the div is not closed-

$ ./rendering_test.py ml-test-data/rachana-test-data/Rachana.ini

Rendering problems observed!

Could not open the file Rachana.ttf

Actually problem about rendering issues should not be reported if font not found

Use consistent whitespaces - use tabs for indentation.

Use consistent blank lines between style definitions.

body font: font-family: ‘Palatino Linotype’, ‘Book Antiqua’, Palatino, serif; What are these fonts, are they used as webfonts?

background:#666666 url(img/button.png) no-repeat;
where is this image?

Use consistent spacing after column. clear:both; -> clear: both;

smc/fonts has a test file and this repo has a test file. They are not same. Please submit a patch to smc/fonts to include all these test. more tests are nice

The following tests fails. But I dont see any issue in rendering. I guess tests are wrong. Please fix

എടാാാാാാാാ
ക്സ്ര
ന്റ്ര
ഖ്ര
ഥ്ര
വൎത്തുളം
പ്പ്ര
അൎജ്ജുനന്‍
യ‍്യ
വ‍്വ
ൎക്ക്ര
ഗ്ഗ്രോ
ഗ്ഗ്ര

Also, if test fails, instead of just showing red, we must show actual result and expected result(glyph sequencens. Otherwise it is not useful.

os.system('./renderingtesting.py -w wf -r rf it rendf -o outfile -e errorfile -f ff -m mydir')

This is inefficient way of calling rendering test. All these code are in same directory, project. Why can't we natively call the module methods instead of OS execution of the python script?

testing_modules/init.py:2:31: W291 trailing whitespace
testing_modules/create_result.py:4:1: E302 expected 2 blank lines, found 0
testing_modules/create_result.py:5:3: E111 indentation is not a multiple of four
testing_modules/create_result.py:6:3: E111 indentation is not a multiple of four
testing_modules/create_result.py:7:3: E111 indentation is not a multiple of four
testing_modules/create_result.py:8:3: E111 indentation is not a multiple of four
testing_modules/create_result.py:10:8: E222 multiple spaces after operator
testing_modules/create_result.py:12:7: E111 indentation is not a multiple of four
testing_modules/create_result.py:17:7: E111 indentation is not a multiple of four
testing_modules/create_result.py:19:7: E111 indentation is not a multiple of four
testing_modules/create_result.py:21:17: E202 whitespace before ']'
testing_modules/create_result.py:22:7: E111 indentation is not a multiple of four
testing_modules/create_result.py:22:34: E225 missing whitespace around operator
testing_modules/create_result.py:24:7: E111 indentation is not a multiple of four
testing_modules/create_result.py:26:3: E111 indentation is not a multiple of four
testing_modules/create_result.py:27:3: E111 indentation is not a multiple of four
testing_modules/create_result.py:28:1: W391 blank line at end of file
testing_modules/test.py:3:1: E302 expected 2 blank lines, found 0
testing_modules/test.py:3:80: E501 line too long (87 > 79 characters)
testing_modules/test.py:4:3: E111 indentation is not a multiple of four
testing_modules/test.py:5:3: E111 indentation is not a multiple of four
testing_modules/test.py:6:3: E111 indentation is not a multiple of four
testing_modules/test.py:7:3: E111 indentation is not a multiple of four
testing_modules/test.py:9:3: E111 indentation is not a multiple of four
testing_modules/test.py:9:41: E231 missing whitespace after ','
testing_modules/test.py:9:57: E231 missing whitespace after ','
testing_modules/test.py:10:3: E111 indentation is not a multiple of four
testing_modules/test.py:11:3: E111 indentation is not a multiple of four
testing_modules/test.py:12:3: E111 indentation is not a multiple of four
testing_modules/test.py:13:3: E111 indentation is not a multiple of four
testing_modules/test.py:14:1: E101 indentation contains mixed spaces and tabs
testing_modules/test.py:14:1: W191 indentation contains tabs
testing_modules/test.py:15:3: E111 indentation is not a multiple of four
testing_modules/test.py:17:7: E111 indentation is not a multiple of four
testing_modules/test.py:18:7: E111 indentation is not a multiple of four
testing_modules/test.py:18:53: E261 at least two spaces before inline comment
testing_modules/test.py:18:54: E262 inline comment should start with '# '
testing_modules/test.py:18:80: E501 line too long (117 > 79 characters)
testing_modules/test.py:19:7: E111 indentation is not a multiple of four
testing_modules/test.py:20:7: E111 indentation is not a multiple of four
testing_modules/test.py:23:7: E111 indentation is not a multiple of four
testing_modules/test.py:23:49: E261 at least two spaces before inline comment
testing_modules/test.py:23:50: E262 inline comment should start with '# '
testing_modules/test.py:23:80: E501 line too long (149 > 79 characters)
testing_modules/test.py:26:1: E101 indentation contains mixed spaces and tabs
testing_modules/test.py:26:1: W191 indentation contains tabs
testing_modules/test.py:27:3: E111 indentation is not a multiple of four
testing_modules/test.py:27:41: E231 missing whitespace after ','
testing_modules/test.py:27:57: E231 missing whitespace after ','
testing_modules/test.py:28:3: E111 indentation is not a multiple of four
testing_modules/test.py:29:3: E111 indentation is not a multiple of four
testing_modules/test.py:32:3: E111 indentation is not a multiple of four
testing_modules/test.py:33:3: E111 indentation is not a multiple of four
testing_modules/test.py:36:7: E111 indentation is not a multiple of four
testing_modules/test.py:39:3: E111 indentation is not a multiple of four
testing_modules/test.py:40:3: E111 indentation is not a multiple of four
testing_modules/test.py:41:3: E111 indentation is not a multiple of four
testing_modules/test.py:43:3: E111 indentation is not a multiple of four
testing_modules/test.py:44:3: E111 indentation is not a multiple of four
testing_modules/test.py:45:3: E111 indentation is not a multiple of four
testing_modules/test.py:48:3: E111 indentation is not a multiple of four
testing_modules/test.py:51:80: E501 line too long (91 > 79 characters)
testing_modules/test.py:53:7: E111 indentation is not a multiple of four
testing_modules/test.py:54:7: E111 indentation is not a multiple of four
testing_modules/test.py:55:3: E111 indentation is not a multiple of four
testing_modules/test.py:57:3: E111 indentation is not a multiple of four
testing_modules/test.py:58:3: E111 indentation is not a multiple of four
testing_modules/test.py:59:3: E111 indentation is not a multiple of four
testing_modules/test.py:61:7: E111 indentation is not a multiple of four
testing_modules/test.py:65:7: E111 indentation is not a multiple of four
testing_modules/test.py:67:3: E111 indentation is not a multiple of four
testing_modules/test.py:68:43: E221 multiple spaces before operator
testing_modules/test.py:69:3: E111 indentation is not a multiple of four
testing_modules/test.py:70:1: E101 indentation contains mixed spaces and tabs
testing_modules/test.py:70:1: W191 indentation contains tabs
testing_modules/test.py:70:1: W293 blank line contains whitespace
testing_modules/test.py:70:1: W391 blank line at end of file

$ python rendering_test.py ml-test-data/meera-test-data/Meera.ini

Could not open the file ../ml-test-cases.txt

This relative path should work with respect to ini file

It is a 68 line method with less documentation. Please refactor it smaller methods and add documentation

rendering_testing.py:8:1: E302 expected 2 blank lines, found 0
rendering_testing.py:9:3: E111 indentation is not a multiple of four
rendering_testing.py:11:3: E111 indentation is not a multiple of four
rendering_testing.py:12:51: W291 trailing whitespace
rendering_testing.py:14:3: E111 indentation is not a multiple of four
rendering_testing.py:17:80: E501 line too long (125 > 79 characters)
rendering_testing.py:18:80: E501 line too long (139 > 79 characters)
rendering_testing.py:19:80: E501 line too long (148 > 79 characters)
rendering_testing.py:20:80: E501 line too long (109 > 79 characters)
rendering_testing.py:21:80: E501 line too long (118 > 79 characters)
rendering_testing.py:22:32: E251 unexpected spaces around keyword / parameter equals
rendering_testing.py:22:80: E501 line too long (108 > 79 characters)
rendering_testing.py:23:80: E501 line too long (137 > 79 characters)
rendering_testing.py:26:1: E101 indentation contains mixed spaces and tabs
rendering_testing.py:26:1: W191 indentation contains tabs
rendering_testing.py:28:1: E101 indentation contains mixed spaces and tabs
rendering_testing.py:28:1: W191 indentation contains tabs
rendering_testing.py:32:80: E501 line too long (135 > 79 characters)
rendering_testing.py:34:3: E111 indentation is not a multiple of four
rendering_testing.py:34:80: E501 line too long (188 > 79 characters)
rendering_testing.py:36:3: E111 indentation is not a multiple of four
rendering_testing.py:36:16: E231 missing whitespace after ','
rendering_testing.py:37:3: E111 indentation is not a multiple of four
rendering_testing.py:40:3: E111 indentation is not a multiple of four
rendering_testing.py:41:1: E101 indentation contains mixed spaces and tabs
rendering_testing.py:41:1: W191 indentation contains tabs
rendering_testing.py:42:3: E111 indentation is not a multiple of four
rendering_testing.py:46:7: E111 indentation is not a multiple of four
rendering_testing.py:46:13: E222 multiple spaces after operator
rendering_testing.py:46:80: E501 line too long (116 > 79 characters)
rendering_testing.py:47:7: E111 indentation is not a multiple of four
rendering_testing.py:48:80: E501 line too long (106 > 79 characters)
rendering_testing.py:55:1: W391 blank line at end of file

$ python rendering_test.py
Traceback (most recent call last):
File "rendering_test.py", line 26, in
script, config_file = argv
ValueError: need more than 1 value to unpack

This should not happen

An ini file contains Font-file: /home/nandaja/Meera.ttf

While python 2.7 bundled in lib folder of webapp?

All python code should pass pep8

Common convention.

rendering_testing.py will become rendering_test.py

Have a folder for each font. In that folder add ttf, glyphs data and test files

Split the content to multiple sections: Introduction, installation, using, adding a test case, how it works etc.