namlit / siteswap_generator Goto Github PK

The TextEdit in the Pattern Filter Dialog does not provide any Filter-Syntax checking. Therefore it is possible for the user to enter invalid characters resulting in invalid patterns. This is not a big deal, as invalid values in a pattern are ignored by default. However, it would be nice, to have a proper InputFilter on the TextEdit, that does not allow entering invalid characters.

The detailed siteswap view should have an option "generate compatible siteswap", that opens the generation activity again and generates compatible siteswaps.

When the maximum throw is reduced to a number lower, than a value in an existing number filter, the number spinner will only go up to the maximum throw and thus prevent removing the original filter.

http://siteswap.de/v1.0.1/65432

Expected behavior

After the clicking on the reset filters options, I expected everything to go back to default mode.

Actual behavior

After clicking multiple times, the feature is not responding which means it's not working

How to reproduce

• download site swap generator here
• launch the app
• change any default figures or clear all field
• click the reset filters feature below
  Feature not responding.

• Mobile : Infinix note 4
• Operating system: android 7.0
• Version : 1.0

Recording Of The Bug

https://youtu.be/LhCKbdX9AF8

Normally the siteswaps are generated systematically in an ordered way. However, for very long long periods, you are typically not interested in generating all possible siteswaps, but only some interesting ones. With the systematically approach, the first generated siteswaps are usually quite boring and one needs to generate really a lot of siteswaps, to find an interesting one. Therefore it would be nice to have a random generation mode for long siteswaps.

Actual behavior

When i opened the app and after that i started editing the blanks and then i scrolled down and then i activated the random generation mode and after that i set Pattern filter instead of number filter. And then i clicked on zips, zaps and holds. Turning zaps and holds of off. While as zips on. Then i clicked on the reset filters. After that i clicked on the numbers e.g no 4 , no 5 , at least 1 , no 3. I clicked on one of them. And suddenly the app crashed.

How to reproduce

• First you need to download the app from fdroid.

• Install the app.

• Open the app.

• Edit the given blanks.

• Then select one of the filters zips, zaps or holds. And then click on reset filters after that click on one of the numbers. Suddenly the app will crash.

https://youtu.be/nwVh7sJY0Zk

• Browser:siteswap generator.

• Version:1.0.4-beta

• Operating system:7.1.2

• Device model: Redmi 4

Before the first release version, some more testing should be done to ensure stability and correct calculations.

The toasts for invalid input values seem to result in some performance issues and app crashes (See also #34). Therefore they should be replaced by alert dialogs.

The number of jugglers should be limited to 10 or something like that. Otherwise, the generation of the auto filters needs very long and makes the app unresponsive.

Additionally, the error messages for invalid input values need to be improved.

When opening a favorite, deleting the favorite and going back to the favorites view, the view is not updated and the already deleted siteswap is still visible. Manually reloading by clicking on one of the options in the option menu, triggers a reload from database and removes the deleted siteswap from the view.

Currently the Enter Siteswap dialog implicitly takes values like number of juggers an is_synchronous from the main activity. This field should be included in the dialog (and probably be prefilled with the values from the main activity)

It would be really nice, to be able to automatically draw causal diagrams.

When going back from the detailed siteswap view to the generated siteswap list, the share button still shares the detailed siteswap instead of the siteswap list