namesmt / hono-adapter-aws-lambda Goto Github PK

Trigger event routes/paths support works as a simple wrapper that gets the eventSource, and transforms it into method:TRIGGER path:eventSource Request for Hono to process, we would then register routes on TRIGGER method.
For it to work perfectly, the paths of the eventSource should never intended to be prefixed, i.e: TRIGGER method should never be prefixed

Currently Hono doesn't provide any (and I can't find hack-able) way to get or skip the prefix of .route() grouping, so, Hono instances with trigger events would break after getting grouped with .route()

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all non-major dependencies (@antfu/eslint-config, @vitest/coverage-v8, hasown, hono, is-core-module, node, pnpm, vitest)
• chore(deps): update node.js to v20

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

The current implementation simply declares a custom method (TRIGGER) and lets hono internal processes mostly everything, this approach allows a familiar syntax with normal hono routes and allowing using the same processing logic via with the current adapter but poses some limitation:

• fixTriggerRoutes is required if basePath / .route grouping is used.
• Only one route is possible for each source of event.

In lambda-voie, I designed the .eventRoute (trigger events) processing to be able to register multiple routes for the same eventSource (like: aws:s3), so that we could do many things for the same event and it would returns an object containing all responses from all registered handlers, something like:

app.eventRoute('aws:s3', 'log')
app.eventRoute('aws:s3', 'copyToPrivateStoreIfNeeded') // If condition met then copy and returns the new path
app.eventRoute('aws:s3', 'emailIfNeeded') // If condition met then sends email and returns true

One event comes in and it returns something like:

const res = {
  log: true,
  copyToPrivateStoreIfNeeded: "a/b/c.file",
  emailIfNeeded: false,
}

It was amazing and supports the usecase of a complex applications, like what if both api/book/* and api/user/* both wants to register a trigger handler on aws:s3?.

I hope we could bring it to this adapter too.