AI in some missions can not jump if the player is slow about naikari HOT 4 CLOSED

I'm looking at this and I don't think the change you suggest would actually be correct, since that "speed" variable is used elsewhere as well in the exact same way. I also note that this particular code has looked like this for many years; that doesn't necessarily mean it's doing the right thing, but it does mean that it's likely that it was working without noticeable faults until recently.

The only code related to this that I think has ever changed in Naikari's development history is the AI code itself, so it's possible there's some sort of issue with the numbers that has only come to light as a result of those. We'll have to try to figure out what that might be. If it's easy to reproduce, perhaps a git bisect could be in order just to narrow down exactly what change led to this. I'll look into things more closely in a few days, in any case. Perhaps a whole rewrite might even be in order. (Naev actually did a full rewrite, which we tried out with 5112da3, but we subsequently reverted that because it seemed to not work correctly.)

from naikari.

I think my mind on what I think seems correct has changed and I think your initial conclusion seems right, after looking at it for a few more minutes. I'll want to do some checks to verify, thô, and look into why that "speed" variable is getting set <= 0 (which is almost certainly why it got set to 0.0001), since that could be indicative of a deeper problem in the code.

from naikari.

Ok, so, it looks like our initial reservations were right. That "speed" usage was there for a good reason: because it's the drift speed. Looks like what was happening was speed could become zero if the speed limit was low enough, and that would mean that brake distance actually should be zero (as braking isn't actually needed in that case). So I've changed it so that completely not drifting is less likely, added a MAX call to make sure minbrakedist doesn't return a negative number (returns zero instead), and I'll need to also add a guard in the AI code itself to handle the case of min brake distance being extremely small, probably just by also recognizing being inside the jump radius as a condition to start braking.

🕷️

from naikari.

Just finished adding in that last protection and the totality of the changes seems to make things pretty sturdy now. I didn't specifically test the mission you mentioned, but I did test some generic AI pilots with an extremely small speed limit applied and the fix to them should also work for the mission pilot. Please let us know if the bug persists in the latest git revision. Assuming there isn't a problem with the fix, we'll be pushing out a 0.10.1 bugfix release soon.

Thanks for the report. All the information you provided was also very helpful in more easily solving the bug, so thank you for that as well.

from naikari.