nabla-studio / quirks Goto Github PK

Prerequisites

• You read the guidelines for contributing.
• You checked that the enhancement has not yet been reported (also through closed issues).

Describe the current behavior

This repository has copied and pasted code from Cosmology's software, but hasn't included the licenses from those repositories. General rule of thumb is that those licenses, while MIT or BSD or Apache, still have to be included inside of this codebase.

While we appreciate the utility of our software in diverse projects, it is crucial to adhere to the licensing terms under which our code was released. The original code from Cosmology is distributed under [MIT/BSD/Apache] licenses, which, among other conditions, require the inclusion of the original license text in any derivative works or distributions.

Explain the motivation

We believe in open-source collaboration and are more than willing to see our software being used widely. However, it is imperative that such use complies with the legal and ethical standards set by the open-source community.

Provide a list of references

No response

Prerequisites

• You read the guidelines for contributing.
• You are able to reproduce the problem in the latest version of Quirks.
• You checked that the problem has not yet been reported (also through closed issues).

Describe the exact steps to reproduce the problem in as many details as possible

Using nextjs with those dependencies:

• @nabla-studio/chain-registry
• @quirks/react
• @quirks/store
• @quirks/wallets

When passing the following configuration to QuirksConfig:

const CONFIG: Config = {
  assetsLists: [osmosisAssetList, kavaAssetList], // Note the missing akash asset list.
  autoConnect: true,
  chains: [akash, osmosis, kava],
  wallets: [keplrExtension, leapExtension],
};

Describe the issue behavior

When using the connect methods of the useConnect hook, it produces the following runtime error:

Prerequisites

• You read the guidelines for contributing.
• You checked that the enhancement has not yet been reported (also through closed issues).

Describe the current behavior

Add support for hardware wallet using: https://www.npmjs.com/package/@ledgerhq/hw-app-cosmos

Explain the motivation

Because it can increase the number of quirks users by including those who use hardware wallets

Provide a list of references

No response

Prerequisites

• You read the guidelines for contributing.
• You checked that the enhancement has not yet been reported (also through closed issues).

Describe the current behavior

Currently, when calling the function sign() or signCW(), the caller cannot select a fee multiplier together with having fees as auto. Indeed, those functions are calling estimateFee() with the default multiplier of 1.4.
It causes some transactions to fail because the fee is too low.
It would be useful to be able to provide the fee multiplier in case we want to increase for some transactions where the estimation is off, and a multiplier of 1.4 is not enough.

Explain the motivation

This enhancement would be useful because it would allow quirks users to keep using sign() and signCW() functions directly without having to go through cumbersome ways to call estimateFee() separately then provide the fee to the sign() and signCW() functions.

Provide a list of references

No response