n3mo / cyberpunk-theme.el Goto Github PK

Hi. I'm not sure if it's the right place to submit such issue.
I have some distracting problems with this theme because it has different heights for different faces.
It breaks so many things for me, because face are no more of the same size.
I see some strange ordering issues everywhere in emacs and it's expected.
Is there any way to preserve the same font height every where and use theme only for coloring?

In latest emacs (since 24.3 I think), there is a new method for setting terminal colours. As a result, The old method of setting the variable ansi-term-color-vector now produces an error.

The new method is to set various faces. Here's how I've updated my version of cyberpunk (the code format is mostly copied from the zenburn theme).

These colours look ok to me but could probably be improved!

`(term-color-black ((t (:foreground ,cyberpunk-bg
:background ,cyberpunk-bg-1))))

`(term-color-red ((t (:foreground ,cyberpunk-red-2
:background ,cyberpunk-red-4))))

`(term-color-green ((t (:foreground ,cyberpunk-green
:background ,cyberpunk-green+2))))

`(term-color-yellow ((t (:foreground ,cyberpunk-orange
:background ,cyberpunk-yellow))))

`(term-color-blue ((t (:foreground ,cyberpunk-blue-1
:background ,cyberpunk-blue-4))))

`(term-color-magenta ((t (:foreground ,cyberpunk-magenta
:background ,cyberpunk-red))))

`(term-color-cyan ((t (:foreground ,cyberpunk-cyan
:background ,cyberpunk-blue))))

`(term-color-white ((t (:foreground ,cyberpunk-fg
:background ,cyberpunk-bg-1))))

'(term-default-fg-color ((t (:inherit term-color-white))))

'(term-default-bg-color ((t (:inherit term-color-black))))

Best wishes,

Geoff Ferrari

I really like the old colour scheme with the yellow and orange. Can you add and option or maybe a variant of the current theme to use the old colour scheme

Not sure where the color palette came from, but it is not what most people would consider to be cyberpunk. It might behoove you to create a secondary palette for selection that is more true to the genre.

Don't hate me, just a suggestion...

Currently, ediff does not follow the cyberpunk theme, it just shows the yellow and green bars. It seems many themes leave out ediff, so maybe this is just hard to do

Org Clock tables with headings that have progress indicators have the yellow box highlight on the progress indicator. This pushes the pipes (|) around and out of sync as you can see on the right of the screenshot.

Ideally, I'd like to keep the highlighting, it's very nice, but my obsessive nature can't not see the out of line pipes.

Like the theme. I would like to add this package to MELPA but it is not currently compatible with package.el. Could you change the top line to:

;;; cyberpunk-theme.el --- Cyberpunk Colour Theme

and add a line under the Keywords that is a version,

;; Version: 1.0

For MELPA purposes the version is irrelevant but it's nice if you keep the package compatible with package.el in general.

You can test if your fixes work by doing (package-buffer-info) and seeing if it returns an error.

I am not sure if it is intended to be like that but for me they look quite "bad":

I really like this theme but when I use it I lose transparency.

I am using emacs from a terminal that is set to transparent. If I load emacs without this theme, the background is transparent.

However, when I load this theme, the background is solid black with no transparency. Is there a way to change this?

To see an example (open a customize item, and press tab until cursor is on a button):

1. M-x customize-group RET emacs RET
2. Press TAB until the cursor is on top of a button.

Here is a screenshot with a tiny arrow where the cursor is (hard to see)

There hasn't been any release in a while an master contains some important fixes.
What about a 1.22?

Currently search highlighting displays yellows blocks which are rather displeasing to the eye in my opinion.

The following turns it to yellow underlining:

(set-face-attribute 'lazy-highlight nil
                          :underline '(:color "yellow")
                          :foreground 'unspecified
                          :background 'unspecified)

Thanks for making this beautiful theme!

When highlighting parenthesis matches, is it possible to keep foreground text highlighting, now when it's highlighted foreground text is single color?

(setq show-paren-style 'mixed)
;; I am trying to tweak using this line
;; (set-face-attribute 'show-paren-match-expression nil :background "#4f4f4f" :foreground 'unspecified)

I just enabled company-mode and when a completion is proposed, I cannot read the first line:

I've restarted emacs to make sure there was no customization involved, and I get the same thing. Is it possible to make the text more visible on the pink background?

This is with the cyberpunk theme loaded

This is without it

I was going crazy thinking this was an issue with my bitmap haxor fonts but it turns out that the issue seems to be coming from this theme. I don't know if you consider this a bug not, but either way I was hoping you could at least point me in the right direction to find a quick fix for it.

opening something like clojureverse.org and it's just a sea of yellow

Emacs version on Mac OS Sierra 10.12.3

~$ emacs --version
GNU Emacs 25.1.1
Copyright (C) 2016 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
~$

I point to melpa-stable using -

(add-to-list 'package-archives
             '("melpa-stable" . "https://stable.melpa.org/packages/") t)

It finds the package alright, but then

https://stable.melpa.org/packages/cyberpunk-theme-1.17.el: Not found

Got around it by loading the .el locally, but would love to let emacs manage it.

Thanks for the theme btw !

I've recently tried to move away from melpa to something more stable and found melpa-stable to be useful in this regard. The only sticking point is that the best color theme (cyberpunk) is not available in melpa-stable :) Unfortunately, once you need something that is not in melpa-stable, it is a lot of work to limit what comes in from there (I've not actually tried to do the limiting, so maybe it's not terrible, but it sounds terrible).

Might you consider releasing to melpa-stable (possibly in addition to melpa)? I don't think it is much extra work (and I don't think you even need tags unless you want to have them).

https://github.com/milkypostman/melpa#stable-packages

If not, I'll try to figure out how to limit packages coming from melpa so I can get my favorite theme without the instability of all of melpa.

Thanks!

FYI: There is a new version of magit coming and it would be really nice to have cyberpunk theme support!å Please see magit/magit#1922 (comment).

In Magit Status, when the point is on a commit (e.g. in the "Recent commits" section) the commit number becomes unreadable.

Same with Magit Log.

Any fix?

Hi,

Not sure if this is a feature, but it looks like the default colors kind of work against racket-mode. What do you think?

Magit diffs are hard to read for 2 reasons:

• The unselected diff hunk heading background is black, thus it's hard to visualize the different hunks. Fix:

          (set-face-background 'magit-section-highlight cyberpunk-bg-1)
          (set-face-background 'magit-diff-hunk-heading cyberpunk-bg+1)
          (set-face-background 'magit-diff-hunk-heading-highlight cyberpunk-bg+2)
          (set-face-background 'magit-diff-hunk-heading-selection cyberpunk-bg+2)

• The "added" diff is blue on green with low contrast which makes it very hard to read. Quick workaround: increase the contrast a little bit:

(set-face-background 'diff-refine-added cyberpunk-green-2)

When I use cyberpunk theme fringe color is always white. If I switch to a dark theme such as tango-dark and switch back to cyberpunk theme it stays dark. So it seem cyberpunk doesn't set the fringe color.

Emacs 25.3.2