mythicalgames / dgoods Goto Github PK

As a contract owner, if I forget the "token name" used after I've created a dgood how am I able to look it up again?

assertion failure with message: Symbol must match symbol in config

There may be digital assets like videos, e-books, music, games, photography etc. where partial ownership can be of great value. When owing the partial ownership on any NFT (say of any particular video) and allowing the person to sell their % rights may allow the public participation in such valuable assets too.
eg. for any ebook, ebooks category and harrypotter token name can be created, there may be many stakeholders like publisher, author, retailer, distributor etc. The token ownership may be issued as per their percentage holdings of their rights. For that we can create a token say PER which can be issued maximum 100 (denoting 100%) for any token. Similarly for videos, photography, music etc. too.
What's your opinion?

https://github.com/MythicalGames/dgoods/blob/master/include/dgoods.hpp#L55

/usr/local/Cellar/eosio.cdt/1.6.1/opt/eosio.cdt/bin/wasm-ld: error: CMakeFiles/dgoods.wasm.dir/dgoods.cpp.o: undefined symbol: dgoods::setrampayer(eosio::name, unsigned long long)
make[2]: *** [dgoods/dgoods.wasm] Error 255
make[1]: *** [dgoods/CMakeFiles/dgoods.wasm.dir/all] Error 2

We need a two-step alternative to transfernft which causes the receiver to assume RAM costs.

This is absolutely necessary for dapps and marketplaces. At about 0.5kb per NFT, which has a current cost of about $0.21, many dapps that receive and send a lot of NFTs simply won't be able to afford it, and may be forced to use other standards instead of dgoods.

In the issue action, supplying any quantity to the action will always produce 1 NFT. To maintain consistency with fungible tokens, I'd suggest either separating issue as it's own action issuenft, or loop through the quantity value provided and mint the supplied number of NFTs.

According to the example usage page here https://github.com/MythicalGames/dgoods/blob/master/example_usage.md, we can set a fixed amount of tokens or set a fixed amount of mint time.

Is there a way to have a perpetual minting process that doesn’t have a fixed window nor a fixed supply?

Is there a typo or issue here?

https://github.com/MythicalGames/dgoods/blob/master/src/dgoods.cpp#L66

The usage are weird.

/Users/xxx/github.com/evolutionlandorg/eos-contracts/dgoods/dgoods.cpp:66:68: error: unknown type name 'actions'; did you mean 'action'?
        stats.burnable = burnable;                                 actions
                                                                   ^~~~~~~
                                                                   action
/usr/local/Cellar/eosio.cdt/1.6.1/opt/eosio.cdt/bin/../include/eosiolib/action.hpp:194:11: note: 'action' declared here
   struct action {
          ^
/Users/xxx/github.com/evolutionlandorg/eos-contracts/dgoods/dgoods.cpp:67:9: error: redefinition of 'stats'
        stats.transferable = transferable;
        ^
/Users/xxx/github.com/evolutionlandorg/eos-contracts/dgoods/dgoods.cpp:61:49: note: previous definition is here
    stats_table.emplace( get_self(), [&]( auto& stats ) {
                                                ^
/Users/xxx/github.com/evolutionlandorg/eos-contracts/dgoods/dgoods.cpp:67:14: error: expected ';' at end of declaration
        stats.transferable = transferable;
             ^
             ;

I was thinking that there are so many eosio compatible blockchains that could implement dgoods it could be nice to change in the README to something more broad. For example LynxChain has implemented this standard.

For NFT, query the dgoodstats table.
However , It's hard to query FT for someone:
1.Query table "accounts", get "category" and "token_name"
2.According to first step ,query table "dgoodstats";

Why not return "fungible" in query table "accounts" ?