mydayyy / pbcli Goto Github PK

Hello,

while testing I found that pbcli did not work with a PrivateBin instance like https://example.org/localpath/, that means with a local path added to the URL.

I investigated this further and found a workaround for this problem with the following change:

$ git diff
diff --git a/src/api.rs b/src/api.rs
index a48408a..b8d530c 100644
--- a/src/api.rs
+++ b/src/api.rs
@@ -17,7 +17,7 @@ impl API {
     pub fn new(mut url: Url, opts: Opts) -> Self {
         url.set_fragment(None);
         url.set_query(None);
-        url.set_path("");
+//        url.set_path("");
         Self { base: url, opts }
     }

@@ -118,4 +118,4 @@ impl API {
             s => Err(PasteError::UnknownPasteStatus(s)),
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/main.rs b/src/main.rs
index b5a78f9..a63a7bd 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -110,7 +110,7 @@ fn handle_post(opts: &Opts) -> PbResult<()> {
         std::io::stdout().write_all(serde_json::to_string(&res)?.as_bytes())?;
     } else {
         let mut url = opts.get_url().clone();
-        url.set_path("");
+//        url.set_path("");
         url.set_query(Some(&res.id));
         url.set_fragment(Some(&res.bs58key));
         std::io::stdout().write_all(url.to_string().as_bytes())?;

This works with URLs like https://example.org/localpath/ but fails with https://example.org/localpath (i.e. without the slash at the end). So you probably want to find a more resilient solution.

Hi,

Would it be possible to have some sanity checks?

Specifically regarding file size, if a user is suffering from log bloat due to an issue on their system or tries to upload a file over a certain size could the user be prompted by pbcli with a message saying "hey you are about to upload a file of X size, please note this may be rejected by the host and/or take a long time to upload are you sure you want to continue? Y/N"

Perhaps have a default allowed file size and include a file size limit flag that could be set in custom configs should pbcli be packaged by a distro?

Love the tool BTW, really appreciate the work.