Giter Club home page Giter Club logo

mx-division-builds's People

Contributors

dependabot[bot] avatar durant32 avatar eeemptyy avatar fooweb avatar mxswat avatar wkrick avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

mx-division-builds's Issues

Accounting for Special Ammunition/Status Effects

Currently, the damage calculation doesn't account for special ammunition or status effects. This highly underestimates the damage that is output by builds using gear sets like Ongoing Directive or weapons similar to Pyromaniac.

My proposal is to have an option to toggle certain status effects that will take effects like Wicked, Rules of Engagement, Ignited, etc. into account during DPS calculation.

Gearset - Two Piece Bonus - Second Attribute incorrectly classified

SOCNightStalker: Seems there's an issue with eclipse and ninjabike bag in hazard protection
if you put 3 pieces of eclipe you have Hazard protection to 40 (30+10SHD) and it is shown in Defensive cores

But if you put two eclipse pieces with ninjabike bag the eclipse, hazard protection is not added to Defensive Cores but it is show in the Utility cores

image2
image1

outdated values

outdated values on future initiative
as for 2 set bonus it says 15% repair skill
while in game is 30%

Is it possible to add Skills to the tool?

To be honest this addition would this tool make (kind of) perfect.
I am using it to show certain builds in our clan, but there are always questions about the skills.
Are there any plans to add this?

Add localization

I am currently writing this issue using a translator. Please understand if you see awkward or inappropriate expressions.

The Division 2 is served in several languages. However, this wonderful tool is currently only available in English.
According to the Steam store page, The Division 2 is served in 14 languages, including English.

I suggest adding a drop-down list button to switch user languages on the main screen of this tool.

From a technical standpoint, the language you choose is stored in the Local DB, and each language should be loaded when necessary with an independent language-specific JSON file.
When using independent language-specific JSON files, the participation of contributors in each language can be recorded as individual commits.

Once again, thank you for making this wonderful tool!

Claws Out holster - only one fixed attribute is shown in totals and they swap when loaded from URL

Steps to reproduce:

  1. create new blank build
  2. add "Claws Out" holster
  3. note the position of the attributes and note that melee damage is calculated in sidebar but not pistol damage
  4. copy URL, open a new browser window, paste the URL into the address bar, go to URL
  5. URL will change, attributes will swap places, pistol damage is in sidebar, but not melee damage

This is my original URL:
https://mxswat.github.io/mx-division-builds/#/AwWl7SOreAuGS4uo1Hlq53CDMALJAIwAcelCONm6tS9VUTDLwQA

Note the position of the pistol and and melee damage. Melee damage is shown in totals, but not pistol damage...
image

After loading the above URL in a new window, it changes to this URL:
https://mxswat.github.io/mx-division-builds/#/AwWl7SOreAuGS4uo1Hlq53CDMALJPgOx4UI7Wbo1J2VSP3PBA

Note the position of pistol and melee damage have swapped. Pistol damage is shown in totals, but not melee damage...
image

Gear and Gear mods Critical Chance not counted in the weapon stats

Gear and Gear mods Critical Chance not counted in the weapon stats, but weapon mods and watch is.

Discord links of the reports, for reference and additional data:

https://discord.com/channels/702180050791039016/705147074676785262/1080570501866475650
"
The live build currently doesn't appear to be applying Crit Chance to the weapon properly. This build has 40% crit chance from the watch and gear attributes but at the bottom the Capacitor is only showing a 20% crit chance total. I don't thinkhttps://mxswat.github.io/mx-division-builds/#/MwRgtATGAMNgbHWympdAXAVi68iRh1Upjltcpgx8xgAONJsjEcU5zsmDAFkV6wO3EWgzAowrtPIRgATgRh5jEDhpYA7BoJZGLUYYyGuGCEA "

https://discord.com/channels/702180050791039016/705147074676785262/1080926024851787826
"hm... seems like chc isnt working.. tested with max watch, 1 ceska and 15 chc on weapon, yet chc shows 25% (should be 35% (10 +10+15)

tested with zero chc on 1 ceska piece (no other stats or gear items) and max watch +15 chc weapon mods. so looks likes just counting watch + weapon mods."

Memento cores aren't functioning properly

When having the Memento selected, it only activates the red core. In the drop down menu it doesn't give the option of picking even a different main core, so it's only showing up as 1 red.

URL is not saving core attributes for "Ammo Dump" and "Claws Out" holsters

Steps to reproduce:

  1. open a new blank build
  2. add the "Ammo Dump" or "Claws Out" named holster
  3. take note of the core attribute
  4. copy the URL
  5. open a new browser window
  6. paste the URL into the address bar
  7. go to URL
  8. the core attribute will be blank

This doesn't appear to happen with "Forge", "Picaro's Holster", or any other named items in other slots that I tested so I think it's related to these items having an additional fixed attribute.

improving the build tool

I'd like to propose a change and an addition that would imo make the build tool even better.

  1. I'm guessing this is a relatively simple change to implement, but it would be very welcome as it would cut down on a lot of unnecessary repetition when theory crafting. When switching between brandsets, gearsets or weapons leave the attribute, talent and mod fields populated with previously selected choices wherever possible. Clearing them out doesn't help anyone since if you do want to change them it takes just as many clicks to change them from an empty value as it does to change them from an unwanted value. Leaving them populated however comes in very handy when you're just trying out different brandset/gearset/weapon combinations using the same attributes, talents and mods which I would think is more common than changing everything.

  2. A feature request to automatically fully populate the gear slots to meet a selected criteria. Lets say one wants to create a build focused on armor, or CHD, or skill haste, skill damage, armor regen, hazard protection etc. Instead of starting with a blank slate as we do now, it would be much more helpful to be able to start with a selection that represents max armor, or max CHD, max skill haste, etc and start changing that until you're happy with the outcome. Finding these maximums currently takes a lot of familiarity with all available gear pieces (all brandset and gearset bonuses, all named attributes, all mods), good memory plus a talent for combinatorics, or substantial time investment to find the right selection of gear pieces and still you don't have the confirmation that the current choices indeed represent the max. With the right logic however the tool should be able to solve such "find max" problems and help users come up with desired builds.

Thanks for your tool, I hope you have the time and interest to implement at least the proposed change if not the feature as well.

The Division 2 Builds Printable style

Requirements

  1. Install the extension : Stylus
  2. Install the theme

Use

  • Make a build
  • To enable just activate the checkbox
  • Click on the icon
    image
  • Check or uncheck the check box.
    image
  • Print or take a screenshot with the button
  • Disable the theme uncheck the checkbox

To edit the theme.

  • Click on the icon
    image

  • Click on the pencil icon
    image

  • Edit

  • Save

Addons
To disable the toolbar uncomment this line
image

  1. top tool bar

.tile.toolbar-container { display: none !important;}

To change the color of the names uncomment this line
image
image

  1. Background Names

.gear-name, .weapon-name { background: white !important;}

Recommended printer settings

Scale

74% Chrome and Opera
60% firefox

Preview with addons

image

Preview without addons

image

Result Build

Printed Eclipse Protocol + Capacitor.pdf

Screenshot

my-build

Note to devs:
i love this tool ♥️♥️♥️

Can I translate it to Chinese?

Dear author, I am a The Division2 player from China. I am very interested in your project and have completed some Chinese translations. I hope I can get your permission to allow me to use and deploy and promote your project. The following is my project address http://division.zjcblog.cn/

Missing 3-piece bonuses when using NinjaBike backpack with 2 pieces of some gearsets: Heartbreaker, Hotshot, Hunter's Fury

Heartbreaker:
2 piece bonus: 15% AR Damage / 15% LMG Damage
3 piece bonus: 15% Weapon Handling

The 3-piece Weapon Handling bonus is missing:
https://mxswat.github.io/mx-division-builds/#/CwNgtADJ1bP3RAuArC+BGaGDMj4BMCMS+Zx5sSwwFdlJDT9p9blrzZn7CPXjIA

Hotshot:
2 piece bonus: 30% Marksman Rifle Damage / 30% Stability
3 piece bonus: 30% Headshot Damage

The 3-piece Headshot Damage bonus is missing:
https://mxswat.github.io/mx-division-builds/#/CwTgtADJ1bP3RAuArC+BGaGDMj4BMCMS+Zx5sSwAHBfZSY8w6Q+5Wy2Vxwr9yZA

Hunter's Fury:
2 piece bonus: 15% SMG Damage / 15% Shotgun Damage
2 piece bonus: 20% Armor on Kill / 100% Health on Kill

The 3-piece Armor on Kill and Health on Kill bonuses are missing:
https://mxswat.github.io/mx-division-builds/#/CwBgtOkdWz8gFwFZnwIzXQZjlATAjInkaeYjmdecbfTSTcxQ6y2U2wiUA

Named Weapons

Just creating this as a reminder, stuff like the Maxim 9 need to be added. <3

Third weapon attribute changes for all weapon

Hey I am using this and great work by the way but I am seeing an issue where when I adjust the third attribute on my first weapon it also sets it to the same value for my second weapon and vice versa. In my case I have a Bakers Dozen and Merciless and the third attribute is CHC, BD has 8.5 Merc has 9., when I change either one it switches it for the other to the same that I just entered. Thanks!

http://www.reddit.com/r/thedivision/comments/gh72vq/the_division_2_build_tool_is_now_in_beta_3/fq7z5wo?utm_source=share&utm_medium=web2x

Negotiator's Dilemma with Critchance Issue with more than 2 Set Items and other Brand Crit Bonus

Thanks for the tool, i have found an issue with Crit Brand Bonus.
I hope you understand the problem with this sampels, and can fix it.

3 Items ND -> Crit Chance 15%
https://mxswat.github.io/mx-division-builds/#/EwRgtADJ1bOQLmAFnnA7AVjY424YBsOECBJaZF5sVN1d1l9LirLZQA

3 Items ND and 1 Ceska Vyroba s.r.o. -> Crit Chance 15%-> should be 25%
https://mxswat.github.io/mx-division-builds/#/EwRgtADJ1bOQLmAFnnA7AVjY424YBsOECIAnCVaQdTArY2g3Yy0x+6-REA

Same Problem with 3 Items ND and 2 Providence Defense-> Crit Chance 15%-> should be 25%
https://mxswat.github.io/mx-division-builds/#/EwRgtADJ1bOQLmAFnnA7AVjY424YBsOECAzASWkvlZafXYoy80-Qqy50A

2 Items ND and 1 Ceska Vyroba s.r.o. -> Crit Chance 25%
https://mxswat.github.io/mx-division-builds/#/EwRgtADJ1bOQLmAFnnA7AVjYgzADhzmMRAE4jKIETa0aqiG6XnHi2X6Ig

2 Items ND and 2 Providence Defense and 1 Ceska Vyroba s.r.o. -> Crit Chance 35%
https://mxswat.github.io/mx-division-builds/#/EwRgtADJ1bOQLmAFnnA7AVjYgnDuQxAZiLLSW3OoWoMTpsYNvqaA

3 Items ND and 2 Providence Defense and 1 Ceska Vyroba s.r.o. > Crit Chance 15%-> should be 35%
https://mxswat.github.io/mx-division-builds/#/EwRgtADJ1bOQLmAFnnA7AVjYgnDuQxAZiLLSW3OqXGoIXpqYZbMaA

Would be great if there were some visual indicator of stability/range for weapons that mimics the in-game display

It would be great if there were some visual indicator of stability/range for weapons that mimics the in-game display. I don't know how anyone else tends to build, but I usually have some target breakpoints in mind for stability and range and I have trouble identifying them with this tool. Some displays that mimic the ones in-game would be useful, factoring mods and gear attributes in.

Responsive UI

Description

Currently on mobile all the columns are squashed together. The UI should adjust since its already a grid.

SHD level status need to be applied

They have great affection on total status

For example, CHC 10% & CHD 20% & TWD 10% can differ more than 20% as much as to total DPS.

And hazard protection 10% is very huge different between 90% and 100%

So, It is required at least simple function just toggle SHD level to max or min.

Muzzle mods being removed

Whenever I bookmark a build and then come back to it the muzzle mod is always removed from the weapons

Third attributes on different weapons using same value

I know this was an issue you found and fixed about a year ago, but I just came across it of my own accord. For some reason, the third attribute is linking up across different weapons - it seems to be weapon-agnostic, as I had the issue on multiple different weapon types, and different weapons within those types, and even happened across different browsers.

Tactical M1911 Swap Speed incorrectly capped at 6

Tried out the site after seeing the post on reddit. I went to enter the pistol I currently have, Tactical M1911 and when I pick Swap Speed it is limited to 6, but mine in game is 10% and isn't even maxed.

Protection from Elites is not recalculated on changing Specialization

Great tool! Thanks!

https://mxswat.github.io/mx-division-builds/#/MwTgtOCsYAxgbLMBGFcAsIBM1laXIQFzqKEoIrLArTl5j5zIDsM7zRk+04+ieZmw5hMONCiYFYRYCwhg601MgzYl5YsBrhUmiqrAAOaZtkm+pg3DJWYRHOiSr88rImAmjNZtCx6SJ2YYVDcPRBZ5X0kZdxU0XEiUFl0WE2QjOBAAOlwNEiA

Hopefully, the above link shows the build I had entered with 3 12% Protection from Elites mods and the Technician Specialization. The tool shows 36% PfE which is correct. I then realized that an extra 10% PfE could be gained by switching to the Survivalist Specialization, which I did, but the PfE total did not update. It should have gone up to 46% with this change.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.