The mutwo.midi from mutwo-org

mutwo.midi's People

Contributors

Watchers

mutwo.midi's Issues

Fix tempo_envelope parameter

Since mutwo.core 0.61.0 events have a tempo_envelope attribute. EventToMidiFile should use this tempo_envelope attribute instead of using its own field. But it should add a field metrize: bool = True.

Fix conversion of events with small durations

Currently conversion of events with smaller duration values is broken.

from mutwo import midi_converters
from mutwo import core_events
# this works
midi_converters.EventToMidiFile().convert(core_events.SimpleEvent(2), 'test.mid')
# this will fail
midi_converters.EventToMidiFile().convert(core_events.SimpleEvent(0.5), 'test.mid')

error message:

Traceback (most recent call last):
  File "/build/mutwo.midi/tests/converters/frontends_tests.py", line 768, in test_convert_event_with_small_duration
    self.converter.convert(simple_event, self.midi_file_path)
  File "/build/mutwo.midi/mutwo/midi_converters/frontends.py", line 947, in convert
    midi_file.save(filename=path)
  File "/nix/store/fnldc12gqvcydd3ggnpwrc48v5rckmwm-python3.9-mido-1.2.10/lib/python3.9/site-packages/mido/midifiles/midifiles.py", line 446, in save
    self._save(file)
  File "/nix/store/fnldc12gqvcydd3ggnpwrc48v5rckmwm-python3.9-mido-1.2.10/lib/python3.9/site-packages/mido/midifiles/midifiles.py", line 459, in _save
    write_track(outfile, track)
  File "/nix/store/fnldc12gqvcydd3ggnpwrc48v5rckmwm-python3.9-mido-1.2.10/lib/python3.9/site-packages/mido/midifiles/midifiles.py", line 251, in write_track
    raise ValueError('message time must be non-negative in MIDI file')
ValueError: message time must be non-negative in MIDI file

`MidiFileToEvent` doesn't work for midi files without note_off

Some midi exporter don't use note_off messages, but note_on messages with velocity=0. Mutwo currently can't pass such midi files. This should be fixed by adding a new flag to EventToMidiFile.

Thanks @timpauli for detecting this bug.