Giter Club home page Giter Club logo

Comments (3)

AlaricBaraou avatar AlaricBaraou commented on May 18, 2024

I can enable image transparency for .png by setting transparent to true on the image material.
But when used with a frame, it will use the color of the frame as a background.

Do we need the inside of the frame to be transparent when used with a png ?
If yes, the frame component will need some adjustments otherwise it's just about the transparent property on the image material.

Also if I understood correctly, it's up to the user to enable this transparency or not right ?
Or are we going with a default transparent material when a .png is used ?

I see pro and cons to both approch.

I'll do a PR when I'll have those infos :)

from spacesvr.

ianyimi avatar ianyimi commented on May 18, 2024

Thanks for this note I forgot about the frame back. Transparency doesn't need to be the default setting. I think it would be nice to have the inside of the frame be transparent as well and it shouldn't be too difficult a fix either. Also yes, the user will be able to toggle transparency.

from spacesvr.

ianyimi avatar ianyimi commented on May 18, 2024

Also I just thought of this but it would be cool as well to add a frameColor attribute to the image component, but I'll make a new issue for this

from spacesvr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.